�zkan...
Thanks for this patch, applies cleanly but the build fails with this error:
pktcdvd.c: In function `kcdrwd':
pktcdvd.c:1186: `SCHED_OTHER' undeclared (first use in this function)
pktcdvd.c:1186: (Each undeclared identifier is reported only once
pktcdvd.c:1186: for each function it appears in.)
pktcdvd.c:1190: structure has no member named `sigmask_lock'
pktcdvd.c: In function `pkt_init_queue':
pktcdvd.c:2269: warning: initialization makes integer from pointer without a
cast
pktcdvd.c:2269: warning: initialization from incompatible pointer type
make[2]: *** [pktcdvd.o] Error 1
make[1]: *** [_modsubdir_block] Error 2
make: *** [_mod_drivers] Error 2
I'll try to hack around and see if I can get this working and report any
success that I have.
Thanks
- Phillip
--- "O.Sezer"
Phillip Ross wrote:
I was just wondering... is the packet writing patch for Redhat's kernels still being maintained?
Thanks - Phillip
Don't have RedHat installed on my machines, but since they base their kernels mostly on -ac patches, you may want to try the pktcd-2.4.21rc7-ac1 patch, plus its update counterpart from http://w1.894.telia.com/~u89404340/patches/packet/2.4/ac/ You may experience some offsets and fuzzes but no rejects.
�zkan Sezer
OK, here's a _completely untested_ patch against rh9 (2.4.20-18.9) (based on the tested -ac patch.) If you report back some success, I guess Peter may upload it for general use.
O. Sezer
ATTACHMENT part 2 application/octet-stream name=pktcd-rh9-2.4.20-18.patch.bz2
__________________________________ Do you Yahoo!? SBC Yahoo! DSL - Now only $29.95 per month! http://sbc.yahoo.com
Hi: Phillip Ross wrote:
Özkan...
Thanks for this patch, applies cleanly but the build fails with this error: pktcdvd.c: In function `kcdrwd': pktcdvd.c:1186: `SCHED_OTHER' undeclared (first use in this function) pktcdvd.c:1186: (Each undeclared identifier is reported only once pktcdvd.c:1186: for each function it appears in.) pktcdvd.c:1190: structure has no member named `sigmask_lock' pktcdvd.c: In function `pkt_init_queue': pktcdvd.c:2269: warning: initialization makes integer from pointer without a cast pktcdvd.c:2269: warning: initialization from incompatible pointer type make[2]: *** [pktcdvd.o] Error 1 make[1]: *** [_modsubdir_block] Error 2 make: *** [_mod_drivers] Error 2
Try changing SCHED_OTHER to SCHED_NORMAL . (see linux-2.4.20-o1-sched+threading-backport.patch from the kernel*.src.rpm) I'll try looking into the issue from line 2269 now. Özkan Sezer
Phillip Ross wrote:
Özkan...
Thanks for this patch, applies cleanly but the build fails with this error: pktcdvd.c: In function `kcdrwd': pktcdvd.c:1186: `SCHED_OTHER' undeclared (first use in this function) pktcdvd.c:1186: (Each undeclared identifier is reported only once pktcdvd.c:1186: for each function it appears in.) pktcdvd.c:1190: structure has no member named `sigmask_lock' pktcdvd.c: In function `pkt_init_queue': pktcdvd.c:2269: warning: initialization makes integer from pointer without a cast pktcdvd.c:2269: warning: initialization from incompatible pointer type make[2]: *** [pktcdvd.o] Error 1 make[1]: *** [_modsubdir_block] Error 2 make: *** [_mod_drivers] Error 2
I'll try to hack around and see if I can get this working and report any success that I have.
Thanks - Phillip
OK, can you please try this patch (the SCHED thing in the previous mail included). Note that this is way too quick'n'dirty, no promises. Seems like max_bomb_segments is back.. Özkan --- ac/drivers/block/pktcdvd.c.orig 2003-06-16 11:34:05.000000000 +0300 +++ rh/drivers/block/pktcdvd.c 2003-06-16 11:47:15.000000000 +0300 @@ -1183,7 +1183,7 @@ */ daemonize(); - current->policy = SCHED_OTHER; + current->policy = SCHED_NORMAL; set_user_nice(current, -20); sprintf(current->comm, pd->name); --- ac/include/linux/pktcdvd.h.orig 2003-06-16 11:34:05.000000000 +0300 +++ rh/include/linux/pktcdvd.h 2003-06-16 11:46:50.000000000 +0300 @@ -203,6 +203,7 @@ ((elevator_t) { \ 0, /* not used */ \ 0, /* not used */ \ + 6, /* max_bomb_segments */ \ \ pkt_elevator_merge, /* elevator_merge_fn */ \ pkt_elevator_merge_req, \
O.Sezer wrote:
Phillip Ross wrote:
Özkan...
Thanks for this patch, applies cleanly but the build fails with this error: pktcdvd.c: In function `kcdrwd': pktcdvd.c:1186: `SCHED_OTHER' undeclared (first use in this function) pktcdvd.c:1186: (Each undeclared identifier is reported only once pktcdvd.c:1186: for each function it appears in.) pktcdvd.c:1190: structure has no member named `sigmask_lock' pktcdvd.c: In function `pkt_init_queue': pktcdvd.c:2269: warning: initialization makes integer from pointer without a cast pktcdvd.c:2269: warning: initialization from incompatible pointer type make[2]: *** [pktcdvd.o] Error 1 make[1]: *** [_modsubdir_block] Error 2 make: *** [_mod_drivers] Error 2
I'll try to hack around and see if I can get this working and report any success that I have.
Thanks - Phillip
OK, can you please try this patch (the SCHED thing in the previous mail included). Note that this is way too quick'n'dirty, no promises. Seems like max_bomb_segments is back..
Özkan
------------------------------------------------------------------------
--- ac/drivers/block/pktcdvd.c.orig 2003-06-16 11:34:05.000000000 +0300 +++ rh/drivers/block/pktcdvd.c 2003-06-16 11:47:15.000000000 +0300 @@ -1183,7 +1183,7 @@ */ daemonize();
- current->policy = SCHED_OTHER; + current->policy = SCHED_NORMAL; set_user_nice(current, -20); sprintf(current->comm, pd->name);
--- ac/include/linux/pktcdvd.h.orig 2003-06-16 11:34:05.000000000 +0300 +++ rh/include/linux/pktcdvd.h 2003-06-16 11:46:50.000000000 +0300 @@ -203,6 +203,7 @@ ((elevator_t) { \ 0, /* not used */ \ 0, /* not used */ \ + 6, /* max_bomb_segments */ \ \ pkt_elevator_merge, /* elevator_merge_fn */ \ pkt_elevator_merge_req, \
GRRRRR... Forgot to change this one.. Apply this new rh-fix-test2.diff on top the previous rh-fix-test.diff and please try. I did a quick "make modules" and no errors or warnings were issued for pktcdvd.c . Özkan Sezer --- ac/drivers/block/pktcdvd.c.orig 2003-06-16 13:11:52.000000000 +0300 +++ rh9/drivers/block/pktcdvd.c 2003-06-16 13:22:52.000000000 +0300 @@ -1187,10 +1187,10 @@ set_user_nice(current, -20); sprintf(current->comm, pd->name); - spin_lock_irq(¤t->sigmask_lock); + spin_lock_irq(¤t->sighand->siglock); siginitsetinv(¤t->blocked, sigmask(SIGKILL)); flush_signals(current); - spin_unlock_irq(¤t->sigmask_lock); + spin_unlock_irq(¤t->sighand->siglock); q = blk_get_queue(pd->dev); my_queue = blk_get_queue(pd->pkt_dev);
participants (2)
-
O.Sezer -
Phillip Ross