On 08/08/2013 11:03 AM, Adam Spiers wrote:

Andreas Jaeger (aj@suse.com) wrote:

...

A couple of packages check for /etc/SuSE-release and I suggest to deprecate it and use the new cross-distro location /etc/SuSE-release ^^^^ instead.

Presumably you meant 'os' there :-)

Indeed - like in the subject. ;) Thanks, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 08/08/2013 11:15 AM, Ruediger Meier wrote:

On Thursday 08 August 2013, Andreas Jaeger wrote:

...

A couple of packages check for /etc/SuSE-release and I suggest to deprecate it and use the new cross-distro location /etc/SuSE-release instead.

I've asked Coolo to addthe following line to the end of /etc/SuSE-release now:

# /etc/SuSE-release is deprecated and will be removed in the future, use /etc/os-release instead

I filed a few bugs against SUSE packages that check /etc/SuSE-release to switch and suggest that you fix - and send upstream - any checks for /etc/SuSE-release.

To "fix" this in a backward compatible way you could better use lsb_release -d -r -c

Indeed, an option as well - but lsb_release is not required to be installed on every system. Forward looking, /etc/os-release will be. But if - as today - you do: if /etc/SuSE-release ... elsif /etc/fedora-release You can change this to: if /etc/os-release.. elsif `lsb_release` ... Or something like that. Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Thu, Aug 8, 2013 at 12:39 PM, Togan Muftuoglu wrote:

...

...

...

...

...

On Thu, 08 Aug 2013 10:51:43 +0200, Andreas Jaeger said:

Andreas> A couple of packages check for /etc/SuSE-release and I suggest to Andreas> deprecate it and use the new cross-distro location Andreas> /etc/SuSE-release instead.

Andreas> I've asked Coolo to addthe following line to the end of Andreas> /etc/SuSE-release now:

Andreas> # /etc/SuSE-release is deprecated and will be removed in the Andreas> future, use /etc/os-release instead

Andreas> I filed a few bugs against SUSE packages that check Andreas> /etc/SuSE-release to switch and suggest that you fix - and send Andreas> upstream - any checks for /etc/SuSE-release.

Yes but there is a tiny problem as I was told by shorewall upstream Debian 7 and Fedora 19 are also using /etc/os-release

So how do we distinguish that this is openSUSE

Ehm... ~> cat /etc/os-release NAME=openSUSE VERSION="12.2 (Mantis)" VERSION_ID="12.2" PRETTY_NAME="openSUSE 12.2 (Mantis) (x86_64)" ID=opensuse ANSI_COLOR="0;32" CPE_NAME="cpe:/o:opensuse:opensuse:12.2" So... ~> grep -q openSUSE /etc/os-release && echo "It's openSUSE" || echo "It's not" It's openSUSE -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Thu, Aug 8, 2013 at 1:57 PM, Andreas Jaeger wrote:

Better: source /etc/os-release if [ $NAME = "openSUSE" ] ; then... fi

Call me paranoid, but I wouldn't source files like that, that aren't part of my own package. And even then... -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Thu, Aug 8, 2013 at 3:34 PM, Andreas Jaeger wrote:

On 08/08/2013 07:10 PM, Claudio Freire wrote:

...

On Thu, Aug 8, 2013 at 1:57 PM, Andreas Jaeger wrote:

...

Better: source /etc/os-release if [ $NAME = "openSUSE" ] ; then... fi

Call me paranoid, but I wouldn't source files like that, that aren't part of my own package. And even then...

So, you're not trusting the distribution? ;)

You can source it from a shell which is a great advantage but you can do it differently if you prefer,

Well, it's not that. One would have to have root to inject stuff there. The issue is that of coupling. Sourcing it as a script, means a tiny otherwise inconsequential formatting error there would break all the scripts that source it, and for what, when grep can do just fine? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

...

...

...

...

Ruediger Meier writes:

On Thursday 08 August 2013, Claudio Freire wrote:

...

...

On 08/08/2013 07:10 PM, Claudio Freire wrote:

...

On Thu, Aug 8, 2013 at 1:57 PM, Andreas Jaeger wrote:

...

Better: >>> source /etc/os-release >>> if [ $NAME = "openSUSE" ] ;

...

...

Call me paranoid, but I wouldn't source files like that, that >> aren't

On Thu, Aug 8, 2013 at 3:34 PM, Andreas Jaeger wrote: then... >>> fi part of my own package. And even then...

...

So, you're not trusting the distribution? ;)

You can source it from a shell which is a great advantage but you > can

do it differently if you prefer,

Well, it's not that. One would have to have root to inject stuff there.

The issue is that of coupling. Sourcing it as a script, means a tiny otherwise inconsequential formatting error there would break all the scripts that source it, and for what, when grep can do just fine?

Of course it's bad that it could crash. Moreover you have to take care that the file may contain variables which you are using already in your script.

On the other hand your grep line would parse the file incorrectly. Most important, you should ignore comments,

BTW the man page is paradox http://www.freedesktop.org/software/systemd/man/os-release.html 1. "It is possible to source the configuration from shell scripts." 2. "...no shell features are supported ... variable expansion is __explicitly__ not supported"

So how would you source the file with disabled shell features? :)

paradox = systemd

cu, Rudi

-- Life is endless possibilities -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Fri, Aug 9, 2013 at 7:02 AM, Ruediger Meier wrote:

...

...

You can source it from a shell which is a great advantage but you can do it differently if you prefer,

Well, it's not that. One would have to have root to inject stuff there.

The issue is that of coupling. Sourcing it as a script, means a tiny otherwise inconsequential formatting error there would break all the scripts that source it, and for what, when grep can do just fine?

Of course it's bad that it could crash. Moreover you have to take care that the file may contain variables which you are using already in your script.

On the other hand your grep line would parse the file incorrectly. Most important, you should ignore comments,

Well, you could improve the regex to exclude comments. But if the intent is to detect openSUSE, why would any other distro include the string "openSUSE", in comments or not? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Fri, Aug 9, 2013 at 1:17 PM, Ruediger Meier wrote:

...

...

...

...

You can source it from a shell which is a great advantage but you can do it differently if you prefer,

Well, it's not that. One would have to have root to inject stuff there.

The issue is that of coupling. Sourcing it as a script, means a tiny otherwise inconsequential formatting error there would break all the scripts that source it, and for what, when grep can do just fine?

Of course it's bad that it could crash. Moreover you have to take care that the file may contain variables which you are using already in your script.

On the other hand your grep line would parse the file incorrectly. Most important, you should ignore comments,

Well, you could improve the regex to exclude comments. But if the intent is to detect openSUSE, why would any other distro include the string "openSUSE", in comments or not?

I can imagine many real life cases where this could happen. Maybe I (or you) would leave such comment on my own system after I've tried something out while working on those scripts we are talking about.

Or what about a comment like this # add this strange openSUSE var to let xyz work on Debian STRANGE_KEY="bla"

Anyway, a comment has to be ignored. No need to discuss about the sense of this comment. It's only made for the human reader. ;)

Yeah, sure. So add grep -e -v '^ *#' Or something like that. Even the possibility of parsing some comments would be more robust than sourcing the file, IMHO. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 08/08/2013 11:39 AM, Togan Muftuoglu wrote:

...

...

...

...

...

On Thu, 08 Aug 2013 10:51:43 +0200, Andreas Jaeger said:

Andreas> A couple of packages check for /etc/SuSE-release and I suggest to Andreas> deprecate it and use the new cross-distro location Andreas> /etc/SuSE-release instead.

Andreas> I've asked Coolo to addthe following line to the end of Andreas> /etc/SuSE-release now:

Andreas> # /etc/SuSE-release is deprecated and will be removed in the Andreas> future, use /etc/os-release instead

Andreas> I filed a few bugs against SUSE packages that check Andreas> /etc/SuSE-release to switch and suggest that you fix - and send Andreas> upstream - any checks for /etc/SuSE-release.

Yes but there is a tiny problem as I was told by shorewall upstream Debian 7 and Fedora 19 are also using /etc/os-release

So how do we distinguish that this is openSUSE

check the content of the file, not just existence of /etc/SuSE-release -> cat /etc/os-release NAME=openSUSE VERSION="12.3 (Dartmouth)" VERSION_ID="12.3" PRETTY_NAME="openSUSE 12.3 (Dartmouth) (x86_64)" ID=opensuse ANSI_COLOR="0;32" CPE_NAME="cpe:/o:opensuse:opensuse:12.3" That'll look different on Debian and Fedora ;) Later, Robert -- Robert Schweikert MAY THE SOURCE BE WITH YOU SUSE-IBM Software Integration Center LINUX Tech Lead rjschwei@suse.com rschweik@ca.ibm.com 781-464-8147 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org