On Wed, 2007-03-21 at 11:07 +0100, Michal Marek wrote:

Jules Colding wrote:

...

I've experimented with the neededforbuild macro instead of adding additional BuildRequires statements. This unfortunately makes 'build' complain about failed build dependencies.

You shouldn't use # neededforbuild anymore. The build script supports it only to be able to rebuild build packages from SUSE Linux <= 10.0, but then it disregards BuildRequires:.

OK, that explains my observations.

%if 0%{?suse_version} BuildRequires: ... %endif

What does 0%{?suse_version} do? Does it only evaluates to true if suse_version is defined or something like that??

is the way to go.

Thanks, jules --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

On 2007-03-21 14:34:56 +0100, Ladislav Michnovič wrote:

IMHO it should be %if %suse_version > 1000 BuildRequires: ... %else # neededforbuild ... %endif

why? your line will fail on fedora e.g., while michal's line works there aswell. and often the buildrequires works without a version specific part. and when using the buildservice it might even work on all distros. that said i would leave out all %if in first place. ;) darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

On Wed, Mar 21, 2007 at 02:54:57PM +0100, Ladislav Michnovi?? wrote:

2007/3/21, Marcus Rueckert :

...

that said i would leave out all %if in first place. ;) Yes right, it will break Fedora. But i think # needeforbuild is not used any more in OBS. Am I right?

Right, please always use BuildRequires. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Hi, On Thu, 22 Mar 2007, Stanislav Brabec wrote:

...

lsb Probably part of the base system.

Nope. This requirement seems a bit strange anyway, 'lsb' doesn't provide that many interesting services. We also are in the process of stripping down the base system somewhat, so even if it were in the base system right now, you should still list it. Ciao, Michael. --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org