[opensuse-packaging] New rpmlint checks for /etc/conf.d and systemd directories
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint. Also, I'm adding a check to rpmlint for the directories /etc/modules- load.d and /etc/tmpfiles.d since those should contain only user files, system wide configuration is in /usr/lib/modules-load.d and /usr/lib/tmpfiles.d. How shall we handle /etc/systemd ? Currently systemd installs some files into it - is it the only package doing so and thus should we add an rpmlintrc allowing it in systemd as an exception? Or any better ideas to handle it? Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 25.09.2012 15:02, Andreas Jaeger wrote:
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
I can create a staging project for you, so we can accept fixes for packages owning these: /sbin/conf.d/SuSEconfig.ghostscript-cjk /sbin/conf.d/SuSEconfig.glib2 /sbin/conf.d/SuSEconfig.isdn /sbin/conf.d/SuSEconfig.mailman /sbin/conf.d/SuSEconfig.permissions /sbin/conf.d/SuSEconfig.scim Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 09/25/2012 03:23 PM, Stephan Kulow wrote:
On 25.09.2012 15:02, Andreas Jaeger wrote:
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
I can create a staging project for you, so we can accept fixes for packages owning these:
/sbin/conf.d/SuSEconfig.ghostscript-cjk /sbin/conf.d/SuSEconfig.glib2 /sbin/conf.d/SuSEconfig.isdn /sbin/conf.d/SuSEconfig.mailman /sbin/conf.d/SuSEconfig.permissions /sbin/conf.d/SuSEconfig.scim
please do - any help is welcome, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Le mardi 25 septembre 2012 à 15:02 +0200, Andreas Jaeger a écrit :
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
Also, I'm adding a check to rpmlint for the directories /etc/modules- load.d and /etc/tmpfiles.d since those should contain only user files, system wide configuration is in /usr/lib/modules-load.d and /usr/lib/tmpfiles.d.
Sounds good. We might also want to deprecate /etc/tmpdirs.d which isn't used under systemd. We should also do the same for udev rules. No package should ship rules in /etc/udev/rules.d. I'm currently working on updating udev (along with systemd), which will uses /usr/lib/udev/rules.d (instead of /lib/udev/rules.d) and on the migration path. But since we are cleaning things, let's move udev rules too.
How shall we handle /etc/systemd ? Currently systemd installs some files into it - is it the only package doing so and thus should we add an rpmlintrc allowing it in systemd as an exception? Or any better ideas to handle it?
I agree only systemd package should write in /etc/systemd.
--
Frederic Crozat
On Tuesday, September 25, 2012 15:41:07 Frederic Crozat wrote:
Le mardi 25 septembre 2012 à 15:02 +0200, Andreas Jaeger a écrit :
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
Also, I'm adding a check to rpmlint for the directories /etc/modules- load.d and /etc/tmpfiles.d since those should contain only user files, system wide configuration is in /usr/lib/modules-load.d and /usr/lib/tmpfiles.d.
Sounds good. We might also want to deprecate /etc/tmpdirs.d which isn't used under systemd.
We should also do the same for udev rules. No package should ship rules in /etc/udev/rules.d. I'm currently working on updating udev (along with systemd), which will uses /usr/lib/udev/rules.d (instead of /lib/udev/rules.d) and on the migration path. But since we are cleaning things, let's move udev rules too.
Tell me once it's ready what needs blacklisting and I can patch it...
How shall we handle /etc/systemd ? Currently systemd installs some files into it - is it the only package doing so and thus should we add an rpmlintrc allowing it in systemd as an exception? Or any better ideas to handle it?
I agree only systemd package should write in /etc/systemd.
So, that means an rpmlintrc for systemd once the changes are in - ok, will submit this later, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Le mardi 25 septembre 2012 à 15:02 +0200, Andreas Jaeger a écrit :
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
Also, I'm adding a check to rpmlint for the directories /etc/modules- load.d and /etc/tmpfiles.d since those should contain only user files, system wide configuration is in /usr/lib/modules-load.d and /usr/lib/tmpfiles.d.
We should also forbid anything packaged in /var/run or /var/lock (since
it is a tmpfs, packages needed something there should use a tmpfiles.d
or use %ghost if they want to keep ownership in rpm database)
--
Frederic Crozat
El 25/09/12 12:29, Frederic Crozat escribió:
We should also forbid anything packaged in /var/run or /var/lock (since it is a tmpfs, packages needed something there should use a tmpfiles.d or use %ghost if they want to keep ownership in rpm database)
Yes, nothing allowed there, also allow /etc/sysconfig/foo but *only as %ghost..** so we track to which package those files belong to, nowdays only /var/adm/fillup-templates/* are allowed. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Tuesday, September 25, 2012 17:14:19 Cristian Rodríguez wrote:
El 25/09/12 12:29, Frederic Crozat escribió:
We should also forbid anything packaged in /var/run or /var/lock (since it is a tmpfs, packages needed something there should use a tmpfiles.d or use %ghost if they want to keep ownership in rpm database) Yes, nothing allowed there, also allow /etc/sysconfig/foo but *only as %ghost..** so we track to which package those files belong to, nowdays only /var/adm/fillup-templates/* are allowed.
This is already part of rpmlint, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Tuesday, September 25, 2012 17:29:25 Frederic Crozat wrote:
Le mardi 25 septembre 2012 à 15:02 +0200, Andreas Jaeger a écrit :
Since SuSEconfig is dead now, I'm blacklisting the whole directory /etc/conf.d in rpmlint.
Also, I'm adding a check to rpmlint for the directories /etc/modules- load.d and /etc/tmpfiles.d since those should contain only user files, system wide configuration is in /usr/lib/modules-load.d and /usr/lib/tmpfiles.d.
We should also forbid anything packaged in /var/run or /var/lock (since it is a tmpfs, packages needed something there should use a tmpfiles.d or use %ghost if they want to keep ownership in rpm database)
Ok, let's add those as warnings for now and change later to errors. I'll do the change, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wednesday 26 September 2012 10.12:06 Andreas Jaeger wrote:
/usr/lib/tmpfiles.d
Is there any macros for those destination files we can use on obs ? -- Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Ambassador GPG KEY : D5C9B751C4653227 irc: tigerfoot -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Le mardi 30 octobre 2012 à 20:48 +0100, Bruno Friedmann a écrit :
On Wednesday 26 September 2012 10.12:06 Andreas Jaeger wrote:
/usr/lib/tmpfiles.d
Is there any macros for those destination files we can use on obs ?
Not for this one (it won't change).
--
Frederic Crozat
On 10/31/2012 04:42 AM, Frederic Crozat wrote:
Le mardi 30 octobre 2012 à 20:48 +0100, Bruno Friedmann a écrit :
On Wednesday 26 September 2012 10.12:06 Andreas Jaeger wrote:
/usr/lib/tmpfiles.d
Is there any macros for those destination files we can use on obs ?
Not for this one (it won't change).
Famous last words ;)
-- Robert Schweikert MAY THE SOURCE BE WITH YOU SUSE-IBM Software Integration Center LINUX Tech Lead rjschwei@suse.com rschweik@ca.ibm.com 781-464-8147 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (6)
-
Andreas Jaeger -
Bruno Friedmann -
Cristian Rodríguez -
Frederic Crozat -
Robert Schweikert -
Stephan Kulow