[opensuse-packaging] file list check enabled again

Stephan Kulow

10 Nov 2010 10 Nov '10

12:40

Hi, Ludwig re-enabled the check if a package owns all its directories and we found quite a number of packages failing because of this (the check was disabled between may and november, we used to have it before). I collected the affected packages in my branch project, so you can check out https://build.opensuse.org/project/monitor?project=home%3Acoolo%3Abranches%3... The check is currently re-disabled in factory, but creates a warning that the check is re-re-enabled on december 8th, so please help out. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Show replies by date

Cristian Morales Vega

18 Dec 18 Dec

17:17

2010/11/10 Stephan Kulow :

...

Ludwig re-enabled the check if a package owns all its directories and we found quite a number of packages failing because of this (the check was disabled between may and november, we used to have it before).

...

From https://build.opensuse.org/package/live_build_log?arch=x86_64&package=nimuh&project=home%3ARedDwarf%3ANonFree&repository=openSUSE_Factory_NonFree

... checking filelist nimuh-1.02-4.1.x86_64.rpm: directories not owned by a package: - /usr/share/icons/hicolor - /usr/share/icons/hicolor/64x64 - /usr/share/icons/hicolor/64x64/apps But the spec file includes a "Requires: hicolor-icon-theme". Is this expected? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

19:43

On 2010-12-18 18:17:55 +0100, Cristian Morales Vega wrote:

...

... checking filelist nimuh-1.02-4.1.x86_64.rpm: directories not owned by a package: - /usr/share/icons/hicolor - /usr/share/icons/hicolor/64x64 - /usr/share/icons/hicolor/64x64/apps

But the spec file includes a "Requires: hicolor-icon-theme". Is this expected?

BuildRequires: hicolor-icon-theme darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

20:07

2010/12/18 Marcus Rueckert :

...

On 2010-12-18 18:17:55 +0100, Cristian Morales Vega wrote:

...
... checking filelist nimuh-1.02-4.1.x86_64.rpm: directories not owned by a package: - /usr/share/icons/hicolor - /usr/share/icons/hicolor/64x64 - /usr/share/icons/hicolor/64x64/apps

But the spec file includes a "Requires: hicolor-icon-theme". Is this expected?

BuildRequires: hicolor-icon-theme

I know. But that doesn't seems to make any sense. The idea of the check should be to make sure every file/dir has an owner in the user's machine, not in the build machine. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Dave Plater

20:27

On 12/18/2010 10:07 PM, Cristian Morales Vega wrote:

...

2010/12/18 Marcus Rueckert :

...
On 2010-12-18 18:17:55 +0100, Cristian Morales Vega wrote:

...
... checking filelist nimuh-1.02-4.1.x86_64.rpm: directories not owned by a package: - /usr/share/icons/hicolor - /usr/share/icons/hicolor/64x64 - /usr/share/icons/hicolor/64x64/apps

But the spec file includes a "Requires: hicolor-icon-theme". Is this expected?

BuildRequires: hicolor-icon-theme

I know. But that doesn't seems to make any sense. The idea of the check should be to make sure every file/dir has an owner in the user's machine, not in the build machine.

You can put a %dir in the file list of the package / sub package that owns them but first check that they aren't empty. regards Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

20:51

On 2010-12-18 21:07:49 +0100, Cristian Morales Vega wrote:

...

2010/12/18 Marcus Rueckert :

...
On 2010-12-18 18:17:55 +0100, Cristian Morales Vega wrote:

...
... checking filelist nimuh-1.02-4.1.x86_64.rpm: directories not owned by a package: - /usr/share/icons/hicolor - /usr/share/icons/hicolor/64x64 - /usr/share/icons/hicolor/64x64/apps

But the spec file includes a "Requires: hicolor-icon-theme". Is this expected?

BuildRequires: hicolor-icon-theme

I know. But that doesn't seems to make any sense. The idea of the check should be to make sure every file/dir has an owner in the user's machine, not in the build machine.

without the package present in the build chroot, how should the check know which package owns what directory? especially with all the combinations of repositories. the buildrequires makes a lot of sense. darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

21:00

2010/12/18 Marcus Rueckert :

...

the buildrequires makes a lot of sense.

Exactly what problem is solved by adding that buildrequire? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

21:34

On 2010-12-18 22:00:50 +0100, Cristian Morales Vega wrote:

...

2010/12/18 Marcus Rueckert :

...
the buildrequires makes a lot of sense.

Exactly what problem is solved by adding that buildrequire?

there is one package in the buildchroot that owns those directories? darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

19 Dec 19 Dec

10:14

2010/12/18 Marcus Rueckert :

...

On 2010-12-18 22:00:50 +0100, Cristian Morales Vega wrote:

...
2010/12/18 Marcus Rueckert :

...
the buildrequires makes a lot of sense.

Exactly what problem is solved by adding that buildrequire?

there is one package in the buildchroot that owns those directories?

That IMHO is a no-problem. Nobody is going to check the ownership in the buildchroot... Anyway, after looking at the check it seems OK and I don't see a way to improve it without causing other problems. "Requires" packages could be also checked, but there is no warranty they will be available in the OBS. Personally I would put hicolor-icon-theme inside the filesystem package, but I just remembered I already asked for that and was rejected. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

16:33

On 2010-12-19 11:14:54 +0100, Cristian Morales Vega wrote:

...

2010/12/18 Marcus Rueckert :

...
On 2010-12-18 22:00:50 +0100, Cristian Morales Vega wrote:

...
2010/12/18 Marcus Rueckert :

...
the buildrequires makes a lot of sense.

Exactly what problem is solved by adding that buildrequire?

there is one package in the buildchroot that owns those directories?

That IMHO is a no-problem. Nobody is going to check the ownership in the buildchroot...

where else do you want to do the check? how do you tell the packager "you forgot to own some directories"?

...

Anyway, after looking at the check it seems OK and I don't see a way to improve it without causing other problems. "Requires" packages could be also checked, but there is no warranty they will be available in the OBS.

it pulls in prerequired packages for the install test. but thas about it.

...

Personally I would put hicolor-icon-theme inside the filesystem package, but I just remembered I already asked for that and was rejected.

because a server e.g. doesnt need those directories. why is it so cumbersome for you do add the buildrequires on the high-color-icon theme? darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

16:52

2010/12/19 Marcus Rueckert :

...

because a server e.g. doesnt need those directories. why is it so cumbersome for you do add the buildrequires on the high-color-icon theme?

My only problem is, in this specific case, the check is forcing me to add a BuildRequires that doesn't fix any real problem in user's machines. And it isn't forcing me to add a Requires that would solve a real problem in user's machines. But since I don't know how to improve it... -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Ralf Lang

20 Dec 20 Dec

10:53

Am Sonntag 19 Dezember 2010, 17:52:36 schrieb Cristian Morales Vega:

...

2010/12/19 Marcus Rueckert :

...
because a server e.g. doesnt need those directories. why is it so cumbersome for you do add the buildrequires on the high-color-icon theme?

My only problem is, in this specific case, the check is forcing me to add a BuildRequires that doesn't fix any real problem in user's machines. And it isn't forcing me to add a Requires that would solve a real problem in user's machines. But since I don't know how to improve it...

This check doesn't work as expected on horde modules - they all have to "own" horde dir although they live below horde dir and have a requirement on the package horde3 which already owns that dir -- Ralf Lang Linux Consultant / Developer B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

12:10

On 2010-12-20 11:53:17 +0100, Ralf Lang wrote:

...

Am Sonntag 19 Dezember 2010, 17:52:36 schrieb Cristian Morales Vega:

...
2010/12/19 Marcus Rueckert :

...
because a server e.g. doesnt need those directories. why is it so cumbersome for you do add the buildrequires on the high-color-icon theme?

My only problem is, in this specific case, the check is forcing me to add a BuildRequires that doesn't fix any real problem in user's machines. And it isn't forcing me to add a Requires that would solve a real problem in user's machines. But since I don't know how to improve it...

This check doesn't work as expected on horde modules - they all have to "own" horde dir although they live below horde dir and have a requirement on the package horde3 which already owns that dir

do they also *buildrequire* the horde3 package? darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Ralf Lang

14:58

Am Montag 20 Dezember 2010, 13:10:23 schrieb Marcus Rueckert:

...

...
This check doesn't work as expected on horde modules - they all have to "own" horde dir although they live below horde dir and have a requirement on the package horde3 which already owns that dir

do they also *buildrequire* the horde3 package?

darix

Got me! It doesn't buildrequire horde3 (which creates some other dependency mess which I'm going to cleanup). Thanks. -- Ralf Lang Linux Consultant / Developer B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Marcus Rueckert

15:24

On 2010-12-20 15:58:48 +0100, Ralf Lang wrote:

...

Am Montag 20 Dezember 2010, 13:10:23 schrieb Marcus Rueckert:

...
...
This check doesn't work as expected on horde modules - they all have to "own" horde dir although they live below horde dir and have a requirement on the package horde3 which already owns that dir

do they also *buildrequire* the horde3 package?

darix

Got me! It doesn't buildrequire horde3 (which creates some other dependency mess which I'm going to cleanup).

if it leads to dependency loops, multiple directories can own the same directory. just add %dir entries for the directories. darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

4884

Age (days ago)

4924

Last active (days ago)

List overview

Download

14 comments

5 participants

participants (5)

Cristian Morales Vega
Dave Plater
Marcus Rueckert
Ralf Lang
Stephan Kulow