[opensuse-packaging] default for %clean phase
Hi all! RPM upstream recently added the following patch[1] which creates a default behaviour for %clean phase. When its definition is omitted in the spec file, the buildroot removal is done. One can still override this by specifying other commands in the %clean phase (but I haven't seen any package which does something else than "rm -rf %{buildroot}). What do you think about the change? (We would still need to use the old way for compatibility with older distros, but sooner we get this into openSUSE, the sooner it will phase out ...). [1] http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=3fc58248d23d6f720942e5cbf4f92... -- Best Regards / S pozdravom, Pavol RUSNAK SUSE LINUX, s.r.o openSUSE Community Multiplier Team Lihovarska 1060/12 PGP 0xA6917144 19000 Praha 9, CR prusnak[at]suse.cz http://www.suse.cz -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Sep 3, 2009 at 10:19 AM, Pavol Rusnak
Hi all!
RPM upstream recently added the following patch[1] which creates a default behaviour for %clean phase. When its definition is omitted in the spec file, the buildroot removal is done. One can still override this by specifying other commands in the %clean phase (but I haven't seen any package which does something else than "rm -rf %{buildroot}). What do you think about the change? (We would still need to use the old way for compatibility with older distros, but sooner we get this into openSUSE, the sooner it will phase out ...).
It will remove two lines from spec file and make easier to read. Once this is available to use, definitly should be done. Regards. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Le jeudi 03 septembre 2009, à 15:19 +0200, Pavol Rusnak a écrit :
Hi all!
RPM upstream recently added the following patch[1] which creates a default behaviour for %clean phase. When its definition is omitted in the spec file, the buildroot removal is done. One can still override this by specifying other commands in the %clean phase (but I haven't seen any package which does something else than "rm -rf %{buildroot}). What do you think about the change? (We would still need to use the old way for compatibility with older distros, but sooner we get this into openSUSE, the sooner it will phase out ...).
I love it! Agree that we should get this in ASAP, if it doesn't break anything. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thursday 03 September 2009 15:44:05 Vincent Untz wrote:
I love it! Agree that we should get this in ASAP, if it doesn't break anything.
So do I - I suggest that somebody adds this patch to our rpm package, Andreas -- Andreas Jaeger, aj@{novell.com,opensuse.org} Twitter: jaegerandi | Identica: jaegerandi SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Andreas Jaeger wrote:
On Thursday 03 September 2009 15:44:05 Vincent Untz wrote:
I love it! Agree that we should get this in ASAP, if it doesn't break anything.
So do I - I suggest that somebody adds this patch to our rpm package,
I already talked with mls prior writing to this mailing list. We just wanted to be sure that we are doing the right thing(tm). -- Best Regards / S pozdravom, Pavol RUSNAK SUSE LINUX, s.r.o openSUSE Community Multiplier Team Lihovarska 1060/12 PGP 0xA6917144 19000 Praha 9, CR prusnak[at]suse.cz http://www.suse.cz -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 03/09/09 09:44, Vincent Untz wrote:
I love it! Agree that we should get this in ASAP, if it doesn't break anything.
Yes!, I wondered a few times why RPM was not doing just that by default. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Sep 3, 2009 at 10:26 AM, Cristian Rodríguez
On 03/09/09 09:44, Vincent Untz wrote:
I love it! Agree that we should get this in ASAP, if it doesn't break anything.
Yes!, I wondered a few times why RPM was not doing just that by default. --
You mean less stuff that could break? Fewer lines in an already busy spec file? Smaller chance at having typos? What else can we get rid of ;) definitely for this. Stephen -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (6)
-
aledr -
Andreas Jaeger -
Cristian Rodríguez -
Pavol Rusnak -
Stephen Shaw -
Vincent Untz