On Wed, Nov 10, 2010 at 8:17 AM, Cristian Rodríguez wrote:

El 10/11/10 13:11, Greg Freemyer escribió:

...

I just ran spec-cleaner on a minor/simple leaf package I maintain.

It did some nice cleanups.

One thing it didn't do and I don't know how to do is handle a mysqlclient problem I have with 64-bit Fedora

My home package:  home:gregfreemyer:Weather > open2300    now has the spec-cleaner cleaned spec file

But I still get an error related 64-bit Fedora

/lib/mysql -lmysqlclient /usr/bin/ld: cannot find -lmysqlclient

Do you buildrequire mysql-devel ?

Yes The specfile works on opensuse (all flavors), Mandriva (all flavors) and Fedora 32-bit, but not Fedora 64-bit. It's been that way since I first packaged this project 18-months ago, but it's bugging me again. I've only created a few specfiles, but this one looks pretty clean to me, and spec-cleaner made it even nicer. https://build.opensuse.org/package/view_file?file=open2300.spec&package=open2300&project=home%3Agregfreemyer%3AWeather Greg -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

On Wed, Nov 10, 2010 at 12:19 PM, Cristian Rodríguez wrote:

El 10/11/10 13:40, Greg Freemyer escribió:

...

On Wed, Nov 10, 2010 at 8:17 AM, Cristian Rodríguez wrote:

...

El 10/11/10 13:11, Greg Freemyer escribió:

...

I just ran spec-cleaner on a minor/simple leaf package I maintain.

It did some nice cleanups.

One thing it didn't do and I don't know how to do is handle a mysqlclient problem I have with 64-bit Fedora

My home package:  home:gregfreemyer:Weather > open2300    now has the spec-cleaner cleaned spec file

But I still get an error related 64-bit Fedora

/lib/mysql -lmysqlclient /usr/bin/ld: cannot find -lmysqlclient

Do you buildrequire mysql-devel ?

Yes

The specfile works on opensuse (all flavors), Mandriva (all flavors) and Fedora 32-bit, but not Fedora 64-bit.

try the following hack in the spec

sed -i -e s@/usr/lib/mysql@%{_libdir}/mysql@g Makefile

(before running make of course)

Seems to have done the trick. It's clearly a hack, but is it one I can leave in and still push the package to devel / factory? It really only impacts 64-bit fedora. Right now I have the hack in the %build area, but it I put it up in the %prep area it seems as good as any other patch to me. Greg -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

On 10/11/10 20:44, Greg Freemyer wrote:

It's clearly a hack, but is it one I can leave in and still push the package to devel / factory? It really only impacts 64-bit fedora.

if you put this hack in %if 0%{?fedora_version} ... %endif block and probably add a nice description in comment, then no one will object :-) -- Best Regards / S pozdravom, Pavol RUSNAK SUSE LINUX, s.r.o openSUSE Boosters Team Lihovarska 1060/12 PGP 0xA6917144 19000 Praha 9 prusnak[at]opensuse.org Czech Republic -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Am Mittwoch, 10. November 2010, 21:49:05 schrieb Greg Freemyer:

On Wed, Nov 10, 2010 at 3:05 PM, Pavol Rusnak wrote:

...

On 10/11/10 20:44, Greg Freemyer wrote:

...

It's clearly a hack, but is it one I can leave in and still push the package to devel / factory? It really only impacts 64-bit fedora.

if you put this hack in

%if 0%{?fedora_version} ... %endif

block and probably add a nice description in comment, then no one will object :-)

Thanks all,

I've pushed the change to the devel project I SR'ed a couple days ago.

I will SR the whole thing to factory at some point. (I'm waiting on a end-user patch headed my way that actually effects the code!)

fyi: since I became the maintainer of the package in devel (hardware/open2300), I can just accept SRs without bothering anyone. Will the same be true once it hits factory?

No, factory submissions are always reviewed by a second pair of eyes. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org