On Friday 08 July 2011 15:08:35 Dominique Leuenberger a.k.a DimStar wrote:

Quoting Sascha Peilicke :

...

Hi all,

just to notify you all, since quite some time you neither need to specify a clean section nor a BuildRoot in your spec files. Official rpm.org rpm (present in openSUSE) has reasonable defaults.

It happened recently that I already let a (games) package into Factory which had no %clean setion. Whilst this was an accident, the question is on how we want to handle this in the future.

Shame on you!

...

You should be aware that this is not support on any SLE*. Generally, we wouldn't care for Factory but if you want to build for SLE, you may want to keep it. I was told that the games guys already started to convert their spec files. So we need a decision.

I would argue not to do it! A big feature of OBS is the fact that we can use one .spec file for multiple targets. Of course this does not work with every .spec file we now have, but at least those banalities I would really hate having to fix in every branched package I/sombody creates for any other RPM based system. I share that opinion, it's just to be aware of the issue. So, if nobody disagrees, Factory reviewers won't (hopefully) let it slip thru again ;-)

The sections are simple enough and well understood I hope. -- Mit freundlichen Grüßen, Sascha Peilicke

On 07/08/2011 03:38 PM, Jan Engelhardt wrote:

On Friday 2011-07-08 14:51, Sascha Peilicke wrote:

...

just to notify you all, since quite some time you neither need to specify a clean section nor a BuildRoot in your spec files. Official rpm.org rpm (present in openSUSE) has reasonable defaults.

You should be aware that this is not support on any SLE*.

RPM requires only a few fields and sections to be present at all - %clean is not one of them. SLE does not change that.

Yes, the absence of %clean in SLE<= 11 causes %buildroot to be not removed, but only when using plain rpmbuild outside of a tracking, sanitizing environment (chroot, xen, etc.) such as provided by osc's localbuild or bs_worker. Utilizing rpmbuild directly itself however is something that has been disrecommended since at least bnc#176528 comment#4 because, as you can see, it leads to way more spurious build errors.

I agree, %clean is the most redundant part of a spec file, if I could find a way I'd like to remove manual ldconfig calls too even. Regards. -- Ismail Dönmez - openSUSE Booster SUSE LINUX Products GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org