Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 2adb3fb2e9f253146fc48dea9820f1234736b244
https://github.com/openSUSE/open-build-service/commit/2adb3fb2e9f253146fc48d...
Author: Eduardo Navarro
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M src/api/spec/controllers/trigger_controller_spec.rb
Log Message:
-----------
Use instance_double instead of the use discouraged ...
allow_any_instance_of
Commit: bdb65ff830dd5c156aafe9e052fd274ae0e863cd
https://github.com/openSUSE/open-build-service/commit/bdb65ff830dd5c156aafe9...
Author: Eduardo Navarro
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M src/api/spec/controllers/trigger_controller_spec.rb
Log Message:
-----------
Remove unneeded call to package
Commit: 39fed1a4d525e54bfb52e4e713ce4379ceec1f16
https://github.com/openSUSE/open-build-service/commit/39fed1a4d525e54bfb52e4...
Author: Eduardo Navarro
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M src/api/spec/controllers/trigger_controller_spec.rb
Log Message:
-----------
Substitute let! with let
There is no need to force the method’s invocation before each example.
Commit: ac6d8b6f8bc45e4a44b6459c3618be42ace2db7a
https://github.com/openSUSE/open-build-service/commit/ac6d8b6f8bc45e4a44b645...
Author: Eduardo Navarro
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M src/api/spec/cassettes/TriggerController/_create/when_some_parameters_are_not_strings/still_processes_the_request_without_validating_parameters.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_3_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_2_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_1_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
R src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_1_3_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_1_3_1_2.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_1_2_1.yml
R src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_2_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml
R src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_3_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_2_6_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_2_6_1_2.yml
A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_3_5_1.yml
M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_3_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_3_3_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_2.yml
M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml
R src/api/spec/cassettes/TriggerController/_runservice/1_4_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_3_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_3_2_1_2.yml
Log Message:
-----------
Regenerate cassettes for Trigger Controller specs
Commit: e1d25a8abe8124ce8f3fd97b30cdbb21068fa6b9
https://github.com/openSUSE/open-build-service/commit/e1d25a8abe8124ce8f3fd9...
Author: Dani Donisa
Date: 2023-10-31 (Tue, 31 Oct 2023)
Changed paths:
M src/api/spec/cassettes/TriggerController/_create/when_some_parameters_are_not_strings/still_processes_the_request_without_validating_parameters.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_3_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_2_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml
R src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_1_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
R src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_1_3_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_1_3_1_2.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_1_2_1.yml
R src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_2_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml
R src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_3_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_2_6_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_2_6_1_2.yml
A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_3_5_1.yml
M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_3_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_3_3_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_2.yml
M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml
R src/api/spec/cassettes/TriggerController/_runservice/1_4_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_3_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/when_the_token_is_not_bound_to_a_package/without_a_package_passed_in_the_parameters/1_3_2_1_2.yml
M src/api/spec/controllers/trigger_controller_spec.rb
Log Message:
-----------
Merge pull request #15138 from eduardoj/refactoring/trigger_controller_specs
Refactor trigger controller specs
Compare: https://github.com/openSUSE/open-build-service/compare/f3e05cc57673...e1d25a...
Dani Donisa