Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 821704819cd33474b85526a79d9b54c1a446f62d https://github.com/openSUSE/open-build-service/commit/821704819cd33474b85526... Author: Lukas Krause Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M src/api/app/components/add_review_dropdown_component.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/policies/bs_request_policy.rb M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/request/beta_show_tabs/_ask_for_review.html.haml M src/api/app/views/webui/request/beta_show_tabs/_conversation_aside.html.haml Log Message: ----------- Move `can_add_reviews` logic to a pundit policy and use in request beta views This code is for authorization and therefore should be in a pundit policy. Commit: 83ce554094b12cbb3adafc8daaf567b4b939a017 https://github.com/openSUSE/open-build-service/commit/83ce554094b12cbb3adafc... Author: Lukas Krause Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A src/api/spec/policies/bs_request_policy_spec.rb Log Message: ----------- Create specs for `can_add_reviews?` pundit policy Commit: 332eceb2a8d19ae9d476b0b4de76ff84896d61a0 https://github.com/openSUSE/open-build-service/commit/332eceb2a8d19ae9d476b0... Author: Henne Vogelsang Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M src/api/app/components/add_review_dropdown_component.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/policies/bs_request_policy.rb M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/request/beta_show_tabs/_ask_for_review.html.haml M src/api/app/views/webui/request/beta_show_tabs/_conversation_aside.html.haml A src/api/spec/policies/bs_request_policy_spec.rb Log Message: ----------- Merge pull request #14335 from krauselukas/create_can_add_reviews_policy Create `can_add_reviews?` pundit policy and use in request beta views Compare: https://github.com/openSUSE/open-build-service/compare/7512bdf97736...332ece...