Branch: refs/heads/patchinfo_controller Home: https://github.com/openSUSE/open-build-service Commit: fa16da049b1f85791ab3f8d065e4d4381f2d8185 https://github.com/openSUSE/open-build-service/commit/fa16da049b1f85791ab3f8... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup condition a bit Commit: 7299aa1dc4f3ccebbc3e5bf2a958311a957e4364 https://github.com/openSUSE/open-build-service/commit/7299aa1dc4f3ccebbc3e5b... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup setting of issues in read_patchinfo action Commit: a232ebd78d7f3fe05d6ed68561d6546fab03ced8 https://github.com/openSUSE/open-build-service/commit/a232ebd78d7f3fe05d6ed6... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup setting of issues in read_patchinfo action, part II The params hash isn't used afterwards and thus doesn't need to be written. The :issueid was added twice to @issues, when params[:issue] was nil. Commit: 2ff7e808b4fbc1928c05f6d6af11e355681160ee https://github.com/openSUSE/open-build-service/commit/2ff7e808b4fbc1928c05f6... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Remove duplicated code Commit: 2387dedc1e5bf2d72ffa8cc6b58cb06152071431 https://github.com/openSUSE/open-build-service/commit/2387dedc1e5bf2d72ffa8c... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup setting of variables in patchinfo controller Commit: f0e720ff575c8f81a5648b0103e46e92455eb93a https://github.com/openSUSE/open-build-service/commit/f0e720ff575c8f81a5648b... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup setting of flash error message Commit: ca2a4e8b11d21c8df565ed733345beb12e5bd758 https://github.com/openSUSE/open-build-service/commit/ca2a4e8b11d21c8df565ed... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup collecting of issues Commit: de5c9cba975e9d1e9eb8617bac420d5f4a785901 https://github.com/openSUSE/open-build-service/commit/de5c9cba975e9d1e9eb861... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup read_patchinfo action Commit: 1053850800b66a5253ee23c89b95a8446e34c187 https://github.com/openSUSE/open-build-service/commit/1053850800b66a5253ee23... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Simplify creation of regex in get_issue_sum action Commit: 3c95d83cf80e7012a7e1d48f2826400331ca41d3 https://github.com/openSUSE/open-build-service/commit/3c95d83cf80e7012a7e1d4... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Remove instance variables from get_issue_sum helper method - Document return values of get_issue_sum - Remove usage of instance variables Commit: 8f820d0302107592f529442821511498101a542e https://github.com/openSUSE/open-build-service/commit/8f820d0302107592f52944... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Re-use path variable Commit: c41bea51a03527baeb12206e16309280c09f3af3 https://github.com/openSUSE/open-build-service/commit/c41bea51a03527baeb1220... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Directly use parameters Adding parameters into variables that are only used once is kinda pointless. Let's change this. Commit: ff3633ac74f23e6bf843f84ad6958d5e3198874e https://github.com/openSUSE/open-build-service/commit/ff3633ac74f23e6bf843f8... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Simplify iteration Commit: ac7be3ee0501b708dba33f33a0b748e9c7de608c https://github.com/openSUSE/open-build-service/commit/ac7be3ee0501b708dba33f... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Simplify iteration, part II Commit: 2a87cabc305f8ac8fe852cc0790862bfc1fea844 https://github.com/openSUSE/open-build-service/commit/2a87cabc305f8ac8fe852c... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/models/patchinfo.rb Log Message: ----------- [api] Define default value vie method parameter Commit: 711b1321a96eb2c16ad02e8357a809c52853715c https://github.com/openSUSE/open-build-service/commit/711b1321a96eb2c16ad02e... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Add comment to save action Commit: 8c8fda4a677f89e2d9988a8ed23c0de6325c1033 https://github.com/openSUSE/open-build-service/commit/8c8fda4a677f89e2d9988a... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Replace valid_params var by checking for flash[:error] Commit: b0f5f322ec3659df4d1df75c9760a28edd434574 https://github.com/openSUSE/open-build-service/commit/b0f5f322ec3659df4d1df7... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Skip adding unneeded binaries instead of deleting them afterwards Commit: 1c0015e267021eedb9b5b419282a45a89d962492 https://github.com/openSUSE/open-build-service/commit/1c0015e267021eedb9b5b4... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Cleanup get_binaries Commit: b4c7d009fc16f328588ce9c7e7db0b3c154bfdec https://github.com/openSUSE/open-build-service/commit/b4c7d009fc16f328588ce9... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Update formatting and remove unnecessary variable Commit: d53501706e0c3c44782ba4e3d601122ccc4f4648 https://github.com/openSUSE/open-build-service/commit/d53501706e0c3c44782ba4... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Remove another variable Commit: 81ec166f8268b048dee9e601d4fa7f4516c75a4e https://github.com/openSUSE/open-build-service/commit/81ec166f8268b048dee9e6... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Refactor patchinfo validation methods Commit: 40d2393c0561505eb80e2d2f37a67ca96ed438d8 https://github.com/openSUSE/open-build-service/commit/40d2393c0561505eb80e2d... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Refactor collecting issues Commit: cb1df0a094c55124ccde09eeb2390c0f9843b803 https://github.com/openSUSE/open-build-service/commit/cb1df0a094c55124ccde09... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Update foramtting of conditions Commit: 7e7b6f0dfe41ace6c65aea2d4ba0bb9d59f4b39b https://github.com/openSUSE/open-build-service/commit/7e7b6f0dfe41ace6c65aea... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Small cleanup Commit: 23cc3c13676862e2db5ee9c2da62a66eb698bd76 https://github.com/openSUSE/open-build-service/commit/23cc3c13676862e2db5ee9... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Store issueurl directly in issuesum Commit: eb452d0def2413c5c9687d70f9d6324a7383ea5b https://github.com/openSUSE/open-build-service/commit/eb452d0def2413c5c9687d... Author: Björn Geuken Date: 2015-07-27 (Mon, 27 Jul 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Only collect issues when needed Compare: https://github.com/openSUSE/open-build-service/compare/fa16da049b1f^...eb452d0def24