Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: d2d3e872f2f146e63268c363968c609b4b6e57d4
https://github.com/openSUSE/open-build-service/commit/d2d3e872f2f146e63268c3...
Author: Henne Vogelsang
Date: 2023-09-26 (Tue, 26 Sep 2023)
Changed paths:
M src/api/app/controllers/webui/webui_controller.rb
M src/api/spec/controllers/webui/webui_controller_spec.rb
Log Message:
-----------
Simplify require_package
There is no need to
- tell people *why* they are not allowed to access a package
- handle other exceptions in a before filter, we have a Webui::RescueHandler
Commit: 1b419028022007c7f0c6e24f18b5b0e13ee9c2c4
https://github.com/openSUSE/open-build-service/commit/1b419028022007c7f0c6e2...
Author: Henne Vogelsang
Date: 2023-09-26 (Tue, 26 Sep 2023)
Changed paths:
M src/api/app/controllers/webui/attribute_controller.rb
M src/api/app/controllers/webui/packages/main_controller.rb
M src/api/app/controllers/webui/patchinfo_controller.rb
M src/api/app/controllers/webui/repositories_controller.rb
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/controllers/webui/requests/deletions_controller.rb
M src/api/app/controllers/webui/requests/role_additions_controller.rb
M src/api/app/controllers/webui/requests/submissions_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
Log Message:
-----------
Unify the way we set @package in the webui
Use one before filter (require_package) and not many different ones.
Commit: ab057a183d98c1b2a4c2a6a27acfe5e8f6a77c2c
https://github.com/openSUSE/open-build-service/commit/ab057a183d98c1b2a4c2a6...
Author: Henne Vogelsang
Date: 2023-09-26 (Tue, 26 Sep 2023)
Changed paths:
M src/api/app/controllers/webui/patchinfo_controller.rb
M src/api/spec/controllers/webui/attribute_controller_spec.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb
Log Message:
-----------
Adopt specs to require_package in all controllers
Commit: 4a7754e13a0fb28039ab6b547efab766976b158a
https://github.com/openSUSE/open-build-service/commit/4a7754e13a0fb28039ab6b...
Author: Henne Vogelsang
Date: 2023-09-26 (Tue, 26 Sep 2023)
Changed paths:
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/calls_delete_file_method.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_no_permissions/1_5_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_no_permissions/1_5_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_not_successful_backend_call/1_5_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_4.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_NOT_authorized_to_edit_the_package/1_16_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/1_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/1_2_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/sends_the_xml_representation_of_a_package.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_an_empty_revision_is_provided/1_9_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_an_empty_revision_is_provided/1_9_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_no_difference_in_sources_diff_is_empty/1_9_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/for_ASCII_files/shows_the_truncated_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/for_archives/shows_the_truncated_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/shows_a_hint.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/does_not_show_a_hint.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/for_ASCII_files/shows_the_complete_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/for_archives/shows_the_complete_diff.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_package.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_project.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_without_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/returns_revisions_with_the_default_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_up_to_rev_parameter_s_value_without_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/returns_revisions_up_to_rev_parameter_s_value_with_the_default_pagination.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_no_rpmlint_log_is_available/1_14_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_no_rpmlint_log_is_available/1_14_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_there_is_a_rpmlint_log/1_14_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_there_is_a_rpmlint_log/1_14_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/require_package_before_action/with_an_invalid_package/1_4_1_1_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_3_1_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_3_1_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_5_1_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_5_1_2.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_3_2_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_3_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_5_2_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_5_2_2.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_2_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_3_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_3_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_without_sourceaccess/1_4_4_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_without_sourceaccess/1_4_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_valid_package/assigns_package.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_does_not_return_statistics/1_12_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_raises_an_exception/1_12_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_returns_statistics/1_12_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_returns_statistics/1_12_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_3.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_4.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_fails/1_11_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_fails/lets_the_user_know_there_was_an_error.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_succeeds/1_11_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_succeeds/1_11_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/Package_save_failed/1_15_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/Package_save_failed/1_15_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/invalid_package_name/1_15_2_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/invalid_package_name/1_15_2_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/not_allowed_to_create_package_in/1_15_2_5_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/not_allowed_to_create_package_in/1_15_2_5_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/package_already_exist/1_15_2_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/package_already_exist/1_15_2_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_with_source_protection_enabled/1_15_2_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_with_source_protection_enabled/1_15_2_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/1_3_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/1_3_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/deletes_the_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package_with_dependencies/does_not_delete_the_package_and_shows_an_error_message.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package_with_dependencies/forcing_the_deletion/deletes_the_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/authentication/allows_admins_to_delete_other_user_s_packages.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/authentication/does_not_allow_other_users_than_the_owner_to_delete_a_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/invalid_data/1_1_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/invalid_data/1_1_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_4.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_6_1.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_6_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_7_1.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_7_2.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_7_1.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_7_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_8_1.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_8_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_package_name/1_8_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_package_name/1_8_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_project_name/1_8_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_project_name/1_8_4_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_unexistent_package/1_8_6_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_invalid_XML/1_8_5_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_invalid_XML/1_8_5_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_proper_params/1_8_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_proper_params/1_8_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/without_admin_rights_to_raise_protection_level/1_8_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/without_admin_rights_to_raise_protection_level/1_8_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/1_10_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/1_10_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/lets_the_user_know_there_was_an_error.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/redirects_to_the_package_binaries_path.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_succeeds/1_10_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_succeeds/1_10_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_with_maintainer_of_package/1_10_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_1.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_2.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_3.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_4.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_5.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_6.yml
M src/api/spec/cassettes/Webui_PackageController/when_the_user_is_NOT_authorized_to_change_the_package/1_18_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_packages_without_a_build_reason/1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_packages_without_a_build_reason/redirects_to_package_binaries_path.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_valid_requests/has_build_reason.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_valid_requests/responds_with_200_OK.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_architecture/1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_architecture/redirects_to_package_binaries_path.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_respository/1_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_respository/1_1_1_2.yml
Log Message:
-----------
Adopt cassettes to require_package in controllers
Commit: 68dbc96c9c51b9cf94eae34c480eaad2204c4538
https://github.com/openSUSE/open-build-service/commit/68dbc96c9c51b9cf94eae3...
Author: Henne Vogelsang
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M src/api/app/controllers/webui/attribute_controller.rb
M src/api/app/controllers/webui/packages/main_controller.rb
M src/api/app/controllers/webui/patchinfo_controller.rb
M src/api/app/controllers/webui/repositories_controller.rb
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/controllers/webui/requests/deletions_controller.rb
M src/api/app/controllers/webui/requests/role_additions_controller.rb
M src/api/app/controllers/webui/requests/submissions_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/calls_delete_file_method.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_no_permissions/1_5_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_no_permissions/1_5_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_not_successful_backend_call/1_5_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/DELETE_remove_file/with_successful_backend_call/1_5_1_4.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_NOT_authorized_to_edit_the_package/1_16_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_edit/when_the_user_is_authorized_to_edit_the_package/1_16_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/1_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/1_2_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_meta/sends_the_xml_representation_of_a_package.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_an_empty_revision_is_provided/1_9_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_an_empty_revision_is_provided/1_9_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/when_no_difference_in_sources_diff_is_empty/1_9_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/for_ASCII_files/shows_the_truncated_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/for_archives/shows_the_truncated_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_not_requested/shows_a_hint.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/does_not_show_a_hint.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/for_ASCII_files/shows_the_complete_diff.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rdiff/with_diff_truncation/full_diff_requested/for_archives/shows_the_complete_diff.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_package.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_project.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_without_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/returns_revisions_with_the_default_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_up_to_rev_parameter_s_value_without_pagination.yml
M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/returns_revisions_up_to_rev_parameter_s_value_with_the_default_pagination.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_no_rpmlint_log_is_available/1_14_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_no_rpmlint_log_is_available/1_14_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_there_is_a_rpmlint_log/1_14_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_rpmlint_log/when_there_is_a_rpmlint_log/1_14_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/require_package_before_action/with_an_invalid_package/1_4_1_1_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_3_1_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_3_1_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_5_1_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_existent_revision/1_4_5_1_2.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_3_2_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_3_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_5_2_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/revision_handling/with_a_rev_parameter_with_non-existent_revision/1_4_5_2_2.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_2_1.yml
A src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_2_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_3_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_that_has_a_broken_service/1_4_3_2.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_without_sourceaccess/1_4_4_1.yml
R src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_package_without_sourceaccess/1_4_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_show/with_a_valid_package/assigns_package.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_does_not_return_statistics/1_12_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_raises_an_exception/1_12_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_returns_statistics/1_12_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_statistics/when_backend_returns_statistics/1_12_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/with_right_params/1_7_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_a_service_file_in_the_package/1_7_2_3.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/GET_trigger_services/without_permissions/1_7_3_3.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/PATCH_update/when_the_user_is_authorized_to_change_the_package/1_17_1_4.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_fails/1_11_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_fails/lets_the_user_know_there_was_an_error.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_succeeds/1_11_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_abort_build/when_aborting_the_build_succeeds/1_11_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/Package_save_failed/1_15_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/Package_save_failed/1_15_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/invalid_package_name/1_15_2_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/invalid_package_name/1_15_2_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/not_allowed_to_create_package_in/1_15_2_5_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/not_allowed_to_create_package_in/1_15_2_5_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/package_already_exist/1_15_2_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/package_already_exist/1_15_2_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_name/1_15_2_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_with_source_protection_enabled/1_15_2_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_create/package_creation/valid_package_with_source_protection_enabled/1_15_2_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/1_3_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/1_3_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package/deletes_the_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package_with_dependencies/does_not_delete_the_package_and_shows_an_error_message.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/a_package_with_dependencies/forcing_the_deletion/deletes_the_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/authentication/allows_admins_to_delete_other_user_s_packages.yml
M src/api/spec/cassettes/Webui_PackageController/POST_remove/authentication/does_not_allow_other_users_than_the_owner_to_delete_a_package.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/invalid_data/1_1_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/invalid_data/1_1_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_3.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save/valid_data/1_1_1_4.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_6_1.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_6_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_7_1.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_connection_with_the_backend_fails/1_8_7_2.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_7_1.yml
A src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_7_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_8_1.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/when_not_found_the_User_or_Group/1_8_8_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_package_name/1_8_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_package_name/1_8_3_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_project_name/1_8_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_invalid_project_name/1_8_4_2.yml
R src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_an_unexistent_package/1_8_6_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_invalid_XML/1_8_5_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_invalid_XML/1_8_5_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_proper_params/1_8_1_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/with_proper_params/1_8_1_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/without_admin_rights_to_raise_protection_level/1_8_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_save_meta/without_admin_rights_to_raise_protection_level/1_8_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/1_10_4_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/1_10_4_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/lets_the_user_know_there_was_an_error.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_fails/redirects_to_the_package_binaries_path.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_succeeds/1_10_2_1.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_succeeds/1_10_2_2.yml
M src/api/spec/cassettes/Webui_PackageController/POST_trigger_rebuild/when_triggering_a_rebuild_with_maintainer_of_package/1_10_3_1.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_1.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_2.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_3.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_4.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_5.yml
M src/api/spec/cassettes/Webui_PackageController/_rpmlint_result/1_13_6.yml
M src/api/spec/cassettes/Webui_PackageController/when_the_user_is_NOT_authorized_to_change_the_package/1_18_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_packages_without_a_build_reason/1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_packages_without_a_build_reason/redirects_to_package_binaries_path.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_valid_requests/has_build_reason.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/for_valid_requests/responds_with_200_OK.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_architecture/1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_architecture/redirects_to_package_binaries_path.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_respository/1_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildReasonController/GET_index/without_a_valid_respository/1_1_1_2.yml
M src/api/spec/controllers/webui/attribute_controller_spec.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb
M src/api/spec/controllers/webui/webui_controller_spec.rb
Log Message:
-----------
Merge pull request #14963 from hennevogel/refactoring/require_package
Simplify require_package and use it everywhere
Compare: https://github.com/openSUSE/open-build-service/compare/0cb801cf6f6b...68dbc9...
Henne Vogelsang