October 2023 - Open Build Service Commits

[openSUSE/open-build-service] bdf2de: Only check if user has moderator role in `is_moder...
by Lukas Krause 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bdf2dec018841af43fe3de8a491c05e88019ef36 https://github.com/openSUSE/open-build-service/commit/bdf2dec018841af43fe3d… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M src/api/app/models/user.rb M src/api/app/policies/decision_policy.rb Log Message: ----------- Only check if user has moderator role in `is_moderator?` method In the beginning of the content_moderation feature we considered user that have the admin or stuff roles to be moderator. But now we have the dedicated moderator role. So we only should check for that in the `is_moderator?` method and leave the rest to the pundit policies. Commit: 9a58e678e4d37cf0e62c374ddf5a2724764a88be https://github.com/openSUSE/open-build-service/commit/9a58e678e4d37cf0e62c3… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/event_subscription/form.rb M src/api/app/policies/report_policy.rb M src/api/app/services/notification_service/notifier.rb Log Message: ----------- Create `notify?` report policy Right now the authorization logic is spread over several places. Lets move it to a policy to avoid duplications and confusion. The policy is meant to decide if a user should be notified about a created report or not. Commit: e245a717a01c83485f644d4f5bf0432ce5ef0d37 https://github.com/openSUSE/open-build-service/commit/e245a717a01c83485f644… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M src/api/app/policies/comment_policy.rb M src/api/spec/factories/users.rb M src/api/spec/policies/comment_policy_spec.rb Log Message: ----------- Consider user with moderator role in comment `moderate?` policy Commit: 02b968df5a8937f5f34b98182e22c243e8d39665 https://github.com/openSUSE/open-build-service/commit/02b968df5a8937f5f34b9… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M src/api/spec/policies/report_policy_spec.rb Log Message: ----------- Create spec for report `notify?` policy Commit: 86327d2135db16a62732b944a73a8b33e3c61a07 https://github.com/openSUSE/open-build-service/commit/86327d2135db16a62732b… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M src/api/app/policies/comment_policy.rb Log Message: ----------- Avoid self moderating/unmoderating comments Commit: ffe5a31cdbdd4ef171e852de18177350e4103d75 https://github.com/openSUSE/open-build-service/commit/ffe5a31cdbdd4ef171e85… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/event_subscription/form.rb M src/api/app/models/user.rb M src/api/app/policies/comment_policy.rb M src/api/app/policies/decision_policy.rb M src/api/app/policies/report_policy.rb M src/api/app/services/notification_service/notifier.rb M src/api/spec/factories/users.rb M src/api/spec/policies/comment_policy_spec.rb M src/api/spec/policies/report_policy_spec.rb Log Message: ----------- Merge pull request #14964 from krauselukas/align_is_moderator_method Align `is_moderator?` method and report pundit policies Compare: https://github.com/openSUSE/open-build-service/compare/91bf8164b20a...ffe5a…

1 0

[openSUSE/osc]
by Daniel Mach 04 Oct '23

04 Oct '23

Branch: refs/tags/1.4.0 Home: https://github.com/openSUSE/osc

1 0

[openSUSE/osc] 62e481: release 1.4.0
by Daniel Mach 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 62e4817ff59640d67a8c1167eb4dd25e3e90a91a https://github.com/openSUSE/osc/commit/62e4817ff59640d67a8c1167eb4dd25e3e90… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M NEWS M contrib/osc.spec M osc/__init__.py Log Message: ----------- release 1.4.0

1 0

[openSUSE/osc] 2f1cb0: Remove any duplicated code loading configuration f...
by Daniel Mach 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 2f1cb0edb1df9a6f1ca908a50b31e2c06910abea https://github.com/openSUSE/osc/commit/2f1cb0edb1df9a6f1ca908a50b31e2c06910… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/build.py M osc/commandline.py M osc/conf.py Log Message: ----------- Remove any duplicated code loading configuration from ENV The current conf.get_config() function already handles loading from ENV. Also, always use osc.build.calculate_build_root() instead of making a custom variable substitution. Commit: 8eb360234ecfbda713e4736080147b890e32cc98 https://github.com/openSUSE/osc/commit/8eb360234ecfbda713e4736080147b890e32… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/build.py M osc/commandline.py M osc/conf.py Log Message: ----------- Add rootless build support to 'build' command for 'kvm' and 'podman' vm types To avoid filesystem permission collisions with the builds using su_wrapper, use an alternative buildroot path that appends username to '/var/tmp/build-root' for the rootless builds. Commit: 88c2bf4fea06c2fd08a14935b41b0767952a9733 https://github.com/openSUSE/osc/commit/88c2bf4fea06c2fd08a14935b41b0767952a… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/commandline.py Log Message: ----------- Avoid adding a newline to prompt in 'wipe' command Commit: 28efb4396a20b913f22891c53cecb9c9f9ccf54d https://github.com/openSUSE/osc/commit/28efb4396a20b913f22891c53cecb9c9f9cc… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/conf.py Log Message: ----------- Rename conf.Options.build_type to vm_type to be consistent with obs build and osc --vm-type option Commit: 47f32e6ef19f41104ba59734c531f86151991c72 https://github.com/openSUSE/osc/commit/47f32e6ef19f41104ba59734c531f8615199… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/conf.py Log Message: ----------- Update list of supported vm_type values in conf.Options.vm_type Commit: 41ce9326737e661e6533f5f00f768b865252c35c https://github.com/openSUSE/osc/commit/41ce9326737e661e6533f5f00f768b865252… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M osc/build.py Log Message: ----------- Fix 'build' command to pass '--vm-type' option to the underlying build tool Commit: a33d4c2d41bb338410910bb94771ced08b606d8e https://github.com/openSUSE/osc/commit/a33d4c2d41bb338410910bb94771ced08b60… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M osc/build.py Log Message: ----------- Print a hint to clean the build root after a failed build Commit: a6946587e1b2115d0d2554c5feaa0314ab6f4fde https://github.com/openSUSE/osc/commit/a6946587e1b2115d0d2554c5feaa0314ab6f… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M osc/conf.py Log Message: ----------- Fix reading configuration from ENV Commit: a16654663b886be77fd12049a26536d59e5594e6 https://github.com/openSUSE/osc/commit/a16654663b886be77fd12049a26536d59e55… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M osc/build.py M osc/commandline.py M osc/conf.py Log Message: ----------- Merge pull request #1415 from dmach/rootless-kvm-and-podman Rootless kvm and podman Compare: https://github.com/openSUSE/osc/compare/bd14f7e000c0...a16654663b88

1 0

[openSUSE/osc] 0848ab: add support for keep_packages_locked on request re...
by Daniel Mach 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 0848aba7b981c7402dc0ffae1c09dd17be45a039 https://github.com/openSUSE/osc/commit/0848aba7b981c7402dc0ffae1c09dd17be45… Author: Adrian Schröter <adrian(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M osc/commandline.py M osc/core.py Log Message: ----------- add support for keep_packages_locked on request revoke jsc#OBS-134 Commit: f6cb22824226990a149ab2c9383da464e37bba60 https://github.com/openSUSE/osc/commit/f6cb22824226990a149ab2c9383da464e37b… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M osc/commandline.py Log Message: ----------- Document that 'request revoke' command may need '--keep-packages-locked' option to avoid unlocking source packages Commit: bd14f7e000c0a83871493fea414a8a2d4d05c4e1 https://github.com/openSUSE/osc/commit/bd14f7e000c0a83871493fea414a8a2d4d05… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M osc/commandline.py M osc/core.py Log Message: ----------- Merge pull request #1416 from adrianschroeter/keep_packages_locked add support for keep_packages_locked on request revoke Compare: https://github.com/openSUSE/osc/compare/11c2140ad832...bd14f7e000c0

1 0

[openSUSE/osc] ce72ff: Fix loading password from keyring
by Daniel Mach 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: ce72ffb225e504ff51f12214bed34dcf14049708 https://github.com/openSUSE/osc/commit/ce72ffb225e504ff51f12214bed34dcf1404… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M osc/conf.py Log Message: ----------- Fix loading password from keyring Commit: 11c2140ad832676fe784e32742b623010c8491d1 https://github.com/openSUSE/osc/commit/11c2140ad832676fe784e32742b623010c84… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M osc/conf.py Log Message: ----------- Merge pull request #1420 from dmach/fix-loading-password-from-keyring Fix loading password from keyring Compare: https://github.com/openSUSE/osc/compare/91a30963d504...11c2140ad832

1 0

[openSUSE/open-build-service] 91bf81: Update haml_lint to version 0.51.0 (#14996)
by depfu[bot] 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 91bf8164b20aca0ce5a91dcc71d0285f99969dad https://github.com/openSUSE/open-build-service/commit/91bf8164b20aca0ce5a91… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/haml-6.1.2.gem A src/api/vendor/cache/haml-6.2.0.gem R src/api/vendor/cache/haml_lint-0.50.0.gem A src/api/vendor/cache/haml_lint-0.51.0.gem Log Message: ----------- Update haml_lint to version 0.51.0 (#14996)

1 0

[openSUSE/open-build-service]
by depfu[bot] 04 Oct '23

04 Oct '23

Branch: refs/heads/depfu/update/srcapi/haml_lint-0.51.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 4b0d68: Update rubocop-rspec to version 2.24.1
by Dani Donisa 04 Oct '23

04 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4b0d6897efdd6513b4e3c3b8d909e751d5ac56c6 https://github.com/openSUSE/open-build-service/commit/4b0d6897efdd6513b4e3c… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-rspec-2.24.0.gem A src/api/vendor/cache/rubocop-rspec-2.24.1.gem Log Message: ----------- Update rubocop-rspec to version 2.24.1 Commit: 8ba29cdb97924ad1441b32f8b08fba5e5c0d1121 https://github.com/openSUSE/open-build-service/commit/8ba29cdb97924ad1441b3… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M src/api/.rubocop.yml Log Message: ----------- Disable RSpec/FilePath RSpec/FilePath is deprecated but is considered the default. That's why we have to disable it (Enable: false). Recently we moved the files we excluded from deprecated RSpec/FilePath to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. Commit: 26077e40e687bfbef947fc50c3777604b4da5449 https://github.com/openSUSE/open-build-service/commit/26077e40e687bfbef947f… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Update Rubocop TODO Commit: 4b60fcc743e47222f94b7d0c24c03fc600138546 https://github.com/openSUSE/open-build-service/commit/4b60fcc743e47222f94b7… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-rspec-2.24.0.gem A src/api/vendor/cache/rubocop-rspec-2.24.1.gem Log Message: ----------- Merge pull request #14956 from openSUSE/depfu/update/srcapi/rubocop-rspec-2.24.1 [src/api] Update rubocop-rspec 2.24.0 → 2.24.1 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/6444586a057f...4b60f…

1 0

[openSUSE/open-build-service]
by Dani Donisa 04 Oct '23

04 Oct '23

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-2.24.1 Home: https://github.com/openSUSE/open-build-service

1 0