February 2022 - Open Build Service Commits

[openSUSE/open-build-service] 5ae63b: Eager load project when fetching packages in Watch...
by Dany Marcoux 23 Feb '22

23 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5ae63b64ea4bc475de151e2520407e2a6f748387 https://github.com/openSUSE/open-build-service/commit/5ae63b64ea4bc475de151… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-02-22 (Tue, 22 Feb 2022) Changed paths: M src/api/app/components/watchlist_component.rb Log Message: ----------- Eager load project when fetching packages in WatchlistComponent This removes N+1 queries, as we need the project in the method `toggle_watchable_path`. Commit: b570056ba232cd65e73cfc5c74f6e888ae4e23a6 https://github.com/openSUSE/open-build-service/commit/b570056ba232cd65e73cf… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-02-22 (Tue, 22 Feb 2022) Changed paths: M src/api/app/components/watchlist_component.rb Log Message: ----------- Check if object is a watched item with a single query As an example for a watched item with a watchable being a package. Before, we executed 2 queries. 1. Fetching all columns of the watched item: SELECT `watched_items`.* FROM `watched_items` WHERE `watched_items`.`user_id` = 1 AND `watched_items`.`watchable_type` = 'Package' AND `watched_items`.`watchable_id` = 3 LIMIT 1 2. Fetching the watchable (a package): SELECT `packages`.* FROM `packages` WHERE `packages`.`id` NOT IN (SELECT `packages`.`id` FROM `packages` WHERE `packages`.`project_id` = 0) AND `packages`.`id` = 3 Now, we execute 1 query: SELECT 1 AS one FROM `watched_items` WHERE `watched_items`.`user_id` = 1 AND `watched_items`.`watchable_type` = 'Package' AND `watched_items`.`watchable_id` = 3 LIMIT 1 While testing locally, it tends to be a bit faster by about 1ms. It's definitely more in production since the database has more workload, so executing more queries tends to be more expensive. Commit: b50859b6f193dbdabee58f507b0af50cd25bb2cb https://github.com/openSUSE/open-build-service/commit/b50859b6f193dbdabee58… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/app/components/watchlist_component.rb Log Message: ----------- Merge pull request #12243 from dmarcoux/queries-watchlist Improve queries in WatchlistComponent Compare: https://github.com/openSUSE/open-build-service/compare/80f03ed7127f...b5085…

1 0

[openSUSE/open-build-service] 20b9e3: Fix flaky spec in NotificationAvatarsComponent
by Saray Cabrera Padrón 23 Feb '22

23 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 20b9e32ddc86aaa8c717c70841f718b6c1c9b066 https://github.com/openSUSE/open-build-service/commit/20b9e32ddc86aaa8c717c… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/spec/components/notification_avatars_component_spec.rb Log Message: ----------- Fix flaky spec in NotificationAvatarsComponent Flaky specs are listed in CircleCI: https://app.circleci.com/insights/github/openSUSE/open-build-service/workfl… Commit: 80f03ed7127fd23f073bb8a3a4f30223995ac83d https://github.com/openSUSE/open-build-service/commit/80f03ed7127fd23f073bb… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/spec/components/notification_avatars_component_spec.rb Log Message: ----------- Merge pull request #12249 from dmarcoux/fix-flaky-spec-NotificationAvatarsComponent Fix flaky spec in NotificationAvatarsComponent Compare: https://github.com/openSUSE/open-build-service/compare/15a4d1e655ff...80f03…

1 0

[openSUSE/obs-service-source_validator] bb616d: 45-stale-changes: Also read <package/> in _multibuild
by Dirk Mueller 23 Feb '22

23 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-service-source_validator Commit: bb616d2c538d2487120c02e8067319e16b23b337 https://github.com/openSUSE/obs-service-source_validator/commit/bb616d2c538… Author: Fabian Vogt <fvogt(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M 45-stale-changes Log Message: ----------- 45-stale-changes: Also read <package/> in _multibuild It was missing handling for <package/> next to <flavor/> tags. Commit: c116a7b4cd033a295efeb1b7ff9e104e4550394e https://github.com/openSUSE/obs-service-source_validator/commit/c116a7b4cd0… Author: Dirk Mueller <dmueller(a)suse.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M 45-stale-changes Log Message: ----------- Merge pull request #96 from Vogtinator/mbfix 45-stale-changes: Also read <package/> in _multibuild Compare: https://github.com/openSUSE/obs-service-source_validator/compare/cef379cd1f…

1 0

[openSUSE/open-build-service]
by Eduardo J. 23 Feb '22

23 Feb '22

Branch: refs/heads/depfu/update/srcapi/rubocop-ast-1.16.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 99b9d9: Update rubocop-ast to version 1.16.0
by Eduardo J. 23 Feb '22

23 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 99b9d9a6509ea2554ad3fe69b19685a989873b6f https://github.com/openSUSE/open-build-service/commit/99b9d9a6509ea2554ad3f… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-ast to version 1.16.0 Commit: 15a4d1e655ffd361dcb6ab8b67f861f0eb3095db https://github.com/openSUSE/open-build-service/commit/15a4d1e655ffd361dcb6a… Author: Eduardo J <enavarro(a)suse.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #12246 from openSUSE/depfu/update/srcapi/rubocop-ast-1.16.0 [src/api] Update rubocop-ast: 1.15.2 → 1.16.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/3af61e20042d...15a4d…

1 0

[openSUSE/open-build-service] 99b9d9: Update rubocop-ast to version 1.16.0
by depfu[bot] 23 Feb '22

23 Feb '22

Branch: refs/heads/depfu/update/srcapi/rubocop-ast-1.16.0 Home: https://github.com/openSUSE/open-build-service Commit: 99b9d9a6509ea2554ad3fe69b19685a989873b6f https://github.com/openSUSE/open-build-service/commit/99b9d9a6509ea2554ad3f… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-ast to version 1.16.0

1 0

[openSUSE/open-build-service] 88abd5: Update parser to version 3.1.1.0
by Eduardo J. 23 Feb '22

23 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 88abd54208efbb8b1f430fc14fa5dacc2dae87dd https://github.com/openSUSE/open-build-service/commit/88abd54208efbb8b1f430… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-22 (Tue, 22 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update parser to version 3.1.1.0 Commit: 3af61e20042d37e0e0170f0a2e0151bf1c3a4416 https://github.com/openSUSE/open-build-service/commit/3af61e20042d37e0e0170… Author: Eduardo J <enavarro(a)suse.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #12244 from openSUSE/depfu/update/srcapi/parser-3.1.1.0 [src/api] Update parser: 3.1.0.0 → 3.1.1.0 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/d1e1f342bf9a...3af61…

1 0

[openSUSE/open-build-service]
by Eduardo J. 23 Feb '22

23 Feb '22

Branch: refs/heads/depfu/update/srcapi/parser-3.1.1.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 7084c1: Update rubocop-ast to version 1.16.0
by depfu[bot] 23 Feb '22

23 Feb '22

Branch: refs/heads/depfu/update/srcapi/rubocop-ast-1.16.0 Home: https://github.com/openSUSE/open-build-service Commit: 7084c1a74b65392bb61e1ad1618605ddc96e8437 https://github.com/openSUSE/open-build-service/commit/7084c1a74b65392bb61e1… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-23 (Wed, 23 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-ast to version 1.16.0

1 0

[openSUSE/open-build-service] 88abd5: Update parser to version 3.1.1.0
by depfu[bot] 22 Feb '22

22 Feb '22

Branch: refs/heads/depfu/update/srcapi/parser-3.1.1.0 Home: https://github.com/openSUSE/open-build-service Commit: 88abd54208efbb8b1f430fc14fa5dacc2dae87dd https://github.com/openSUSE/open-build-service/commit/88abd54208efbb8b1f430… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-22 (Tue, 22 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update parser to version 3.1.1.0

1 0