November 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] a5ec66: Update rubocop to version 0.60.0
by Dany Marcoux 05 Nov '18

05 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a5ec667bf08c5e259c60180dab1398385bd01844 https://github.com/openSUSE/open-build-service/commit/a5ec667bf08c5e259c601… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop to version 0.60.0 Commit: 0b442dda0bd87325634d093b88ecb2d9f1b615a2 https://github.com/openSUSE/open-build-service/commit/0b442dda0bd87325634d0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/refresh_monitor.html.erb Log Message: ----------- Refactor conversion of current time in project monitor page We've been fetching the 'DateTime' and afterwards did some string replacement which made the produced string look (almost) identical[*] to what 'Time.now.to_s' would produce. Instead of doing all that we now just use 'Time.now'. Time.now.to_s: "2018-10-30 13:25:52 +0000" DateTime.now.to_s.sub('T', ' '): "2018-10-30 13:26:11+00:00" The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: c926b74c2025e9cc84392f8d0d4dd3d5678bbd59 https://github.com/openSUSE/open-build-service/commit/c926b74c2025e9cc84392… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Use Time.now for auto accept / auto cleanup Active Record internally converts the time accept_at string to datetime which means we can safely use Time.now (the produced request xml does not change). Also the conversion and comparison of Time and DateTime is still working after this change. The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 12c90dbe0a1e856381764274e5a014479f57a049 https://github.com/openSUSE/open-build-service/commit/12c90dbe0a1e856381764… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Use Time.now when comparing times Rubocop prefers using 'Time.now' over 'DateTime.now'[*]. Since comparing objects of both classes works as expected, it's safe to change this. [*] https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 47f890f0bf568aeee3c601cce3d8b7ad105a0268 https://github.com/openSUSE/open-build-service/commit/47f890f0bf568aeee3c60… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/test/functional/maintenance_test.rb Log Message: ----------- Update tests to not use DateTime This is needed to silence the Rubocop Style/DateTime cop. Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: 4309ed5b74a8f5bcddc9acfbda316ca45f42cf29 https://github.com/openSUSE/open-build-service/commit/4309ed5b74a8f5bcddc9a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/lib/pretty_nested_errors/key_and_messages_parser.rb Log Message: ----------- Solve Rubocop offenses: Style/MutableConstant Commit: 63ed40de1ada5acefb3b014acfaf117988bfc35f https://github.com/openSUSE/open-build-service/commit/63ed40de1ada5acefb3b0… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/cloud/backend/upload_job.rb Log Message: ----------- Solve Style/DateTime rubocop offenses Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: cfee844d2dc5033c3980b35a00a59120acdd1dd4 https://github.com/openSUSE/open-build-service/commit/cfee844d2dc5033c3980b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb Log Message: ----------- Avoid to_time casts as it puzzles rubocop Commit: a66463f52c8fd8f981df2ea05ec8ca719585d1aa https://github.com/openSUSE/open-build-service/commit/a66463f52c8fd8f981df2… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock M src/api/app/controllers/request_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/cloud/backend/upload_job.rb M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/refresh_monitor.html.erb M src/api/lib/pretty_nested_errors/key_and_messages_parser.rb M src/api/spec/features/webui/requests_spec.rb M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/test/functional/maintenance_test.rb Log Message: ----------- Merge pull request #6144 from openSUSE/depfu/update/srcapi/rubocop-0.60.0 [src/api] Update rubocop: 0.59.2 → 0.60.0 (major) Compare: https://github.com/openSUSE/open-build-service/compare/d64f16d23619...a6646… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 25c0ab: Fix staging_project table content
by Moisés Déniz Alemán 05 Nov '18

05 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 25c0ab8bbd9dc3fffdc01af3d485bf45d71d6618 https://github.com/openSUSE/open-build-service/commit/25c0ab8bbd9dc3fffdc01… Author: David Kang <dkang(a)suse.com> Date: 2018-11-02 (Fri, 02 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging_workflows/show.html.haml Log Message: ----------- Fix staging_project table content Staging Project table was wrongly indented and this was causing that the table has two thead and tbody. Commit: cfdd17693d4b688128e3212048757a09f9a4931a https://github.com/openSUSE/open-build-service/commit/cfdd17693d4b688128e32… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging_workflows/show.html.haml Log Message: ----------- Merge pull request #6169 from DavidKang/fix-table Fix staging_project table content Compare: https://github.com/openSUSE/open-build-service/compare/3bd5ebc96891...cfdd1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] a5ec66: Update rubocop to version 0.60.0
by Stephan Kulow 05 Nov '18

05 Nov '18

Branch: refs/heads/depfu/update/srcapi/rubocop-0.60.0 Home: https://github.com/openSUSE/open-build-service Commit: a5ec667bf08c5e259c60180dab1398385bd01844 https://github.com/openSUSE/open-build-service/commit/a5ec667bf08c5e259c601… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop to version 0.60.0 Commit: 0b442dda0bd87325634d093b88ecb2d9f1b615a2 https://github.com/openSUSE/open-build-service/commit/0b442dda0bd87325634d0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/refresh_monitor.html.erb Log Message: ----------- Refactor conversion of current time in project monitor page We've been fetching the 'DateTime' and afterwards did some string replacement which made the produced string look (almost) identical[*] to what 'Time.now.to_s' would produce. Instead of doing all that we now just use 'Time.now'. Time.now.to_s: "2018-10-30 13:25:52 +0000" DateTime.now.to_s.sub('T', ' '): "2018-10-30 13:26:11+00:00" The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: c926b74c2025e9cc84392f8d0d4dd3d5678bbd59 https://github.com/openSUSE/open-build-service/commit/c926b74c2025e9cc84392… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Use Time.now for auto accept / auto cleanup Active Record internally converts the time accept_at string to datetime which means we can safely use Time.now (the produced request xml does not change). Also the conversion and comparison of Time and DateTime is still working after this change. The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 12c90dbe0a1e856381764274e5a014479f57a049 https://github.com/openSUSE/open-build-service/commit/12c90dbe0a1e856381764… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Use Time.now when comparing times Rubocop prefers using 'Time.now' over 'DateTime.now'[*]. Since comparing objects of both classes works as expected, it's safe to change this. [*] https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 47f890f0bf568aeee3c601cce3d8b7ad105a0268 https://github.com/openSUSE/open-build-service/commit/47f890f0bf568aeee3c60… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/test/functional/maintenance_test.rb Log Message: ----------- Update tests to not use DateTime This is needed to silence the Rubocop Style/DateTime cop. Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: 4309ed5b74a8f5bcddc9acfbda316ca45f42cf29 https://github.com/openSUSE/open-build-service/commit/4309ed5b74a8f5bcddc9a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/lib/pretty_nested_errors/key_and_messages_parser.rb Log Message: ----------- Solve Rubocop offenses: Style/MutableConstant Commit: 63ed40de1ada5acefb3b014acfaf117988bfc35f https://github.com/openSUSE/open-build-service/commit/63ed40de1ada5acefb3b0… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/cloud/backend/upload_job.rb Log Message: ----------- Solve Style/DateTime rubocop offenses Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: cfee844d2dc5033c3980b35a00a59120acdd1dd4 https://github.com/openSUSE/open-build-service/commit/cfee844d2dc5033c3980b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb Log Message: ----------- Avoid to_time casts as it puzzles rubocop Compare: https://github.com/openSUSE/open-build-service/compare/a2ed01381af0...cfee8… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 05 Nov '18

05 Nov '18

Branch: refs/heads/depfu/update/srcapi/font-awesome-sass-5.5.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 0d9342: Update font-awesome-sass to version 5.5.0
by Eduardo J 05 Nov '18

05 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0d93429355772286d2eb2ad55a6b7f8a6e6954d0 https://github.com/openSUSE/open-build-service/commit/0d93429355772286d2eb2… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update font-awesome-sass to version 5.5.0 Commit: d64f16d23619f286db1624bfe75b7c3720bd8271 https://github.com/openSUSE/open-build-service/commit/d64f16d23619f286db162… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6179 from openSUSE/depfu/update/srcapi/font-awesome-sass-5.5.0 [src/api] Update font-awesome-sass: 5.4.1 → 5.5.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/84f6a4ea15df...d64f1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 84f6a4: [ci] fix tests for 2.8/2.9
by Frank Schreiner 05 Nov '18

05 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 84f6a4ea15dfa05ad82555132a544fe8e82eafdd https://github.com/openSUSE/open-build-service/commit/84f6a4ea15dfa05ad8255… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M dist/t/0060-check_required_services.ts Log Message: ----------- [ci] fix tests for 2.8/2.9 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] e54a9a: Avoid a cassette trick in worker status
by Stephan Kulow 05 Nov '18

05 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e54a9a6c4f2aa988ee7ca649ae6c43ef3db26041 https://github.com/openSUSE/open-build-service/commit/e54a9a6c4f2aa988ee7ca… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/controllers/worker/status_controller_spec.rb A src/api/spec/fixtures/files/worker_status_response.xml Log Message: ----------- Avoid a cassette trick in worker status Commit: 913780b08f90812722ca3adae8c624af88f6390f https://github.com/openSUSE/open-build-service/commit/913780b08f90812722ca3… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/controllers/worker/status_controller_spec.rb A src/api/spec/fixtures/files/worker_status_response.xml Log Message: ----------- Merge pull request #6175 from coolo/avoid_cassette_trick Avoid a cassette trick in worker status Compare: https://github.com/openSUSE/open-build-service/compare/6fe2b8f269de...91378… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 05 Nov '18

05 Nov '18

Branch: refs/heads/depfu/update/srcapi/capybara-3.10.1 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 82c146: Update capybara to version 3.10.1
by Stephan Kulow 05 Nov '18

05 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 82c146cb5eb8c3aeb339881cbba90cd7626fa6d5 https://github.com/openSUSE/open-build-service/commit/82c146cb5eb8c3aeb3398… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.10.1 Commit: 6fe2b8f269dee2403e912be1aa9adb434738395c https://github.com/openSUSE/open-build-service/commit/6fe2b8f269dee2403e912… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6178 from openSUSE/depfu/update/srcapi/capybara-3.10.1 [src/api] Update capybara: 3.10.0 → 3.10.1 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/a535df1ba1f3...6fe2b… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 05 Nov '18

05 Nov '18

Branch: refs/heads/depfu/update/srcapi/pkg-config-1.3.2 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0