The ${_mingw32_makeinstall} macro from mingw32-filesystem seems broken. The reason is that ${buildroot} is empty. IIRC it used to be the same as $RPM_BUILD_ROOT. Has anything changed? Anyway, the canonical way to make install seems to be make DESTDIR=$RPM_BUILD_ROOT install but a simple ${_mingw32_makeinstall} seems more clean to me. But the advantage of the DESTDIR approach is that even when a Makefile.am file defines a custom dir not listed in mingw32-filesystem (pulseaudio defines such an extra dir), the files get installed in the expected location. Maarten -- To unsubscribe, e-mail: opensuse-mingw+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-mingw+help@opensuse.org
Maarten, On Wed, 2011-04-06 at 01:36 +0200, Maarten Bosmans wrote:
The ${_mingw32_makeinstall} macro from mingw32-filesystem seems broken. The reason is that ${buildroot} is empty. IIRC it used to be the same as $RPM_BUILD_ROOT. Has anything changed?
I normally did not use this macro unless in some cases that might actually be solved already. I pointed out some flaws in this macro on the fedora-mingw list some years ago. And I preferred to patch the misbehaving packages to make them work with DESTDIR. I kept it there just for historical reasons. We might actually get rid of it next time we *must* touch mingw32-filesystem (such a modification will trigger complete rebuild of all the stack).
Anyway, the canonical way to make install seems to be make DESTDIR=$RPM_BUILD_ROOT install but a simple ${_mingw32_makeinstall} seems more clean to me. But the advantage of the DESTDIR approach is that even when a Makefile.am file defines a custom dir not listed in mingw32-filesystem (pulseaudio defines such an extra dir), the files get installed in the expected location.
Yup, this is the canonical way, or even sometimes "%{_mingw32_make} DESTDIR=$RPM_BUILD_ROOT install" when you need the mingw32 environment for some of the installation tasks. Cheers F. -- To unsubscribe, e-mail: opensuse-mingw+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-mingw+help@opensuse.org
participants (2)
-
Fridrich Strba
-
Maarten Bosmans