[opensuse-kernel] [PATCH] Fix armv7 kernel-default config
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
Signed-off-by: Guillaume GARDET
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream. thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream.
Hi Greg - Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined! Somehow the exported symbols aren't being made available to modules when ezusb is a built-in. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQyKnYAAoJEB57S2MheeWySdsP/1VaTne96twW+CS1yh4+OT6t apQ33kWrnI9a+4rx8Vzu5FVXgbYFhddgq1MxiqCaUfTC4L4PhIyRW9VGGnV78iSP wYdJvKCrH852oCW8w5Aex2W1ZkDPFx+1NJQOdLymTkxC6pAbC3tyoy6Cq7otXvnw lAL4o6oaf5x4UmCQ1Oxm26Cn8+JD90URkMUg+WWGb9sBCmjqu6scDyIt+TXvc+HQ IP9x5Sc8tMCwkFl9u053Vd2dt5fB/tk6qOjRKNvVS1tgClZfBtoxrFsk+791Au51 uMIOCS3Ey5EEIRZcTdzNPimrkQq4R3JQsL0X6N6dyfS8oxF1QVsi4beoQDtxIkX1 V3tIN/DqIls14GdagS1Wgn9I/KzHOSXtrJV37727PK6ukpLWA3lENkgvkrJePg1a 8ACNtlREQX33RQAKF3v3EPyDFmoFrjF/yRH/WT1aCjdzy2Nm+Cg3AxiEFCu126es K5Xif3LlNUcWoUM9aQ38nE6kCxI0GXTrb/ZTmrDv+bKh3yEibxijpw0mpzxCHKpI amFN6W2tt2C95rXWUG+G3w9+vqZ9RQ/+93bSXcgzp4CkI2SFpKQFiBp9PNs+dRtG nIozZofDVWyA4uEjec1TC04h8vKi4z5VP0HiH8CqkeGfI684Ev8Od5WsRNtO46FY uUvxm9/+YverGG2AChq+ =O27f -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote:
On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream.
Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in.
Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this. If not, it would be great to know. thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/12/12 11:10 AM, Greg Kroah-Hartman wrote:
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote:
On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream.
Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in.
Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this.
If not, it would be great to know.
Ah. Perfect. That's the patch I came up with as well. It does fix it. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQyK4PAAoJEB57S2MheeWy5MsQAKRINa8byzjXdbUbkQzWRg6G wVftvlm3sIs7EROfKhZxYsjgWc8NKUxdooQvDwYMiBQ3YLclQKsixBiLQvJP4/gw teohyJXvYBkqUQ8Hx9NwLle9Fz9qHr4O+F/oLOPA0Z09SsRqZ+W2/xpX6sPxbkpn XgQfDg3jq2UfoNYxf18uB/e7FU2F6x1WMEnm4cpzYDDHrgn8dIhho3fFsA0z5r7U TFVOxiodr9QSPMTYL8SvmCtmFdKUsmWlzfUK4b4TH53eO3wxfQhLAFBXNLJ+T+jL IWjXPGbZHuN9N2cMZOM/skC6mK77ZH/opNb/ynU+CCEJoiKpibXmOXV9Q+E5r23D i4yN09Mq85GwD9/uuQf2URUOafq28GnaucVahz/U0vUoEDqnkmWzH/Uapr5xetrL TJ32RVTHHUpvFgZFCvZ53F3cB/L5fQMbwP9ZRq1ZoHKFIFfetv+sz/4zWC2jg1TF 4DKzAKnBiEKzH1t+ci5wByMwEBifS4Zi3D4ZntJ+DPS5erm4Wwv7DxSIx+2rZX7D 3eGvEoLMCRzz5DdkxnrNSyFMH/caSxcc4Jqzcekt7nF31xLKc0A9kMi792+mqNMx oOJEDAY5mZhhkTo38nuqCe99vo08d5xTjHaOOGbriJE7wfQsxbn/0gt16K5vnclr yxowhreBqgZ/hGoj/a6g =lsQv -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/12/12 11:17 AM, Jeff Mahoney wrote:
On 12/12/12 11:10 AM, Greg Kroah-Hartman wrote:
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote:
On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream.
Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in.
Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this.
If not, it would be great to know.
Ah. Perfect. That's the patch I came up with as well. It does fix it.
Guillaume - Your patch is still valid since this will force CONFIG_USB_EZUSB_FX2=m. I'll commit both and we'll bet set here. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQyK6nAAoJEB57S2MheeWyYokQAIYdt5RQQS1gVpogd+rP12op eOsxzFyqPQdCfj15byWR193aHA7ksv1U0lYhEcDhtkb0aOGdm/goZTUL2/7Lr3Ij 2DMKPzjYDNSvo1qc461dMbfsR8ObdmfKqKmSW70WVr1EeYxYtFv/mD9U4BTd4NhZ ApFmpbyPomFvb4a3QCv2cb7x531ir9t07SShO9GA3+tUBcRzRvAm22cS8FxY5s+s tTVvpacoP8vqb5FC3OkAaViy9vKW4fjbXjBABUDeZMiopcJGFntyVAlMk2zplfyg 9Ty0y41yAoYj74xu4TiFQV/LiwvQP6Z6UazyvH8A+h9tk90OiVG6WtWjIuIYbdUX MnmLyGE9P2g7CbbghGBWpf/nm8gZ9qMW0ABAWXFS+DgDYPsE57tPpUGfSYAhX59u fcOEF69IC35XnssEDNDB6e2M9zyehtWBwNh8Egaf7qobPIadFKABCAs8NM/EZwEs KOYBFH24BZmA5pS6lmBDoWJFjNlseueu04sakwgeEqwzBUaOtZ5+LB0rnJLs/wzn qyz7YuXxd/xNavgWFYl/TplsJhIZgi9TvD+BU9hOAGKchfe8MACbBUWAjYiq5VlN oKieOf9BI/wJjW0hGi6RJZZqTlWdYWD3XOO2RvFT+EBWOq0JQSk0670kUJwJ/zCb KrzvmXgCaVUIQqsy4FKr =4d8I -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le 12/12/2012 17:19, Jeff Mahoney a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/12/12 11:17 AM, Jeff Mahoney wrote:
On 12/12/12 11:10 AM, Greg Kroah-Hartman wrote:
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote:
On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream. Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in. Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this. If not, it would be great to know. Ah. Perfect. That's the patch I came up with as well. It does fix it. Guillaume -
Your patch is still valid since this will force CONFIG_USB_EZUSB_FX2=m.
I'll commit both and we'll bet set here.
Jeff, My patch was just a workaround to fix the build, then no need to force CONFIG_USB_EZUSB_FX2 to build as a module instead of built-in if not needed. But if it is better (desired/mandatory) to have it as a module, we should fix all the kernel configs using CONFIG_USB_EZUSB_FX2, for consistency. Guillaume
- -Jeff
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQIcBAEBAgAGBQJQyK6nAAoJEB57S2MheeWyYokQAIYdt5RQQS1gVpogd+rP12op eOsxzFyqPQdCfj15byWR193aHA7ksv1U0lYhEcDhtkb0aOGdm/goZTUL2/7Lr3Ij 2DMKPzjYDNSvo1qc461dMbfsR8ObdmfKqKmSW70WVr1EeYxYtFv/mD9U4BTd4NhZ ApFmpbyPomFvb4a3QCv2cb7x531ir9t07SShO9GA3+tUBcRzRvAm22cS8FxY5s+s tTVvpacoP8vqb5FC3OkAaViy9vKW4fjbXjBABUDeZMiopcJGFntyVAlMk2zplfyg 9Ty0y41yAoYj74xu4TiFQV/LiwvQP6Z6UazyvH8A+h9tk90OiVG6WtWjIuIYbdUX MnmLyGE9P2g7CbbghGBWpf/nm8gZ9qMW0ABAWXFS+DgDYPsE57tPpUGfSYAhX59u fcOEF69IC35XnssEDNDB6e2M9zyehtWBwNh8Egaf7qobPIadFKABCAs8NM/EZwEs KOYBFH24BZmA5pS6lmBDoWJFjNlseueu04sakwgeEqwzBUaOtZ5+LB0rnJLs/wzn qyz7YuXxd/xNavgWFYl/TplsJhIZgi9TvD+BU9hOAGKchfe8MACbBUWAjYiq5VlN oKieOf9BI/wJjW0hGi6RJZZqTlWdYWD3XOO2RvFT+EBWOq0JQSk0670kUJwJ/zCb KrzvmXgCaVUIQqsy4FKr =4d8I -----END PGP SIGNATURE-----
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/12/12 11:28 AM, Guillaume Gardet wrote:
Le 12/12/2012 17:19, Jeff Mahoney a écrit : On 12/12/12 11:17 AM, Jeff Mahoney wrote:
On 12/12/12 11:10 AM, Greg Kroah-Hartman wrote:
On 12/12/12 10:07 AM, Greg KH wrote: > On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume > Gardet wrote: >> Hi, >> >> please find in attachment a patch to fix armv7 >> kernel-default config. >> >> CONFIG_USB_EZUSB_FX2 must be a module instead of >> built-in to fix build > What build problem? This should be resolved properly > upstream if it is still an issue. I thought I fixed it > a while ago, if not, please let me know upstream. Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in. Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote: tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this. If not, it would be great to know. Ah. Perfect. That's the patch I came up with as well. It does fix it. Guillaume -
Your patch is still valid since this will force CONFIG_USB_EZUSB_FX2=m.
I'll commit both and we'll bet set here.
Jeff,
My patch was just a workaround to fix the build, then no need to force CONFIG_USB_EZUSB_FX2 to build as a module instead of built-in if not needed. But if it is better (desired/mandatory) to have it as a module, we should fix all the kernel configs using CONFIG_USB_EZUSB_FX2, for consistency.
All the configs other than ARM (and vanilla, strange) had =m already to avoid this issue. I just didn't have time to look into it that day. This patch forces all of them to =m. I didn't use your patch directly as I just ran scripts/run_oldconfig.sh after applying the patch to update the configs. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQyLHvAAoJEB57S2MheeWyjsMP/1qIz0jyrJE9LM2ORoEuy2Bn +A1joy871rKy52lQKbCaQ640A2r1L2vMNLxnSqGI3g5ly+BIuPLn25L6lq4GPHY9 8D1mYe0RS4aFEBb7PM2tfmbku2/y0KUXGWjxmThceIpAGRqKy6XNDtCD9sAOJ6PG lfZHqyFu2WEeVI7Zr9XZLWUk2oYsk1s2J3ySaJX6fmCYVahmZy0lJPcXaJHHDl+1 3QuSOWt4beAGFLOfIIwKKXco5IAy55wPXMDo6zFsXjeNhY+LZcalLmL0M6Pl1zoQ d+lTJJVlxaXueeDYHPorzbbcJYFzb2NolnwSaovE/WwtrcX4FQt+TOTieoNePF84 4twssEre+2N9BFScHQNNqwTPazYZOSr3z+R8V8XW906I+GC2+6gA8sEUr4EMtTzg ZsPNWb5sVL6s3z/IDOUDEVGP0KDJpdjcbOgkEG9/pbInUdufbwxJaVgMnV/Lf0qe eCdHSpdPNngnJXZAhmoCLq8qRxHca2i9/et1rAQH4Q7Ntd1Z234/c6/mdLRb/k5h 86Uw13cKNg/3TU2JpraZhxHKY8v/pZOwUopwvPh6HAWO7Y/5srQSwB6mZO8aGSOD LtLT3SzaPW97bKtTZqDk/eeOhIQvVLa+HJY+cwaQCW3AsRqcW+uoL0A9cH0QjJW0 Hc01A2Qrbyg/CW1Cz1ef =1/Wx -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le 12/12/2012 17:33, Jeff Mahoney a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/12/12 11:28 AM, Guillaume Gardet wrote:
Le 12/12/2012 17:19, Jeff Mahoney a écrit : On 12/12/12 11:17 AM, Jeff Mahoney wrote:
On 12/12/12 11:10 AM, Greg Kroah-Hartman wrote:
On Wed, Dec 12, 2012 at 10:59:21AM -0500, Jeff Mahoney wrote: > On 12/12/12 10:07 AM, Greg KH wrote: >> On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume >> Gardet wrote: >>> Hi, >>> >>> please find in attachment a patch to fix armv7 >>> kernel-default config. >>> >>> CONFIG_USB_EZUSB_FX2 must be a module instead of >>> built-in to fix build >> What build problem? This should be resolved properly >> upstream if it is still an issue. I thought I fixed it >> a while ago, if not, please let me know upstream. > Hi Greg - > > Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: > "ezusb_fx1_ihex_firmware_download" > [drivers/usb/serial/whiteheat.ko] undefined! ERROR: > "ezusb_fx1_ihex_firmware_download" > [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: > "ezusb_fx1_set_reset" > [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: > "ezusb_fx1_ihex_firmware_download" > [drivers/usb/serial/keyspan.ko] undefined! > > Somehow the exported symbols aren't being made available > to modules when ezusb is a built-in. Is USB being built as a module? If so, can you add commit 9db72fe6c943852032d9ed863c87e8c02d3cb9da in Linus's kernel tree to your kernel and see if that fixes the issue? It's being queued up right now for the 3.7.1 release and should solve this. If not, it would be great to know. Ah. Perfect. That's the patch I came up with as well. It does fix it. Guillaume -
Your patch is still valid since this will force CONFIG_USB_EZUSB_FX2=m.
I'll commit both and we'll bet set here.
Jeff, My patch was just a workaround to fix the build, then no need to force CONFIG_USB_EZUSB_FX2 to build as a module instead of built-in if not needed. But if it is better (desired/mandatory) to have it as a module, we should fix all the kernel configs using CONFIG_USB_EZUSB_FX2, for consistency. All the configs other than ARM (and vanilla, strange) had =m already to avoid this issue. I just didn't have time to look into it that day. This patch forces all of them to =m. I didn't use your patch directly as I just ran scripts/run_oldconfig.sh after applying the patch to update the configs.
Ok. Thanks a lot. Guillaume
- -Jeff
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQIcBAEBAgAGBQJQyLHvAAoJEB57S2MheeWyjsMP/1qIz0jyrJE9LM2ORoEuy2Bn +A1joy871rKy52lQKbCaQ640A2r1L2vMNLxnSqGI3g5ly+BIuPLn25L6lq4GPHY9 8D1mYe0RS4aFEBb7PM2tfmbku2/y0KUXGWjxmThceIpAGRqKy6XNDtCD9sAOJ6PG lfZHqyFu2WEeVI7Zr9XZLWUk2oYsk1s2J3ySaJX6fmCYVahmZy0lJPcXaJHHDl+1 3QuSOWt4beAGFLOfIIwKKXco5IAy55wPXMDo6zFsXjeNhY+LZcalLmL0M6Pl1zoQ d+lTJJVlxaXueeDYHPorzbbcJYFzb2NolnwSaovE/WwtrcX4FQt+TOTieoNePF84 4twssEre+2N9BFScHQNNqwTPazYZOSr3z+R8V8XW906I+GC2+6gA8sEUr4EMtTzg ZsPNWb5sVL6s3z/IDOUDEVGP0KDJpdjcbOgkEG9/pbInUdufbwxJaVgMnV/Lf0qe eCdHSpdPNngnJXZAhmoCLq8qRxHca2i9/et1rAQH4Q7Ntd1Z234/c6/mdLRb/k5h 86Uw13cKNg/3TU2JpraZhxHKY8v/pZOwUopwvPh6HAWO7Y/5srQSwB6mZO8aGSOD LtLT3SzaPW97bKtTZqDk/eeOhIQvVLa+HJY+cwaQCW3AsRqcW+uoL0A9cH0QjJW0 Hc01A2Qrbyg/CW1Cz1ef =1/Wx -----END PGP SIGNATURE-----
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/12/12 10:59 AM, Jeff Mahoney wrote:
On 12/12/12 10:07 AM, Greg KH wrote:
On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet wrote:
Hi,
please find in attachment a patch to fix armv7 kernel-default config.
CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to fix build
What build problem? This should be resolved properly upstream if it is still an issue. I thought I fixed it a while ago, if not, please let me know upstream.
Hi Greg -
Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!
Somehow the exported symbols aren't being made available to modules when ezusb is a built-in.
$ nm drivers/usb/built-in.o|grep ezusb_fx1_ihex_firmware_download $ nm drivers/usb/misc/built-in.o |grep ezusb_fx1_ihex_firmware_download 00000000d9b16284 A __crc_ezusb_fx1_ihex_firmware_download 0000000000000000 r __kcrctab_ezusb_fx1_ihex_firmware_download 0000000000000021 r __kstrtab_ezusb_fx1_ihex_firmware_download 0000000000000000 r __ksymtab_ezusb_fx1_ihex_firmware_download 00000000000004d0 T ezusb_fx1_ihex_firmware_download That'd do it. Digging a little deeper, it looks like it's because CONFIG_USB_EZUSB_FX2=y is allowed to be a built-in while CONFIG_USB=m. drivers/usb/misc gets built with whatever CONFIG_USB is, so it's treated by drivers/usb as a module and drivers/usb/misc/built-in.o gets ignored. I'll post a fix in a minute. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQyKziAAoJEB57S2MheeWya6kP/iJ3Ju+tT3qN9PVzRRRF4Nlh ztFreKxnZi+XAIPgmEUwnFU6IOGVndRP6Q/j474azPUKNzO6B27eflOLWP9t2yqj Fw0XGCZa1ymTHxUYmvpckwUg1a1iHBnC305GpMs9udWTxYI1xAZIhH3LTowdRNEd he2gH5eq8jb2CNhK5gkN0meRiRRBpo/UeU251HifnEjkchIE5rZZgMxQc0YJkk9w x5JSYKLwfWI1uJfh1yco9DwUsp7BnJEXMdONfbWNDnYsKHN5HQlc+9FxNNUOXUvT sbbxH10ke6jS1AsSGJL3OQPtSbectwp1l/OO5iPbgrqI7sBGYlpi6ho30d1Djgoi ZfjT/bV6cQ3p2Kz2EydGRBnkEH8WrorVVhzU+QXYNmM8+cHFqmn7i3HCxlgFT2Ya rPu/+0o/hWTswJcJORIpuUFLWmo9CaFkJMikUZV5WoWvoP7YK8WxUrF+P6PfW7u2 YoYQkyHU3s8Kw0Ic/YLtMBCepUsWnnn+RmBP08CFw4KgYtQzRpu/nXQhlaWe/8OO 994pcs8m/qg9/V6huk5BLWmK8HRnOBDKcG2pPZd5g6Z7idhTpkd2WQcgY85ymeS5 nZ7D+5mqswspsE+9xVLMVwvkWYeZ+Vhs7ire2UUd0rF7bwpewUM5lccpNW5eZi8a WM0eG6Wve0ygCJ11g2uw =Jeaz -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (4)
-
Greg KH -
Greg Kroah-Hartman -
Guillaume Gardet -
Jeff Mahoney