Hi Jiri,

...

+Patch-mainline: No The reason is missing: Patch-mainline: Submitted,

Alright, updated patch attached.

Am 16.03.2015 um 15:36 schrieb Jeff Mahoney:

On 3/16/15 10:12 AM, Dirk Müller wrote:

...

Hi Jiri,

...

...

...

+Patch-mainline: No The reason is missing: Patch-mainline: Submitted,

...

Alright, updated patch attached.

Almost.

It should read: Patch-mainline: v4.0-rc1 Git-commit: 0156411b1828771c09c92f034e7b81f702b84f07

There also needs to be a References tag indicating which bugzilla report this is fixing.

Also the ARM guys did not suggest or review this backport of yours, http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01... so please place your Signed-off-by in the very bottom, not somewhere in the middle. Using git commit -s makes this very easy. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/16/15 2:35 PM, Dirk Müller wrote:

Hi Jeff,

...

It should read: Patch-mainline: v4.0-rc1 Git-commit: 0156411b1828771c09c92f034e7b81f702b84f07

Thanks, updated accordingly.

Thanks.

...

There also needs to be a References tag indicating which bugzilla report this is fixing.

There is no bugzilla report related to this. Can this be merged without a bugzilla id ? it doesn't seem to be a strict requirement, judging from other patches recently added to the 13.2 tree. This is also a purely arch-specific patch set, noone should see any effect whatsoever on the "important" architectures.

I'd prefer to see one. Like I said earlier in the thread, enforcement of the policies is something we need to get better at doing. I've been pushing my own team to file bugzillas for patches they want included in our kernels even if it was an issue they discovered and fixed themselves. Looking at the 13.2 branch, most recent commits do have the bugzilla references. Master seems to be less consistent. It doesn't need to be a big thing. Just something that documents why you want the patch in. I know why you want the patch in _right now_ but, especially for branches with longer-term maintenance goals, it can be tough to remember why a patch was needed a year or two from now. Thanks, - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJVCHBIAAoJEB57S2MheeWy758P/Ro151/AX77lBhzpBr12LrcG LQOm9qAovJ4YetLjUzyJkSMLFW4uKfYYlF7YID1Bze16Ud6cpO1vo1pfxR7g54s9 Qau3zJu8J1g8UdFMk5XQliYdzL9+rvDhCttZA5S0+DvJEPNWMyvqMbzoIPO3dB2F YImEYv4rYdmeO8coDRsBR0Q8UcdVShi0pxk2WjrQjseDqkSZ/Dh65w6s0JxPt3DP E0ZjGnPHnQm3eFdQt1BT27dVoi0XL+1zigKOMCTACpJH/Mje1o0Q+aHpcyAr2WBB z4t4g9Et+RzifUMBh4JLNcmxTcwJCkx5C/Hq1SO6Q51B6p3UROZ1Kj5rWvTdxcGe fuAVSRDgn47yWlrNVWpH7Yf3GFGYJ5lr4WEK8fFxMhYtCSitbew6lt0J4HYgjeYz 53FizmwrkMQ5fy0gb1ZeGkvGyiyEo1msJAcHrzHRhRfmRq1ely5G292cmpdylczn i4FYdMnEgVeC6z4aIAMolkdRJzZtqqL7BoQm27rIEatthSC6Ys809VG3lHNDzoRj /yn1Adk+QR2Zu4WHEJpjAbogDXiofqI5bzHrstBWSMxbH2b1vUoFZaPb3OXxV3Dr 4S/wMSDH0X++RKfZryfuJzAq0+BGf07C/nmI1RXyHhw0Cq8b1IncyYKDyslXShDR qXcffG5R8N5S+V4S1HBK =BnQn -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

On 21.03.15 16:47, Dirk Müller wrote:

Hi Jeff,

...

...

also a purely arch-specific patch set, noone should see any effect whatsoever on the "important" architectures. I'd prefer to see one.

Here's the updated patch set for openSUSE-13.2 with a references line.

Thanks, applied to the openSUSE-13.2 branch. Alex -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Am 21.03.2015 um 18:04 schrieb Jeff Mahoney :

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

...

On 3/21/15 11:47 AM, Dirk Müller wrote: Hi Jeff,

...

...

also a purely arch-specific patch set, noone should see any effect whatsoever on the "important" architectures. I'd prefer to see one.

Here's the updated patch set for openSUSE-13.2 with a references line.

Thanks, Dirk.

Since Alex already applied, we're all set.

The patch for stable is still missing, I'm waiting for verification from Dirk that it definitely runs on real hardware ;). Expect to see it on the stable branch tomorrow. Alex -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

On 21.03.15 19:29, Dirk Müller wrote:

Hi,

...

The patch for stable is still missing, I'm waiting for verification from Dirk that it definitely runs on real hardware ;). Expect to see it on the stable branch tomorrow.

It does run on real hardware, just finished testing (will fix the zypper issues now).

Awesome, applied to stable branch as well. Alex -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org