-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4/28/14, 4:23 AM, Jan Beulich wrote:

...

...

...

On 27.04.14 at 22:18, wrote: Can you take a quick look at this? I don't have any 32-bit x86 machines to test with (or more accurately, I don't really want to have a 32-bit install *just* to test this.)

The 32-bit builds are failing because of the removal of FIX_VDSO and I'd rather not "fix" it with the wrong thing.

Conceptionally it looks right, but I suppose this wasn't compile tested and/or is stale, because ...

Yep, I was just looking to confirm I got the general idea right as this code is /way/ outside my typical area of experience. :)

...

--- a/arch/x86/include/asm/unwind.h +++ b/arch/x86/include/asm/unwind.h @@ -141,8 +141,9 @@ static inline int arch_unw_user_mode(/*c #else return user_mode_vm(&info->regs) || info->regs.ip < PAGE_OFFSET - || (info->regs.ip >= __fix_to_virt(FIX_VDSO) - && info->regs.ip < __fix_to_virt(FIX_VDSO) + PAGE_SIZE) + || (info->mm->context.vdso && + info->regs.ip >= info->mm->context.vdso && + info->regs.ip < info->mm_context.vdso + vdso32_size)

... struct unwind_frame_info has no member "mm" or "mm_context", and the patch also doesn't add one. Depending on what your intentions here really were, ->mm (or, if you meant info->task->mm->, ->task and ->task->mm) may additionally need checking to be non-NULL here.

Ok, thanks. That's easy enough.

Additionally I think this tells us that we may need to adjust older trees in this way too, to account for the VDSO_ENABLED case.

Yeah, it looks that way. I'd imagine the final patch should be a pretty easy backport if we want to bother with it. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTXkgqAAoJEB57S2MheeWydyEQAJjXm83025DEQVValzi9WSBu va6mQFvXjQi5eW2oXqFoV7LhxefV7rgLhS/HyrqV+VtBwtYvsLfD6/mC/f/i0+jX wedNZWf8sda2qOCndC/T+kYhvIuR6dYxtWkBkRYUqDQlVihGYM3O6MfWbVmceAh+ VHLEe3r+sG0l9XiO7AbsNWR36RLNXDUlCZZTrPYemN8pYGZ+cYigJ0p2UyCyAWRi c8uB4bUkjxqbmhBOe4LJvMjTw/8zpPdv2551/vT7dfTrqzNToeIwIdJ0eCJtdJOG eS1Uw5NFx89A71HeeJrYQBdbR6hSl8qjwJ3ZG4DfJvHPetbfeGcrQgEi1Dlh5dzK nV8kFSg+TwjZwSQKAP/uussCwRDnbbOMcMVQFM/w6jmhtLzgLJuxlwrqQPHg4Uo5 lez858u2+rKV+WHBIA+GEoFf3jNgHZNBl/sxmjKn4vMxOaB1m+b50I9Wb4GylAqB jYPo6bYmMObxu1r1Qbo5bWOrepaR/LVEF/lDtxPFi6D5X+TidxOEzURPbBg7yuYf zuQ0vP65nMuBzE+s7GH9fSJzAQVoklOuYUl/4iVcT2bmfiOtSUpLFH+Ai1JfGfGG 5sj4SNCE17S1soqJv3SpoEM1gwnCTq/mzMkMPiyq6S2P2qMhuv0DpvkirApeyvKp +s+EkjiZW+9qej+l92/j =KEI/ -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org