Make CONFIG_SCSI and co back to modules for TW
Hi, currently TW stable and master branches have the core SCSI and AHCI code built-in, i.e. CONFIG_SCSI=y, CONFIG_ATA=y and CONFIG_SATA_AHCI=y. IIRC, this was set so in *decades* ago, and the reason was "just for booting faster"; at that time, making it built-in had measurable difference. Meanwhile, it's no longer issue with modern hardware. And, more importantly, such built-in config has a side-effect as we've seen recently at: https://bugzilla.suse.com/show_bug.cgi?id=1215182 where TW kernel can't boot properly because of the failure of SSD probe due to the built-in SCSI / AHCI drivers. Does anyone object to switch back to modules? This will align with SLE configuration, and it automagically "fixes" such bugs. thanks, Takashi
On 9/12/23 18:14, Takashi Iwai wrote:
Hi,
currently TW stable and master branches have the core SCSI and AHCI code built-in, i.e. CONFIG_SCSI=y, CONFIG_ATA=y and CONFIG_SATA_AHCI=y.
IIRC, this was set so in *decades* ago, and the reason was "just for booting faster"; at that time, making it built-in had measurable difference. Meanwhile, it's no longer issue with modern hardware. And, more importantly, such built-in config has a side-effect as we've seen recently at: https://bugzilla.suse.com/show_bug.cgi?id=1215182
where TW kernel can't boot properly because of the failure of SSD probe due to the built-in SCSI / AHCI drivers.
Does anyone object to switch back to modules? This will align with SLE configuration, and it automagically "fixes" such bugs.
Is it still on? Please, revert it. The original idea was to have it built-in for virtual machines, with the hope to boot virtual machines without an initrd. Never really materialized, but the config stayed on. Please, go ahead. Cheers, Hannes
On 12. 09. 23, 18:14, Takashi Iwai wrote:
Hi,
currently TW stable and master branches have the core SCSI and AHCI code built-in, i.e. CONFIG_SCSI=y, CONFIG_ATA=y and CONFIG_SATA_AHCI=y.
IIRC, this was set so in *decades* ago, and the reason was "just for booting faster"; at that time, making it built-in had measurable difference. Meanwhile, it's no longer issue with modern hardware. And, more importantly, such built-in config has a side-effect as we've seen recently at: https://bugzilla.suse.com/show_bug.cgi?id=1215182
where TW kernel can't boot properly because of the failure of SSD probe due to the built-in SCSI / AHCI drivers.
Does anyone object to switch back to modules? This will align with SLE configuration, and it automagically "fixes" such bugs.
+1 for aligning. thanks, -- js suse labs
On Tue, 12 Sep 2023 18:14:18 +0200, Takashi Iwai wrote:
Hi,
currently TW stable and master branches have the core SCSI and AHCI code built-in, i.e. CONFIG_SCSI=y, CONFIG_ATA=y and CONFIG_SATA_AHCI=y.
IIRC, this was set so in *decades* ago, and the reason was "just for booting faster"; at that time, making it built-in had measurable difference. Meanwhile, it's no longer issue with modern hardware. And, more importantly, such built-in config has a side-effect as we've seen recently at: https://bugzilla.suse.com/show_bug.cgi?id=1215182
where TW kernel can't boot properly because of the failure of SSD probe due to the built-in SCSI / AHCI drivers.
Does anyone object to switch back to modules? This will align with SLE configuration, and it automagically "fixes" such bugs.
JFYI: we received only positive results, and now it's corrected on stable and master branches. Takashi
participants (3)
-
Hannes Reinecke -
Jiri Slaby -
Takashi Iwai