[opensuse-kernel] [PATCH] ARM64: Adjust xkbe-a0 driver to Kernel 4.0
Signed-off-by: Dirk Mueller
Hi Dirk, Am 13.03.2015 um 17:52 schrieb Dirk Müller:
Signed-off-by: Dirk Mueller
---
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++
series.conf | 1 +
2 files changed, 35 insertions(+)
create mode 100644 patches.arch/arm64-0008-adjust-to-kernel-4.0
It looks to me as if instead an earlier patch in that series should be updated? Regards, Andreas P.S. I always thought those arm64 patches were 13.2 only... -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/13/15 12:58 PM, Andreas Färber wrote:
Hi Dirk,
Am 13.03.2015 um 17:52 schrieb Dirk Müller:
Signed-off-by: Dirk Mueller
---
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++
series.conf | 1 +
2 files changed, 35 insertions(+)
create mode 100644 patches.arch/arm64-0008-adjust-to-kernel-4.0
It looks to me as if instead an earlier patch in that series should be updated?
What we'd prefer to see is patches that match upstream or, at the very least, patches that match a repository that is a maintainer branch leading to mainline inclusion[1]. This patchset has patches that just say things like "no" and "never" for Patch-mainline without any explanation as to why. It seems we need to be a bit more vigilant with our policy enforcement.
P.S. I always thought those arm64 patches were 13.2 only...
As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope. - -Jeff [1] Annotated with Git-repo tags - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJVBvbHAAoJEB57S2MheeWy2/AP/0OzVE9skLeRcKHzPoMjVnga VLeEWJTPnt8Vp7zreyrhMZ+egGf/i0VnKPRyiXDHShQHP/L3toAjgPj4Rev8mAMG D5bdNjlNaJj8NkD+M2A4M66jKQPdI/5L0VDCTZmjnl5o7//IeZjNVyLX3XShCbMn Z2OrRno2t+cBLTLI+ashSyv+UlOtjvZNXMoWoNng9Gupfg0FMbSsw2fOu/cFqwtJ f4jf1iBQWSGsML/ZgsjrahAYIfVk+ekbd7wdACXJ9pF1HvzckBTxpFCd1Wg72TDQ v8qanlQeEp6KXHcDSHTCS85YfwzQB1VabsPhKbIC6tWtHT/GEu+X5oN4z09ur9sa oedMMtQ1kmEcaJPFlORi/tg/5Pl9hOkAFpuBcaR+MnP16P+xieS90FjuRNQiDTIR bd1IfLwH8+BDYr1ajT0wIov3IaclosD7crH4O7lN2Mgg2VUBp4hYvZVi4oUUyI3/ DhPPIf2Sx9oG9sLCEHS6ucTrp4B79Ky6LV9MSnpohpGuezKPi9HA1P1Q798ca0eR h43RO+0i3IMHn/20YvPib+eSh6Koy9kcu/Mwa8Lvs6rmcW5xjXX50cWXho394dYm DQQG2uhIVTO49IOUJCWXxheqEzMPxT+xbuOBTZL260ey9cWJdYBTy2VEQOa7hNlK CdU7viAJt9g21Gdph+WG =el+L -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 16.03.2015 um 16:29 schrieb Jeff Mahoney:
On 3/13/15 12:58 PM, Andreas Färber wrote:
Am 13.03.2015 um 17:52 schrieb Dirk Müller:
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++ It looks to me as if instead an earlier patch in that series should be updated?
What we'd prefer to see is patches that match upstream or, at the very least, patches that match a repository that is a maintainer branch leading to mainline inclusion[1]. This patchset has patches that just say things like "no" and "never" for Patch-mainline without any explanation as to why. It seems we need to be a bit more vigilant with our policy enforcement.
P.S. I always thought those arm64 patches were 13.2 only...
As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope.
AFAIU agraf prepared a patchset to backport arm64 PCI/network for 13.2, so that people have a usable stable release for Mustang and Seattle with our 3.16 kernel. Makes sense to me. So yes, I am surprised that non-mainline patches end up on master branch as opposed to just waiting until final patches trickle through maintainers' trees into linux.git and the next -rc or tarball. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/16/15 11:45 AM, Andreas Färber wrote:
Am 16.03.2015 um 16:29 schrieb Jeff Mahoney:
On 3/13/15 12:58 PM, Andreas Färber wrote:
Am 13.03.2015 um 17:52 schrieb Dirk Müller:
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++ It looks to me as if instead an earlier patch in that series should be updated?
What we'd prefer to see is patches that match upstream or, at the very least, patches that match a repository that is a maintainer branch leading to mainline inclusion[1]. This patchset has patches that just say things like "no" and "never" for Patch-mainline without any explanation as to why. It seems we need to be a bit more vigilant with our policy enforcement.
P.S. I always thought those arm64 patches were 13.2 only...
As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope.
AFAIU agraf prepared a patchset to backport arm64 PCI/network for 13.2, so that people have a usable stable release for Mustang and Seattle with our 3.16 kernel. Makes sense to me.
So yes, I am surprised that non-mainline patches end up on master branch as opposed to just waiting until final patches trickle through maintainers' trees into linux.git and the next -rc or tarball.
For hardware enablement, I get it. If people have hardware in hand, it can be bothersome to wait for the wheels to turn. In that case, I want to see mailing list references for the patches. Even if we're the ones doing the development, the work should still be public enough that references are available. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJVBvwZAAoJEB57S2MheeWyo8UP/ikKOgpQLG5v3pvWybND4UO/ grUZDN92wIEQkgyW0OUAIKDY13406SlEaJ1nmAERmx4+Zlu6NvPiS934ymt9bRiO XUi0iDbYyQD1Y6zbRd3vHWR3ixKJhUYq060yWzXC2hJLB3tuTGg2+WnxE/YktUB2 BEUtnAmIRH/Y/O/Z+Qi3Z2LpgRFh70Fy7+Toeiwbs7GP0HepJLgYMRtDjclTRCLe YJJzJq8JZF3qzSzoiQCpv9cKYIAOwzPV9EVtD382HiV6N9XhRb9L4vCaj/DWGK5t 9jMfkagRkwzdiCkv1YpjV1BQjzj3eXixMHKwXNUB3L+einmmaMy3vZCn9bL9Kf89 H/5cRTgj3eEcNv7kfp6bhrWhlLrHONbLz163pKD30B7LfrPYdNcg+Nb3vdH/z4lu qfk2g/R4uqaxQRp/FdcYtdEIo9F88Hq0pXfd35lzCE5s/JutOTYs/B7urBoABrQS TRe1XoPa7AnSuSpvXLHiUQZG9OSJaM96aaN7Gg0s7E7ZXH3OCm5o7IOFLjStgAf2 eir8AvaBImttAtZNyb4xhhnT7/mUI7r7YN1s/duqToSqOi7Lqa8IwIva8Kbta3ZS NOOD79/dmhD6yZh072BB/0Oemu3Km12A9FQsQNMTPUmWXijii43UhjaTRHoxZfBv ZTseJtKuJisTQ14tj4Nu =e1c8 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 16.03.15 11:51, Jeff Mahoney wrote:
On 3/16/15 11:45 AM, Andreas Färber wrote:
Am 16.03.2015 um 16:29 schrieb Jeff Mahoney:
On 3/13/15 12:58 PM, Andreas Färber wrote:
Am 13.03.2015 um 17:52 schrieb Dirk Müller:
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++ It looks to me as if instead an earlier patch in that series should be updated?
What we'd prefer to see is patches that match upstream or, at the very least, patches that match a repository that is a maintainer branch leading to mainline inclusion[1]. This patchset has patches that just say things like "no" and "never" for Patch-mainline without any explanation as to why. It seems we need to be a bit more vigilant with our policy enforcement.
P.S. I always thought those arm64 patches were 13.2 only...
As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope.
AFAIU agraf prepared a patchset to backport arm64 PCI/network for 13.2, so that people have a usable stable release for Mustang and Seattle with our 3.16 kernel. Makes sense to me.
So yes, I am surprised that non-mainline patches end up on master branch as opposed to just waiting until final patches trickle through maintainers' trees into linux.git and the next -rc or tarball.
For hardware enablement, I get it. If people have hardware in hand, it can be bothersome to wait for the wheels to turn. In that case, I want to see mailing list references for the patches. Even if we're the ones doing the development, the work should still be public enough that references are available.
It's complicated for the xgbe-a0 driver. That one was basically a downstream patch on top of the upstream b0 driver. AMD's idea was that nobody should eventually have a0 hardware in their hands once b0 silicon is out, so the driver wasn't worth pushing upstream. I think we're still stuck keeping it alive downstream for a little while, but over time it will just disappear. Meanwhile we need it though to support the hardware we (and early adopters) have. Alex -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/16/15 12:37 PM, Alexander Graf wrote:
On 16.03.15 11:51, Jeff Mahoney wrote:
On 3/16/15 11:45 AM, Andreas Färber wrote:
Am 16.03.2015 um 16:29 schrieb Jeff Mahoney:
On 3/13/15 12:58 PM, Andreas Färber wrote:
Am 13.03.2015 um 17:52 schrieb Dirk Müller:
patches.arch/arm64-0008-adjust-to-kernel-4.0 | 34 ++++++++++++++++++++++++++++ It looks to me as if instead an earlier patch in that series should be updated?
What we'd prefer to see is patches that match upstream or, at the very least, patches that match a repository that is a maintainer branch leading to mainline inclusion[1]. This patchset has patches that just say things like "no" and "never" for Patch-mainline without any explanation as to why. It seems we need to be a bit more vigilant with our policy enforcement.
P.S. I always thought those arm64 patches were 13.2 only...
As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope.
AFAIU agraf prepared a patchset to backport arm64 PCI/network for 13.2, so that people have a usable stable release for Mustang and Seattle with our 3.16 kernel. Makes sense to me.
So yes, I am surprised that non-mainline patches end up on master branch as opposed to just waiting until final patches trickle through maintainers' trees into linux.git and the next -rc or tarball.
For hardware enablement, I get it. If people have hardware in hand, it can be bothersome to wait for the wheels to turn. In that case, I want to see mailing list references for the patches. Even if we're the ones doing the development, the work should still be public enough that references are available.
It's complicated for the xgbe-a0 driver. That one was basically a downstream patch on top of the upstream b0 driver. AMD's idea was that nobody should eventually have a0 hardware in their hands once b0 silicon is out, so the driver wasn't worth pushing upstream.
I think we're still stuck keeping it alive downstream for a little while, but over time it will just disappear. Meanwhile we need it though to support the hardware we (and early adopters) have.
Ok, makes sense. This is exactly the sort of thing that should go in the patch/commit, though. :) - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJVBxx5AAoJEB57S2MheeWyD8YP/RvlPnaHGw3X/kyYPyYR986u FRsqiPL0rGZfIEAGl6mudddAiq+YbRsYWPvDC79SzOEWtDgMHfw+7Tp4IedgXoqg M9sfyc5daCPkC6FFM16UUTREOoKaRJdiiLW1o7Ljaj7Rd+v3hgwC1vpyBmDwaPKJ +r7QmJ27IlmNANmOKsCeqNyq/YSBI8ON/t2ceOKzR23Y63KAfz0IXK1+Gvowp0lg /84Rw18YC8WLsTMmH0po7pDpmZIgmtfnfftjH6gz0n1stRcyFkuHarNO9SdRqS0/ 6wC1tDDWEpdufFgPVogfOxQggDqxydM0E+8PIaAqzrm2guGRYdpkQry0sEP5wQW+ 6LEZNSJS1VyK0i6JxuUUo9KCDC7uulj20+fCvYlYg9JP5r5qS2UzHYuG0wYCiDbz JAAzssbjG+8w0nW3JISy1g563Y1Y+kbr22SDG87Rm1e187iq8oChXhwZ1mCB4NUj nZW5EXMrZ3nQBvN32HWYCMb+Cw5DcthhasgJ2s92XRs7ghXxxtNn4kyFs9XeIZB3 ZVS7SSaFQOkqAY1NpVvuOz8UNjtBdy6pvrjty1lyP8/Ul63KaQxW7HBlGUqAcCON XBqJSQJhUHsGEBLlOlqJ4uRZ2+Vzzu8+lac1NUGAZmSp+9AgldYgvReETYC9Yn6J 5p4qoufjnbQ51K4S5SYc =pZKA -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jeff,
P.S. I always thought those arm64 patches were 13.2 only... As opposed to the master branch or something else? I'd expect that anything in an older openSUSE release would still be supported in a newer one unless the hardware is going out of scope.
Yes, we still need that patchset as long as there are still users of A0 silicon. I'd suggest to drop the patches in a year from now on earliest. Does the patch below suffice? Tia, Dirk
participants (4)
-
Alexander Graf -
Andreas Färber -
Dirk Müller -
Jeff Mahoney