[opensuse-factory] Contrib: Packages Review: "banner"
Hi All, Next package, "banner" - ASCII Art text renderer Description: Banner fills an apparent hole in Linux - that is, that is does not provide a "banner" program itself, while nearly all UNIX systems seem to do so. Banner prints a "banner" on the screen that corresponds to the first 10 characters of a string entered on the command line, in a way similar to what you might see when using Solaris or AIX. There are fancier things out there, but this is nice and simple. This package is in OBS. Current maintainer: me (Alexey Eromenko "Technologov") URL http://www.cedar-solutions.com/software.html License: GPL Latest update: Wasn't updated for long time. Program is feature complete, and doesn't need updating. OBS URL: http://download.opensuse.org/repositories/home:/FenixNBK/openSUSE_11.0/ Testing: Package received testing from me 10.2/10.3/11.0 (32-bit) =============================================== What do you think of the package? -- -Alexey Eromenko "Technologov" --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, Alexey Eremenko wrote:
"banner" - ASCII Art text renderer
You mean, like "banner", the ASCII Art text renderer in the package bsd-games? regards, Andreas --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Alexey Eremenko wrote:
"banner" - ASCII Art text renderer
You mean, like "banner", the ASCII Art text renderer in the package bsd-games?
In bsd-games it prints in vertical letters. This one uses horizontal. It is similar but not the same. -- -Alexey Eromenko "Technologov" --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Alexey Eremenko wrote:
Alexey Eremenko wrote:
"banner" - ASCII Art text renderer You mean, like "banner", the ASCII Art text renderer in the package bsd-games?
In bsd-games it prints in vertical letters. This one uses horizontal. It is similar but not the same.
But there's kind of conflict between /usr/games/banner and your /usr/bin/banner. Michal --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
mmarek wrote:
But there's kind of conflict between /usr/games/banner and your /usr/bin/banner.
Yes, unfortunately... We need to think how-to resolve that... Maybe we can ask to rename "/usr/games/banner" to "vbanner" (vertical banner) ? Or rename this one to "hbanner" ? (I don't like this idea) Any ideas for resolution of conflict ? -- -Alexey Eromenko "Technologov" --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Alexey Eremenko wrote:
mmarek wrote:
But there's kind of conflict between /usr/games/banner and your /usr/bin/banner.
Yes, unfortunately... We need to think how-to resolve that...
Maybe we can ask to rename "/usr/games/banner" to "vbanner" (vertical banner) ? Or rename this one to "hbanner" ? (I don't like this idea)
Any ideas for resolution of conflict ?
I don't know, perhaps just note in the package description that the package "shadows" /usr/games/banner will suffice. Michal --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
In bsd-games it prints in vertical letters. This one uses horizontal. It is similar but not the same.
BTW, I am maintaining figlet. If it is run with right options, it should behave like banner. So maybe just one new alias instead of new package would be enough :-) Anicka --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Anicka Bernathova escribió:
BTW, I am maintaining figlet. If it is run with right options, it should behave like banner. So maybe just one new alias instead of new package would be enough :-)
That will be a much better solution ;) -- "A computer is like an Old Testament god, with a lot of rules and no mercy. " Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/
On Mon, Sep 1, 2008 at 12:43 PM, Anicka Bernathova
In bsd-games it prints in vertical letters. This one uses horizontal. It is similar but not the same.
BTW, I am maintaining figlet. If it is run with right options, it should behave like banner. So maybe just one new alias instead of new package would be enough :-)
Maybe. Yes "figlet" is very nice tool. How to make it render like "banner" ? Can it render in vertical ? (like /usr/games/banner from "bsd-games") Speaking of descriptions. banner Description : Banner fills an apparent hole in Linux - that is, that is does not provide a "banner" program itself, while nearly all UNIX systems seem to do so. Banner prints a "banner" on the screen that corresponds to the first 10 characters of a string entered on the command line, in a way similar to what you might see when using Solaris or AIX. There are fancier things out there, but this is nice and simple. figlet Description : FIGlet can create characters in many different styles and can kern and "smush" these characters together in various ways. FIGlet output is generally reminiscent of the sort of "signatures" many people like to put at the end of e-mail and UseNet messages. Speaking of descriptions, one from banner looks more serious in my opinion. Which description do you like better ? Should we try to improve description of "figlet" ? -- -Alexey Eromenko "Technologov" --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
So - speaking of "banner". Can we have "figlet" render similarly to banner ? -- -Alexey Eromenko "Technologov" --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Alexey Eremenko escribió:
=============================================== What do you think of the package?
Evaluation : a) SPEC file contains redundant definitions b) an incorrect "BuildRoot" is used c) it has pointless buildrequires d) RPM_BUILD_ROOT is used during %build e) package is built without RPM_OPT_FLAGS f) RPM_BUILD_ROOT is deleted during %install. g) autotools files have to be regenerated because they are too old and errors happend during %configure h) Group: Text tools does not exist, Productivity/Text/Utilities may be more adecuate. i) potentially nasty compiler warnings : implicit declaration of function... Well. it obviosuly does not comply with policies, I fixed all the mentioned problems. but you should try to test it better in the future ;-P -- "A computer is like an Old Testament god, with a lot of rules and no mercy. " Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/
On Thu, 28 Aug 2008, Cristian Rodríguez wrote:
What do you think of the package?
Evaluation :
a) SPEC file contains redundant definitions
b) an incorrect "BuildRoot" is used
c) it has pointless buildrequires
d) RPM_BUILD_ROOT is used during %build
e) package is built without RPM_OPT_FLAGS
f) RPM_BUILD_ROOT is deleted during %install.
g) autotools files have to be regenerated because they are too old and errors happend during %configure
h) Group: Text tools does not exist, Productivity/Text/Utilities may be more adecuate.
i) potentially nasty compiler warnings : implicit declaration of function...
Well. it obviosuly does not comply with policies, I fixed all the mentioned problems. but you should try to test it better in the future ;-P
Thanks for the review, I know I make some of the same mistakes. It would
be good if we could document a proper set of these on a wike page that
could be referenced. I know I see a lot of packages on the BS with
similar mistakes. I think it could be very useful to have a few packages
documented in what would be a correct fashion. An example of good or
proper methods for the various cagetories like languages, configure,
devel, doc, libs... That way we could refer people to them to get ideas
on how to fix their stuff. Maybe this is more a BS issue but I still
think it would be good.
--
Boyd Gerber
Le jeudi 28 août 2008, à 18:34 -0600, Boyd Lynn Gerber a écrit :
Thanks for the review, I know I make some of the same mistakes. It would be good if we could document a proper set of these on a wike page that could be referenced. I know I see a lot of packages on the BS with similar mistakes. I think it could be very useful to have a few packages documented in what would be a correct fashion. An example of good or proper methods for the various cagetories like languages, configure, devel, doc, libs... That way we could refer people to them to get ideas on how to fix their stuff. Maybe this is more a BS issue but I still think it would be good.
If it's not in http://en.opensuse.org/SUSE_Package_Conventions then it should be added there. (reviewing packages is actually a good way to improve our package conventions) Vincent -- Les gens heureux ne sont pas pressés. --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, 29 Aug 2008, Vincent Untz wrote:
Le jeudi 28 août 2008, à 18:34 -0600, Boyd Lynn Gerber a écrit :
Thanks for the review, I know I make some of the same mistakes. It would be good if we could document a proper set of these on a wike page that could be referenced. I know I see a lot of packages on the BS with similar mistakes. I think it could be very useful to have a few packages documented in what would be a correct fashion. An example of good or proper methods for the various cagetories like languages, configure, devel, doc, libs... That way we could refer people to them to get ideas on how to fix their stuff. Maybe this is more a BS issue but I still think it would be good.
If it's not in http://en.opensuse.org/SUSE_Package_Conventions then it should be added there.
(reviewing packages is actually a good way to improve our package conventions)
+1, but reading that leaves me still needing a good example. I am a very
visual person and I do not always get the information correct in my mind.
I have to see it used properly to really understand. I have in my mind
pages. I see a paper with the words on it. Trying to get the url with
that into a page I sometimes have problems. But I think it would be good
to have samples to reference as a good check. But we really do need to
keep what documentation we have up to date.
We also need manuals for the BS. As in an other thread.
Thanks,
--
Boyd Gerber
participants (7)
-
Alexey Eremenko -
Andreas Stieger -
Anicka Bernathova -
Boyd Lynn Gerber -
Cristian Rodríguez -
Michal Marek -
Vincent Untz