[opensuse-factory] apache -- align binary names to upstream ones
Hello list, I think the best resolution of bug 873674[0] would be to deprecate/remove binary names like apache2ctl, split-logfile2 and even logresolve.pl2. Please find proposal in sr#308904[1] and file list diff in the attachement. Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know. Thanks! Petr [0] https://bugzilla.suse.com/show_bug.cgi?id=873674 [1] https://build.opensuse.org/request/show/308904
On 2015-05-27 14:09:11 +0200, Petr Gajdos wrote:
I think the best resolution of bug 873674[0] would be to deprecate/remove binary names like apache2ctl, split-logfile2 and even logresolve.pl2.
Please find proposal in sr#308904[1] and file list diff in the attachement.
Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know.
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need. darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Wed, May 27, 2015 at 02:20:16PM +0200, Marcus Rueckert wrote:
Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know.
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need.
Done. See the new sr#308921 and new file list diff. Thanks! Petr
On 2015-05-27 15:29:37 +0200, Petr Gajdos wrote:
On Wed, May 27, 2015 at 02:20:16PM +0200, Marcus Rueckert wrote:
Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know.
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need.
Done. See the new sr#308921 and new file list diff.
the missing man page symlinks are on purpose or are they handled via some man magic? darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Wed, May 27, 2015 at 04:32:17PM +0200, Marcus Rueckert wrote:
On 2015-05-27 15:29:37 +0200, Petr Gajdos wrote:
Done. See the new sr#308921 and new file list diff.
the missing man page symlinks are on purpose or are they handled via some man magic?
From the question I feel your wish to have them there :). sr#308921 is superseeded by sr#308949. Petr
Hello, Am Mittwoch, 27. Mai 2015 schrieb Petr Gajdos:
On Wed, May 27, 2015 at 02:20:16PM +0200, Marcus Rueckert wrote:
Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know.
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need. Done. See the new sr#308921 and new file list diff.
Much better (and basically what I told you on IRC already ;-) BTW: -/usr/share/apache2/find_httpd2_includes +/usr/share/apache2/find_httpd_includes Besides the question if there should be a compat symlink for this, the script itsself looks buggy ;-) for i in $found; do case $i in *\**) # filter filenames that are unexpanded, in the lack of a match, # like /etc/apache2/conf.d/*.conf ;; *) conffiles="$conffiles $i" find_include_files $i ;; esac done This can fail for at least two reasons: a) someone might really use a filename like foo*.conf (with a literal *) and the code above would filter it out. (Yes, I know that it might be a good idea to blame the person who created a file with such a name ;-) b) apache also supports ? as wildcard (commonly used for "don't explode if the include file doesn't exist"), and the script doesn't filter for that The better and easier solution is a simple test -f "$i" which will give you the correct result regardless of the filename. Oh, and I don't really want to know what happens - for filenames with spaces (quotes? spliting $found and $conffiles again?) - on circular / recursive includes ;-) Regards, Christian Boltz --
Programmieren in C++ hält die grauen Zellen am Leben. Es schaerft alle fuenf Sinne: den Schwachsinn, den Bloedsinn, den Wahnsinn, den Unsinn und den Stumpfsinn. [Felix von Leitner und Holger Veit in doc]
-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Christian, On Wed, May 27, 2015 at 11:04:55PM +0200, Christian Boltz wrote:
Am Mittwoch, 27. Mai 2015 schrieb Petr Gajdos:
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need. Done. See the new sr#308921 and new file list diff.
Much better (and basically what I told you on IRC already ;-)
I know, that's why I wouldn't resist anymore :-].
-/usr/share/apache2/find_httpd2_includes +/usr/share/apache2/find_httpd_includes
Besides the question if there should be a compat symlink for this, the script itsself looks buggy ;-)
Maybe a candidate to drop? In general, if the script is buggy and there is no bugreport, it is not used anymore. I met another incorrect script by the way, try log_server_status (CPULoad seems not to be part of /server-status/?auto anymore). By the way, this is the reason why I didn't want to make compat symlinks everywhere by default. If there would be bugreport I would have an evidence that it is really used somewhere. Nevertheless, fixing scripts is not part of this change.
for i in $found; do case $i in *\**) # filter filenames that are unexpanded, in the lack of a match, # like /etc/apache2/conf.d/*.conf ;; *) conffiles="$conffiles $i" find_include_files $i ;; esac done
This can fail for at least two reasons:
a) someone might really use a filename like foo*.conf (with a literal *) and the code above would filter it out. (Yes, I know that it might be a good idea to blame the person who created a file with such a name ;-) b) apache also supports ? as wildcard (commonly used for "don't explode if the include file doesn't exist"), and the script doesn't filter for that
The better and easier solution is a simple test -f "$i" which will give you the correct result regardless of the filename.
Oh, and I don't really want to know what happens - for filenames with spaces (quotes? spliting $found and $conffiles again?) - on circular / recursive includes ;-)
.. please submit bug report or better submit request to not get lost. Petr
participants (3)
-
Christian Boltz -
Marcus Rueckert -
Petr Gajdos