[opensuse-factory] Re: [opensuse] Re: system scripts using BASHism's but invoked as "#!/bin/sh"
Per Jessen wrote:
Linda Walsh wrote:
Werner Flamme wrote:
Linda Walsh [24.01.2013 09:42]:
I'm constantly seeing system scripts starting with #!/bin/sh yet I'll see "BASHism's" in the script. Why don't you open a ticket (or one per script) at the bugzilla?
Why would you suggest such a huge waste of time?
Just _a_ bug report.
---- Far more reasonable: Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
* Linda Walsh
Per Jessen wrote:
Linda Walsh wrote:
Werner Flamme wrote:
Linda Walsh [24.01.2013 09:42]:
I'm constantly seeing system scripts starting with #!/bin/sh yet I'll see "BASHism's" in the script. Why don't you open a ticket (or one per script) at the bugzilla?
Why would you suggest such a huge waste of time?
Just _a_ bug report.
---- Far more reasonable:
Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used
checkbashisms and dash -n are already run on every script of a package through rpmlint (actually for about three years now). So if you see a "bin-sh-syntax-error" or "potential-bashisms" warning in the build logs, feel free to send srs fixing them. Automatically changing the shebang is not possible, the above checks are just too unreliable for that. -- Guido Berhoerster -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Linda Walsh wrote:
Per Jessen wrote:
Just _a_ bug report.
---- Far more reasonable:
Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used
https://bugzilla.novell.com/show_bug.cgi?id=800607
https://bugzilla.novell.com/show_bug.cgi?id=800607#c1
Guido Berhörster
El 25/01/13 18:42, Linda Walsh escribió:
=================== CLOSED/INVALID.... and you wonder why I think filing bug reports is a waste of time.
That's because this bug IS invalid.. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Friday 2013-01-25 22:42, Linda Walsh wrote:
Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used
CLOSED/INVALID.... and you wonder why I think filing bug reports is a waste of time.
Because they are already scanned. Now, if the package maintainer does not actually pay attention to rpmlint, you should name the particular shell scripts you found which threw errors as a result of attempting to process bash commands in a POSIX-behaving sh. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Jan Engelhardt wrote:
On Friday 2013-01-25 22:42, Linda Walsh wrote:
Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used CLOSED/INVALID.... and you wonder why I think filing bug reports is a waste of time.
Because they are already scanned.
The scanning is broken. [[]] are not part of posix and the claim is it is also run through a syntax check in dash. Trying to use arrays or [[]] in dash result in syntax errors. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
В Fri, 25 Jan 2013 17:24:36 -0800
Linda Walsh
Jan Engelhardt wrote:
On Friday 2013-01-25 22:42, Linda Walsh wrote:
Bug 800607 Submitted system scripts should be scan'ed for bashims, and have 1st line update to bash if used CLOSED/INVALID.... and you wonder why I think filing bug reports is a waste of time.
Because they are already scanned.
The scanning is broken.
Then open bug report for this script.
[[]] are not part of posix and the claim is it is also run through a syntax check in dash.
Trying to use arrays or [[]] in dash result in syntax errors.
-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (5)
-
Andrey Borzenkov -
Cristian Rodríguez -
Guido Berhoerster -
Jan Engelhardt -
Linda Walsh