[opensuse-factory] Action-Required for Packagers re: /var/adm/fillup-templates move
Hi Packagers, As previously discussed on the opensuse-packaging mailinglist, we are moving our location of fillup-templates from /var/adm to /usr/share https://lists.opensuse.org/opensuse-packaging/2017-11/msg00017.html In order to do this as smoothly as possible we are using a new %_fillupdir macro so spec files can inherit the new location, while still defining the macro as the old location for older distributions to not change anything there. https://en.opensuse.org/index.php?title=openSUSE:Packaging_Conventions_RPM_M... As promised, this is the official notification that the new %_fillupdir macro is now present in Tumbleweed and should be used in all specfiles instead of /var/adm/fillup-templates The original plan was going to require all package maintainers to modify their specfiles to use the new macro. However, while taking care of the packages I am interested in for Kubic I decided to do the work for all 207 affected packages. So package maintainers, all you should have to do is review & accept the OBS Submit Requests from me referencing boo#1069468, the tracker bug for this issue. The submit requests include the compatibility definition for older distributions. Feel free to remove it if you do not need to build that package for older distributions. Please do what you can to accept and forward these requests to factory as quickly as possible, especially for those packages also used by SLE & Leap. I am hopeful to get the btrfs subvolumes simplified once these changes are complete, so I need your help to get these done promptly. Thanks in advance, -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Hello Richard, On 23/11/17 14:44, Richard Brown wrote:
Hi Packagers,
As previously discussed on the opensuse-packaging mailinglist, we are moving our location of fillup-templates from /var/adm to /usr/share
https://lists.opensuse.org/opensuse-packaging/2017-11/msg00017.html
In order to do this as smoothly as possible we are using a new %_fillupdir macro so spec files can inherit the new location, while still defining the macro as the old location for older distributions to not change anything there.
https://en.opensuse.org/index.php?title=openSUSE:Packaging_Conventions_RPM_M...
[...]
However, while taking care of the packages I am interested in for Kubic I decided to do the work for all 207 affected packages.
I know I am a bit late on that but the changes your introduced in these packages make spec-cleaner unhappy %{?!python_module:%define python_module() python-%{**} python3-%{**}} #Compat macro for new _fillupdir macro introduced in Nov 2017 %if ! %{defined _fillupdir} - %define _fillupdir /var/adm/fillup-templates + %define _fillupdir %{_localstatedir}/adm/fillup-templates %endif In any case, I think it should be OK to accept what 'spec-cleaner' suggests but I wanted to check with you in case this breaks something for an older openSUSE release. -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Hi MArkos, On Wed, 2017-12-27 at 17:14 +0000, Markos Chandras wrote:
Hello Richard,
I know I am a bit late on that but the changes your introduced in these packages make spec-cleaner unhappy
%{?!python_module:%define python_module() python-%{**} python3-%{**}} #Compat macro for new _fillupdir macro introduced in Nov 2017 %if ! %{defined _fillupdir} - %define _fillupdir /var/adm/fillup-templates + %define _fillupdir %{_localstatedir}/adm/fillup-templates %endif
In any case, I think it should be OK to accept what 'spec-cleaner' suggests but I wanted to check with you in case this breaks something for an older openSUSE release.
Not sure if Richard is actively following mails at the moment - so I'll just reply in his stead. That change is indeed not going to cause a problem, since %_localestatedir has been set to /var for a long time - and for CODE 15 it won't be used, as %_fillupdir should be defined in those. SO you are perfectly fine with accepting this spec-cleaner modification. Cheers Dominique
Hi Dominique, On 27/12/17 17:19, Dominique Leuenberger / DimStar wrote:
Hi MArkos,
On Wed, 2017-12-27 at 17:14 +0000, Markos Chandras wrote:
Hello Richard,
I know I am a bit late on that but the changes your introduced in these packages make spec-cleaner unhappy
%{?!python_module:%define python_module() python-%{**} python3-%{**}} #Compat macro for new _fillupdir macro introduced in Nov 2017 %if ! %{defined _fillupdir} - %define _fillupdir /var/adm/fillup-templates + %define _fillupdir %{_localstatedir}/adm/fillup-templates %endif
In any case, I think it should be OK to accept what 'spec-cleaner' suggests but I wanted to check with you in case this breaks something for an older openSUSE release.
Not sure if Richard is actively following mails at the moment - so I'll just reply in his stead.
That change is indeed not going to cause a problem, since %_localestatedir has been set to /var for a long time - and for CODE 15 it won't be used, as %_fillupdir should be defined in those.
SO you are perfectly fine with accepting this spec-cleaner modification.
Cheers Dominique
Great! Thank you Dominique -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (3)
-
Dominique Leuenberger / DimStar -
Markos Chandras -
Richard Brown