[opensuse-factory] Spec-cleaner as format_spec_file replacement round 2
Hello guys, as already discussed here on mailinglist I would like to replace the default formatting solution for the incoming spec-files to be the spec- cleaner instead of the obs-service-format_spec_file. This time we integrated another bunch of fixes for the minimal mode and as a most prominent features/fixes are following two: 1) Possibility to disable the cleaner run [1] which is quite obvious. 2) Codeblock detection to keep relevant things together in preamble [2] With this I also tried to parse all possible kind of approaches we already have in Factory and wrote testcase which covers hopefully all the possible variants [3]. I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs. To switch between the implementations simply install 'spec-cleaner- format_spec_file' or run 'spec-cleaner -i -m package.spec'. TIA Tom [1] https://github.com/openSUSE/spec-cleaner/issues/148 [2] https://github.com/openSUSE/spec-cleaner/issues/88 [3] https://github.com/openSUSE/spec-cleaner/blob/master/tests/out/code block.spec [4] https://github.com/openSUSE/spec-cleaner/issues
Hi, On Tue, 2017-02-28 at 16:33 +0100, Tomas Chvatal wrote:
Hello guys,
as already discussed here on mailinglist I would like to replace the default formatting solution for the incoming spec-files to be the spec- cleaner instead of the obs-service-format_spec_file.
This time we integrated another bunch of fixes for the minimal mode and as a most prominent features/fixes are following two:
1) Possibility to disable the cleaner run [1] which is quite obvious. 2) Codeblock detection to keep relevant things together in preamble [2] With this I also tried to parse all possible kind of approaches we already have in Factory and wrote testcase which covers hopefully all the possible variants [3].
are the features you mention somewhere documented? Or is there in general some documentation about spec-cleaner? I learned today on irc that there is something like # SECTION test requirements # /SECTION but it would be nice to have this documented (maybe just in the project README). TIA Tom
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
To switch between the implementations simply install 'spec-cleaner- format_spec_file' or run 'spec-cleaner -i -m package.spec'.
TIA
Tom
[1] https://github.com/openSUSE/spec-cleaner/issues/148 [2] https://github.com/openSUSE/spec-cleaner/issues/88 [3] https://github.com/openSUSE/spec-cleaner/blob/master/tests/out/co de block.spec [4] https://github.com/openSUSE/spec-cleaner/issues -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Thomas Bechtold píše v Út 28. 02. 2017 v 17:32 +0100:
Hi,
On Tue, 2017-02-28 at 16:33 +0100, Tomas Chvatal wrote:
Hello guys,
as already discussed here on mailinglist I would like to replace the default formatting solution for the incoming spec-files to be the spec- cleaner instead of the obs-service-format_spec_file.
This time we integrated another bunch of fixes for the minimal mode and as a most prominent features/fixes are following two:
1) Possibility to disable the cleaner run [1] which is quite obvious. 2) Codeblock detection to keep relevant things together in preamble [2] With this I also tried to parse all possible kind of approaches we already have in Factory and wrote testcase which covers hopefully all the possible variants [3].
are the features you mention somewhere documented? Or is there in general some documentation about spec-cleaner? I learned today on irc that there is something like
# SECTION test requirements # /SECTION
but it would be nice to have this documented (maybe just in the project README).
Matejcik will update the wiki a bit :) But honestly I suck at documenting stuff, so if ya want pullrequests are gladly welcome. Cheers Tom
Hello Tomas, Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236. When nonsensical spec file changes show up it's become a hunch that people are using spec-cleaner, so that is not making me confident of letting everyone use it and uglify other people's spec files and diffs. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Mon, Mar 20, Andreas Färber wrote:
Hello Tomas,
Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236.
Much more worse, spec-cleaner is setting {} at the wrong places and breaks spec files: -%sysusers_generate_pre %{SOURCE1} uucp +%{sysusers_generate_pre} %{SOURCE1} uucp Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & CaaSP SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Thorsten Kukuk píše v Po 20. 03. 2017 v 11:18 +0100:
On Mon, Mar 20, Andreas Färber wrote:
Hello Tomas,
Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236.
Much more worse, spec-cleaner is setting {} at the wrong places and breaks spec files: -%sysusers_generate_pre %{SOURCE1} uucp +%{sysusers_generate_pre} %{SOURCE1} uucp
This is the non-minimal mode that is being run if you do it by hand. It has a whitelist, feel free to report a bug on github please. Tom
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Mon, 2017-03-20 at 12:10 +0100, Tomas Chvatal wrote:
Thorsten Kukuk píše v Po 20. 03. 2017 v 11:18 +0100:
On Mon, Mar 20, Andreas Färber wrote:
Hello Tomas,
Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236.
Much more worse, spec-cleaner is setting {} at the wrong places and breaks spec files: -%sysusers_generate_pre %{SOURCE1} uucp +%{sysusers_generate_pre} %{SOURCE1} uucp
This is the non-minimal mode that is being run if you do it by hand. It has a whitelist, feel free to report a bug on github please.
Tom Fixed (hopefully) in https://github.com/openSUSE/spec-cleaner/pull/175
Cheers Martin -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwQnJ+Ps8HqIKhK3yWyRdZ/3eaFcFAljPxTUACgkQWyRdZ/3e aFfjsQ/+IJsjbn4dOx5AkPqqYK4oxsy+FtuqCCrBp562lbCWppyjjGvAfDbXfI3r d4VsJYCSK5NRXYOLb6KXXIm7sUUGwx2Gy+mjLZkEWJBMWY6iGxOFXtuKRZCO/nnj dlvDNIgFu/FgE6S3n8/rVsWw3oesZmwsM3eJqFlBo+Yk1qfEsBAqadF8cQOxOuzn yKoFfcHG+F6A582y5jX9807putF9u89cbVEoYgEP+LZNElEN60GeQjclHz1maGuf 3jrJvDSGdkKU+45Gsk3UdMxUdHEeqvaZodqOAuJ3dbPyIFm6fvI+w9OcXApie01l bfBxvhT0J4xSHIDdkp785d6f/T4aSBuzw8RmIHlm/eYHKZ8sI2wdHSfb+lPGkiVo lQC+TQlXX3udffuYT3B97COGmy8TTigdLoog8XgkRoxlXektRKnD6NkImaiHn9im XUdTXGAe7Mb+DRvyFAOs6swWGnXTRL6ya2w7oTNBgvKBJY/1YGmM8SP+hvdKZDmV UBpecjhyz62YJ2ss70i2Q4TATVEL9TURYyMlnwiTsTzbzHHRI/hyZ+nwhp1KjkmQ P0mZpjLN+14LtzGRAJWm1DheYFBK/moo4z3PI11005bVk7zMA1bwubvrWFh77y/d Rhks7i4uvSGd4i8TZF3BUj8+ZOSPxY0DV73NXr/VY5GpDLZaLVc= =AB1i -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Andreas Färber píše v Po 20. 03. 2017 v 11:10 +0100:
Hello Tomas,
Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236.
When nonsensical spec file changes show up it's become a hunch that people are using spec-cleaner, so that is not making me confident of letting everyone use it and uglify other people's spec files and diffs.
This is also a bug. So please open an issue on github for it. Or if you feel generous write even testcase that it should not put the whitespace there... Tom
Tomas Chvatal píše v Po 20. 03. 2017 v 12:11 +0100:
Andreas Färber píše v Po 20. 03. 2017 v 11:10 +0100:
Hello Tomas,
Am 28.02.2017 um 16:33 schrieb Tomas Chvatal:
I would love to ask you all to check if your packages are fine and report bugs [4] if any problematic behaviour occurs.
spec-cleaner still adds unnecessary whitespace noise, cf. sr#481236.
When nonsensical spec file changes show up it's become a hunch that people are using spec-cleaner, so that is not making me confident of letting everyone use it and uglify other people's spec files and diffs.
This is also a bug. So please open an issue on github for it. Or if you feel generous write even testcase that it should not put the whitespace there...
Tom
Anyway debugged it and reported: https://github.com/openSUSE/spec-cleaner/issues/176 For a fix I will have to think about it first a bit :) Tom
participants (5)
-
Andreas Färber -
Martin Pluskal -
Thomas Bechtold -
Thorsten Kukuk -
Tomas Chvatal