Hello community, here is the log from the commit of package talk checked in at Wed Jan 10 18:37:32 CET 2007. -------- --- talk/talk.changes 2006-09-19 16:33:58.000000000 +0200 +++ /mounts/work_src_done/STABLE/talk/talk.changes 2007-01-10 15:21:14.000000000 +0100 @@ -1,0 +2,6 @@ +Wed Jan 10 15:18:49 CET 2007 - anosek@suse.cz + +- fixed: talkd does not allow connection from hosts without DNS + record [#227396] (dont-resolve.patch) + +------------------------------------------------------------------- New: ---- netkit-ntalk-0.17-dont-resolve.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ talk.spec ++++++ --- /var/tmp/diff_new_pack.M22606/_old 2007-01-10 18:36:39.000000000 +0100 +++ /var/tmp/diff_new_pack.M22606/_new 2007-01-10 18:36:39.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package talk (Version 0.17) # -# Copyright (c) 2006 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine # package are under the same license as the package itself. # @@ -11,12 +11,12 @@ # norootforbuild Name: talk -License: BSD +License: BSD License and BSD-like Group: Productivity/Networking/Talk/Clients Provides: nkitb:/usr/bin/talk Autoreqprov: on Version: 0.17 -Release: 574 +Release: 592 Summary: Talk Client for Chatting with Another User BuildRoot: %{_tmppath}/%{name}-%{version}-build URL: ftp://ftp.uk.linux.org/pub/linux/Networking/netkit/ @@ -27,6 +27,7 @@ Patch1: netkit-ntalk-multibyte.diff Patch2: netkit-ntalk-%{version}-alt-talkd.patch Patch3: netkit-ntalk-%{version}-strip.diff +Patch4: netkit-ntalk-%{version}-dont-resolve.patch %description This package contains the talk client, which allows you to chat with @@ -37,7 +38,7 @@ %package server Version: 0.17 -Release: 574 +Release: 592 Summary: Talk Daemon to Chat with Another User Group: Productivity/Networking/Talk/Servers Requires: net-tools netcfg @@ -57,6 +58,7 @@ %patch1 -p1 -b .mb %patch2 -p1 %patch3 +%patch4 %build CFLAGS="$RPM_OPT_FLAGS" ./configure @@ -94,6 +96,9 @@ %config(noreplace) /etc/xinetd.d/ntalk %changelog -n talk +* Wed Jan 10 2007 - anosek@suse.cz +- fixed: talkd does not allow connection from hosts without DNS + record [#227396] (dont-resolve.patch) * Tue Sep 19 2006 - anosek@suse.cz - talk server runs as nobody.tty (originally was root.root) * Wed Jan 25 2006 - mls@suse.de ++++++ netkit-ntalk-0.17-dont-resolve.patch ++++++ --- talkd/talkd.c +++ talkd/talkd.c @@ -220,28 +220,13 @@ AF_INET); if (hp == NULL) { syslog(LOG_WARNING, "%s: bad dns", theirip); - send_reject_packet(mp, &sn, MACHINE_UNKNOWN, 0); - return; - } - strncpy(theirhost, hp->h_name, sizeof(theirhost)); - theirhost[sizeof(theirhost)-1] = 0; - - hp = gethostbyname(theirhost); - if (hp == NULL) { - syslog(LOG_WARNING, "%s: bad dns", theirip); - send_reject_packet(mp, &sn, MACHINE_UNKNOWN, 0); - return; - } - - for (i=ok=0; hp->h_addr_list[i] && !ok; i++) { - if (!memcmp(hp->h_addr_list[i], &sn.sin_addr, - sizeof(sn.sin_addr))) ok = 1; - } - if (!ok) { - syslog(LOG_WARNING, "%s: bad dns", theirip); - send_reject_packet(mp, &sn, MACHINE_UNKNOWN, 0); - return; + strncpy(theirhost, theirip, sizeof(theirhost)); + theirhost[sizeof(theirhost)-1] = 0; } + else { + strncpy(theirhost, hp->h_name, sizeof(theirhost)); + theirhost[sizeof(theirhost)-1] = 0; + } /* * Try to straighten out bad packets. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org
participants (1)
-
root@Hilbert.suse.de