Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package ddcutil-service for openSUSE:Factory checked in at 2024-04-29 17:57:49
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/ddcutil-service (Old)
and /work/SRC/openSUSE:Factory/.ddcutil-service.new.1880 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ddcutil-service"
Mon Apr 29 17:57:49 2024 rev:5 rq:1170644 version:1.0.6
Changes:
--------
--- /work/SRC/openSUSE:Factory/ddcutil-service/ddcutil-service.changes 2024-04-14 12:24:47.481937126 +0200
+++ /work/SRC/openSUSE:Factory/.ddcutil-service.new.1880/ddcutil-service.changes 2024-04-29 17:57:53.770388912 +0200
@@ -1,0 +2,12 @@
+Mon Apr 29 03:52:43 UTC 2024 - Michael Hamilton
+
+- 1.0.6
+ - Add SetVcp/SetVcpWithContext NO_VERIFY (no retry) flag option.
+ - Match the behaviour of the ddcutil command, default to verify-and-retry for all set-vcp method calls.
+ - Default to verify-and-retry for all libddcutil versions.
+ - Replace the stateful DdcutilVerifySetVcp property with the stateless NO_VERIFY flag.
+ - Fix the ServiceFlagOptions property so that it lists all flag options.
+ - Check the status returned by libddcutil ddca_init() and exit on error to prevent any inconsistent behaviour.
+ - Cleanup the --prefer-polling and --prefer-drm options to make them consistent with each other.
+
+-------------------------------------------------------------------
Old:
----
ddcutil-service-1.0.4.tar.gz
New:
----
ddcutil-service-1.0.6.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ ddcutil-service.spec ++++++
--- /var/tmp/diff_new_pack.CMaW5W/_old 2024-04-29 17:57:54.606419319 +0200
+++ /var/tmp/diff_new_pack.CMaW5W/_new 2024-04-29 17:57:54.606419319 +0200
@@ -18,7 +18,7 @@
Name: ddcutil-service
-Version: 1.0.4
+Version: 1.0.6
Release: 0
Summary: D-Bus service for libddcutil VESA DDC Monitor Virtual Control Panel
License: GPL-2.0-or-later
++++++ ddcutil-service-1.0.4.tar.gz -> ddcutil-service-1.0.6.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ddcutil-service-1.0.4/Makefile new/ddcutil-service-1.0.6/Makefile
--- old/ddcutil-service-1.0.4/Makefile 2024-04-11 02:58:06.000000000 +0200
+++ new/ddcutil-service-1.0.6/Makefile 2024-04-29 06:17:32.000000000 +0200
@@ -5,6 +5,7 @@
CFLAGS_DDCUTIL = $(shell pkg-config --cflags --libs ddcutil)
# Uncomment to compile against a developer local libddcutil
#CFLAGS_DDCUTIL = -isystem $(HOME)/Downloads/ddcutil-2.1.5-dev/src/public -L $(HOME)/Downloads/ddcutil-2.1.5-dev/src/.libs -lddcutil
+#CFLAGS_DDCUTIL = -isystem $(HOME)/Downloads/ddcutil-2.1.5-dev-clion/build/src/public -isystem $(HOME)/Downloads/ddcutil-2.1.5-dev-clion/src/public -L $(HOME)/Downloads/ddcutil-2.1.5-dev-clion/build/src/.libs -lddcutil
#CFLAGS_DDCUTIL = -isystem $(HOME)/Downloads/ddcutil-2.1.4-dev/src/public -L $(HOME)/Downloads/ddcutil-2.1.4-dev/src/.libs -lddcutil
#CFLAGS_DDCUTIL = -isystem $(HOME)/Downloads/ddcutil-2.0.0/src/public -L $(HOME)/Downloads/ddcutil-2.0.0/src/.libs -lddcutil
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ddcutil-service-1.0.4/README.md new/ddcutil-service-1.0.6/README.md
--- old/ddcutil-service-1.0.4/README.md 2024-04-11 02:58:06.000000000 +0200
+++ new/ddcutil-service-1.0.6/README.md 2024-04-29 06:17:32.000000000 +0200
@@ -98,7 +98,18 @@
Johan Grande ([nahoj](https://github.com/nahoj)) for the Ubuntu patches;
and Mark Wagie ([yochananmarqos](https://github.com/yochananmarqos)) for AUR packaging.
+The development IDE is **[JetBrains CLion-Nova/CLion](https://www.jetbrains.com/help/clion/clion-nova-introduction.html)**. Thanks go out to JetBrains for
+granting the [Open Source development license]( https://jb.gg/OpenSourceSupport).
+
### Version History
+- 1.0.6
+ - Add SetVcp/SetVcpWithContext NO_VERIFY (no retry) flag option.
+ - Match the behaviour of the ddcutil command, default to verify-and-retry for all set-vcp method calls.
+ - Default to verify-and-retry for all libddcutil versions.
+ - Replace the stateful DdcutilVerifySetVcp property with the stateless NO_VERIFY flag.
+ - Fix the ServiceFlagOptions property so that it lists all flag options.
+ - Check the status returned by libddcutil ddca_init() and exit on error to prevent any inconsistent behaviour.
+ - Cleanup the --prefer-polling and --prefer-drm options to make them consistent with each other.
- 1.0.4
- Provide an API flag RETURN_RAW_VALUES which disables GetVcp high-byte masking of Simple Non-Continuous features.
- Provide the --return-raw-values command line option for the same purpose.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ddcutil-service-1.0.4/ddcutil-service.1 new/ddcutil-service-1.0.6/ddcutil-service.1
--- old/ddcutil-service-1.0.4/ddcutil-service.1 2024-04-11 02:58:06.000000000 +0200
+++ new/ddcutil-service-1.0.6/ddcutil-service.1 2024-04-29 06:17:32.000000000 +0200
@@ -224,6 +224,8 @@
.B SetVcp
Set a display setting, specified by VCP code, to a new value.
If the method succeeds, it will also emit a D-Bus \fBVcpValueChanged\fP signal.
+Set the method's \fBflags\fP to \fB4\fP (\fBNO_VERIFY\fP) to disable libddcutil
+verification and retry.
.TP
.B SetVcpWithContext
@@ -392,9 +394,8 @@
.TP
.B DdcutilVerifySetVcp
-Enable/disable
-.B libddcutil
-extra DDC calls to check whether VCP settings were actually applied by the monitor.
+Obsolete as of version 1.0.5+,
+replaced by the \fBSetVcp\fP method's \fBNO_VERIFY\fP flag.
.TP
.B DdcutilVersion
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ddcutil-service-1.0.4/ddcutil-service.7 new/ddcutil-service-1.0.6/ddcutil-service.7
--- old/ddcutil-service-1.0.4/ddcutil-service.7 2024-04-11 02:58:06.000000000 +0200
+++ new/ddcutil-service-1.0.6/ddcutil-service.7 2024-04-29 06:17:32.000000000 +0200
@@ -2,12 +2,12 @@
.\" Title: com.ddcutil.DdcutilInterface
.\" Author: Michael Hamilton
.\" Generator: DocBook XSL Stylesheets vsnapshot http://docbook.sf.net/
-.\" Date: 04/09/2024
+.\" Date: 04/25/2024
.\" Manual: Miscellaneous
.\" Source: ddcutil-service
.\" Language: English
.\"
-.TH "COM\&.DDCUTIL\&.DDCU" "7" "04/09/2024" "ddcutil\-service" "Miscellaneous"
+.TH "COM\&.DDCUTIL\&.DDCU" "7" "04/25/2024" "ddcutil\-service" "Miscellaneous"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
@@ -150,7 +150,6 @@
AttributesReturnedByDetect readable as
StatusValues readable a{is}
DdcutilVersion readable s
-DdcutilVerifySetVcp readwrite b
DdcutilDynamicSleep readwrite b
DdcutilOutputLevel readwrite u
DisplayEventTypes readable a{is}
@@ -438,6 +437,10 @@
\fIvcp_new_value\fR
is always passed as a 16 bit integer (most VCP values are single byte 8\-bit intergers, very few are two\-byte 16\-bit)\&.
.PP
+The method\*(Aqs
+\fIflags\fR
+parameter can be set to 4 (NO_VERIFY) to disable libddcutil verify and retry\&. Verification and retry is the default\&.
+.PP
IN i \fIdisplay_number\fR:
.RS 4
the libddcutil/ddcutil display number to alter
@@ -499,6 +502,10 @@
\fIvcp_new_value\fR
is always passed as a 16 bit integer (most VCP values are single byte 8\-bit intergers, very few are two\-byte 16\-bit)\&.
.PP
+The method\*(Aqs
+\fIflags\fR
+parameter can be set to 4 (NO_VERIFY) to disable libddcutil verify and retry\&. Verification and retry is the default\&.
+.PP
IN i \fIdisplay_number\fR:
.RS 4
the libddcutil/ddcutil display number to alter
@@ -1068,21 +1075,6 @@
.\}
.PP
The ddcutil version number for the linked libddcutil\&.
-.SS "The "DdcutilVerifySetVcp" property"
-.sp
-.if n \{\
-.RS 4
-.\}
-.nf
-DdcutilVerifySetVcp readwrite b
-.fi
-.if n \{\
-.RE
-.\}
-.PP
-Within libddcutil each setvcp is verified by internal check using a getvcp\&. This verfication step can be enabled or disabled by altering this property\&.
-.PP
-Attempting to set this property when the service is configuration\-locked will result in an com\&.ddcutil\&.DdcutilService\&.Error\&.ConfigurationLocked error being raised\&.
.SS "The "DdcutilDynamicSleep" property"
.sp
.if n \{\
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ddcutil-service-1.0.4/ddcutil-service.c new/ddcutil-service-1.0.6/ddcutil-service.c
--- old/ddcutil-service-1.0.4/ddcutil-service.c 2024-04-11 02:58:06.000000000 +0200
+++ new/ddcutil-service-1.0.6/ddcutil-service.c 2024-04-29 06:17:32.000000000 +0200
@@ -58,7 +58,7 @@
#include
#include
-#define DDCUTIL_DBUS_INTERFACE_VERSION_STRING "1.0.4"
+#define DDCUTIL_DBUS_INTERFACE_VERSION_STRING "1.0.6"
#define DDCUTIL_DBUS_DOMAIN "com.ddcutil.DdcutilService"
#if DDCUTIL_VMAJOR == 2 && DDCUTIL_VMINOR == 0 && DDCUTIL_VMICRO < 2
@@ -73,14 +73,25 @@
#define LIBDDCUTIL_HAS_DDCA_GET_DEFAULT_SLEEP_MULTIPLIER
#endif
+#define MACRO_EXISTS(name) (#name [0] != G_STRINGIFY(name) [0])
+
#undef XML_FROM_INTROSPECTED_DATA
+/**
+ * Define the service's connectivity monitoring options
+ */
+typedef enum {
+ MONITOR_BY_INTERNAL_POLLING,
+ MONITOR_BY_LIBDDCUTIL_EVENTS,
+} Monitoring_Preference_Type;
+
static gboolean display_status_detection_enabled = FALSE;
static gboolean enable_connectivity_signals = FALSE;
-static gboolean prefer_polling = TRUE;
static gboolean return_raw_values = FALSE;
static gboolean lock_configuration = FALSE;
+static Monitoring_Preference_Type monitoring_preference = MONITOR_BY_INTERNAL_POLLING;
+
#define VERIFY_I2C
static int service_broken_error = -1;
@@ -179,15 +190,18 @@
* Boolean flags that can be passed in the service method flags argument.
*/
typedef enum {
- EDID_PREFIX = 1, // Indicates the EDID passed to the service is a unique prefix (substring) of the actual EDID.
- RETURN_RAW_VALUES = 2,
+ EDID_PREFIX = 1, // Indicates the EDID passed to the service is a unique prefix (substr) of the actual EDID.
+ RETURN_RAW_VALUES = 2, // GetVcp GetMultipleVcp
+ NO_VERIFY = 4, // SetVcp
} Flags_Enum_Type;
/**
* Iterable definitions of Flags_Enum_Type values/names (for return from a service property).
*/
-const int flag_options[] = {EDID_PREFIX,};
-const char* flag_options_names[] = {G_STRINGIFY(EDID_PREFIX),};
+const int flag_options[] = {EDID_PREFIX,RETURN_RAW_VALUES, NO_VERIFY,};
+const char* flag_options_names[] = {G_STRINGIFY(EDID_PREFIX),
+ G_STRINGIFY(RETURN_RAW_VALUES),
+ G_STRINGIFY(NO_VERIFY),};
/* ----------------------------------------------------------------------------------------------------
* D-Bus interface definition in XML
@@ -230,7 +244,7 @@
@text_options: Text options to be passed to libddcutil ddca_init().
@syslog_level: The libddcutil syslog level.
@flags: For furture use.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Restarts the service with the supplied parameters.
@@ -251,7 +265,7 @@
@flags: If set to 1, any invalid VDUs will be included in the results.
@number_of_displays: The number of VDUs detected (the length of @detected_displays).
@detected_displays: An array of structures describing the VDUs.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Issues a detect and returns the VDUs detected.
@@ -279,7 +293,7 @@
@vcp_current_value: The current numeric value as a unified 16 bit integer.
@vcp_max_value: The maximum possible value, to allow for easy calculation of current/max.
@vcp_formatted_value: A formatted version of the value including related info such as the max-value.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Retrieve the value for a VCP-code for the specified VDU.
@@ -312,7 +326,7 @@
@vcp_code: the VPC-code to query.
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
@vcp_current_value: An array of VCP-codes and values.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Retrieves several different VCP values for the specified VDU. This is a convienience
@@ -341,13 +355,16 @@
@vcp_code: the VPC-code to query.
@vcp_new_value: the numeric value as a 16 bit integer.
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Set the value for a VCP-code for the specified VDU.
For simplicity the @vcp_new_value is always passed as a 16 bit integer (most
VCP values are single byte 8-bit intergers, very few are two-byte 16-bit).
+
+ The method's @flags parameter can be set to 4 (NO_VERIFY) to disable
+ libddcutil verify and retry. Verification and retry is the default.
-->
<method name='SetVcp'>
<arg name='display_number' type='i' direction='in'/>
@@ -367,13 +384,16 @@
@vcp_new_value: the numeric value as a 16 bit integer.
@client_context: a client-context string that will be returned with the VcpValueChanged signal.
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Set the value for a VCP-code for the specified VDU.
For simplicity the @vcp_new_value is always passed as a 16 bit integer (most
VCP values are single byte 8-bit intergers, very few are two-byte 16-bit).
+
+ The method's @flags parameter can be set to 4 (NO_VERIFY) to disable
+ libddcutil verify and retry. Verification and retry is the default.
-->
<method name='SetVcpWithContext'>
<arg name='display_number' type='i' direction='in'/>
@@ -399,7 +419,7 @@
@is_rw: True if the feature is readable and writable.
@is_complex: True if the feature is complex (multi-byte).
@is_continuous: True in the feature is a continuous value (it is not an enumeration).
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Retrieve the metadata for a VCP-code for the specified VDU.
@@ -426,7 +446,7 @@
@edid_txt: the base-64 encoded EDID of the display
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
@capabilities_text: the capability string for the VDU.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Retrieve the capabilities metadata for a VDU in a format similar to that output by
@@ -451,7 +471,7 @@
@mccs_minor: MCCS minor version number byte.
@commands: supported commands as a dictionary indexed by command number.
@capabilities: supported VCP features as a dictionary indexed by VCP-code.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Retrieve the capabilities metadata for a VDU in a parsed dictionary structure
@@ -509,7 +529,7 @@
@vcp_code: the VPC-code to query, for example, 16 (0x10) is brightness.
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
@current_multiplier: the sleep multiplier.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Get the current libddcutil sleep multiplier for the specified VDU.
@@ -532,7 +552,7 @@
@vcp_code: The VPC-code to query, for example, 16 (0x10) is brightness.
@flags: If 1, the @edid_txt is matched as a unique prefex of the EDID.
@new_multiplier: The sleep multiplier.
- @error_status: A libddcutil DDCRC error status. DDCA_OK (zero) if no errors have occured.
+ @error_status: A libddcutil DDCRC error status. DDCRC_OK (zero) if no errors have occured.
@error_message: Text message for error_status.
Set the libddcutil sleep multiplier for the specified VDU.
@@ -631,18 +651,6 @@
<property type='s' name='DdcutilVersion' access='read'/>
<!--
- DdcutilVerifySetVcp:
-
- Within libddcutil each setvcp is verified by internal check using a getvcp.
- This verfication step can be enabled or disabled by altering this property.
-
- Attempting to set this property when the service is configuration-locked
- will result in an com.ddcutil.DdcutilService.Error.ConfigurationLocked error
- being raised.
- -->
- <property type='b' name='DdcutilVerifySetVcp' access='readwrite'/>
-
-
Reply