Hello community,
here is the log from the commit of package epiphany for openSUSE:Factory checked in at 2017-01-19 10:43:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/epiphany (Old)
and /work/SRC/openSUSE:Factory/.epiphany.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "epiphany"
Changes:
--------
--- /work/SRC/openSUSE:Factory/epiphany/epiphany.changes 2017-01-10 10:51:11.638148255 +0100
+++ /work/SRC/openSUSE:Factory/.epiphany.new/epiphany.changes 2017-01-19 10:44:28.515790062 +0100
@@ -1,0 +2,12 @@
+Tue Jan 17 10:15:49 UTC 2017 - zaitor@opensuse.org
+
+- Update to version 3.22.5:
+ + Do not offer to remember empty passwords (bgo#771073).
+ + Fix tenth webpage missing in overview (regression from 3.22.4).
+ + "Press key to exit fullscreen" message is now legible.
+ + Fix memory leak when tab is closed before permission request
+ info bar.
+ + Store permissions for hosts displayed in info bar, not the
+ current page.
+
+-------------------------------------------------------------------
Old:
----
epiphany-3.22.4.tar.xz
New:
----
epiphany-3.22.5.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ epiphany.spec ++++++
--- /var/tmp/diff_new_pack.YkzvzT/_old 2017-01-19 10:44:28.975725180 +0100
+++ /var/tmp/diff_new_pack.YkzvzT/_new 2017-01-19 10:44:28.975725180 +0100
@@ -1,7 +1,7 @@
#
# spec file for package epiphany
#
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: epiphany
-Version: 3.22.4
+Version: 3.22.5
Release: 0
%define _base_version 3.22
Summary: GNOME Web Browser
++++++ epiphany-3.22.4.tar.xz -> epiphany-3.22.5.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/ChangeLog new/epiphany-3.22.5/ChangeLog
--- old/epiphany-3.22.4/ChangeLog 2016-12-28 01:28:44.000000000 +0100
+++ new/epiphany-3.22.5/ChangeLog 2017-01-17 01:26:11.000000000 +0100
@@ -1,3 +1,132 @@
+commit e580ac9a6946ce6932c482494d7317415d321721
+Author: Michael Catanzaro
+Date: Mon Jan 16 18:24:40 2017 -0600
+
+ Prepare 3.22.5
+
+ Got to do this because I accidentally broke the last overview item in
+ 3.22.4 :(
+
+ NEWS | 10 ++++++++++
+ configure.ac | 2 +-
+ 2 files changed, 11 insertions(+), 1 deletion(-)
+
+commit 643cb425453800de283d66470054af0e772f82fd
+Author: Michael Catanzaro
+Date: Mon Jan 16 10:13:04 2017 -0600
+
+ Improve style for fullscreen overlay text
+
+ src/resources/epiphany.css | 8 +++++---
+ src/resources/epiphany.scss | 9 +++++----
+ 2 files changed, 10 insertions(+), 7 deletions(-)
+
+commit 7b892ac979dc59153f5abe71b4808fe5da3769af
+Author: Michael Catanzaro
+Date: Fri Jan 13 21:53:51 2017 -0600
+
+ Update parse-sass script to use new GTK+ 3 directory
+
+ src/resources/parse-sass.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit b2c1bd64a38ade3f805b9245fef63f48340a6c7b
+Author: Michael Catanzaro
+Date: Sat Jan 14 15:18:21 2017 -0600
+
+ web-view: Fix memory leaks when web view is closed before info bar
+
+ The current info bar management code improperly assumes that the user
+ will always close the info bar before closing its associated web view.
+ If the user closes the web view first, then we leak the FormAuthData
+ or PermissionRequestData struct in EphyWebView. In the case of
+ PermissionRequestData, that notably contains an unresolved
+ WebKitPermissionRequest. Additionally, for form auth data requests, the
+ hash table entry for the outstanding request in the web extension is
+ leaked because the web extension never receives the expected form auth
+ data request response.
+
+ Resolve this by tracking the destruction of the info bars with a weak
+ reference.
+
+ embed/ephy-web-view.c | 27 +++++++++++++++++++++++++--
+ 1 file changed, 25 insertions(+), 2 deletions(-)
+
+commit 2a762640b0d94df0fe62dbe0e41fdb863f1baaef
+Author: Michael Catanzaro
+Date: Sat Jan 14 15:00:19 2017 -0600
+
+ web-view: Add helpers for allocating/freeing info bar structs
+
+ embed/ephy-web-view.c | 57 +++++++++++++++++++++++++++++++++++++++------------
+ 1 file changed, 44 insertions(+), 13 deletions(-)
+
+commit 5625913cf64db5973e65d4cf98b7411e8bf11d85
+Author: Michael Catanzaro
+Date: Fri Jan 13 21:55:51 2017 -0600
+
+ theme: press to exit fullscreen label should be visible on dark pages
+
+ The text is black, so give it a light background.
+
+ src/resources/epiphany.css | 5 +++++
+ src/resources/epiphany.scss | 7 +++++++
+ 2 files changed, 12 insertions(+)
+
+commit b6fc61e0fdc1dd8e77f5c40fc1ed94eae46ea59d
+Author: Michael Catanzaro
+Date: Wed Jan 4 10:51:03 2017 -0600
+
+ web-extension: Only offer to remember nonempty passwords
+
+ Asking to remember an empty password is stupid. Avoids the password
+ prompt on sites like paste.gnome.org and paste.fedoraproject.org.
+
+ https://bugzilla.gnome.org/show_bug.cgi?id=771073
+
+ embed/web-extension/ephy-web-extension.c | 14 ++++++++++----
+ 1 file changed, 10 insertions(+), 4 deletions(-)
+
+commit b9286461368ccc76cbde8d5510a9c1ac0cd3feac
+Author: Michael Catanzaro
+Date: Tue Jan 3 19:12:11 2017 -0600
+
+ about-handler: Fix max overview items
+
+ This is 9 in master, but should be 10 in gnome-3-22. I broke it by
+ mistake in 39a1c7fb4e866241855b7cbfdfd68a654ef72b94 which was a
+ backport.
+
+ embed/ephy-about-handler.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit bffe94e66750fa5619701a3292bc4b13e886db09
+Author: Michael Catanzaro
+Date: Thu Dec 29 13:41:02 2016 -0600
+
+ web-view: Store permissions for the correct host
+
+ Permissions were being saved for the host corresponding to the page the
+ web view is currently displaying, which might not be the same as the
+ host that's actually shown in the permission request info bar if the
+ user has navigated to a new page. This has been broken since
+ EphyHostManager was introduced.
+
+ embed/ephy-web-view.c | 7 ++++---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+commit d67ea2e37c91b281ac4aa8da0911319345d2dd67
+Author: Michael Catanzaro
+Date: Wed Dec 28 17:32:58 2016 -0600
+
+ download-widget: Decode display URI in the right place
+
+ This needs to happen before finding the basename, not after, because a
+ basename is not a valid URI to pass to a URI decoding function.
+
+ lib/widgets/ephy-download-widget.c | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
commit 516d6e584bf93569b13657f45c8fc8f2bc56b44f
Author: Michael Catanzaro
Date: Tue Dec 27 18:27:29 2016 -0600
@@ -5867,123 +5996,3 @@
embed/ephy-embed.h | 3 +-
src/ephy-session.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++-----
4 files changed, 105 insertions(+), 14 deletions(-)
-
-commit 7d83de2dd3b6645185d31904ec90ae93f25ab680
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 15:42:07 2016 +0100
-
- ephy-session: Save the session also when active tab changes
-
- We are saving the active tab in the session, but we don't update the
- session file when it changes.
-
- src/ephy-session.c | 11 +++++++++++
- 1 file changed, 11 insertions(+)
-
-commit e18ccd0da2c0aaadac4b9c0039f385e4bdfb94d8
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 15:32:27 2016 +0100
-
- ephy-session: do not start the save task immediately
-
- Wait for one second, so that if there are several save requests in one
- second, we only save the session once. If the session is closed while
- there's a save request pending, the request is cancelled and the session
- saved immediately.
-
- src/ephy-session.c | 80 +++++++++++++++++++++++++++++++++++++++---------------
- 1 file changed, 58 insertions(+), 22 deletions(-)
-
-commit 52171e035c787ee155dfb1acb7a02f6c6469b724
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 14:42:37 2016 +0100
-
- ephy-session: Remove filename parameter from ephy_session_save()
-
- Stop pretending we support saving the session to any path. We always
- save the session to the default session file, ephy_session_save() is
- public only to be able to use it from tests.
-
- src/ephy-session.c | 46 ++++++++++++++++++++++------------------------
- src/ephy-session.h | 3 +--
- tests/ephy-session-test.c | 2 +-
- 3 files changed, 24 insertions(+), 27 deletions(-)
-
-commit adbe1549da2f28deba3f223a60f0873d46ef034d
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 12:07:45 2016 +0100
-
- ephy-session: Never save the session if the policy is set to never
-
- src/ephy-session.c | 7 +++++++
- 1 file changed, 7 insertions(+)
-
-commit 9c83f5014622ecb52811c093cd02d69e06f8de49
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 11:48:11 2016 +0100
-
- ephy-session: always set dont_save to false in ephy_session_close()
-
- It's the only thing we are doing now, so we don't need to check the
- policy, it's always safe to set dont_save to FALSE when session is
- closed.
-
- src/ephy-session.c | 11 +----------
- 1 file changed, 1 insertion(+), 10 deletions(-)
-
-commit 36c5d9be3ca9a0617c7964414964c7fc3ea75127
-Author: Carlos Garcia Campos
-Date: Thu Jan 14 10:57:59 2016 +0100
-
- embed: Remove unused EphyEmbedShell::prepare-close signal
-
- embed/ephy-embed-shell.c | 23 -----------------------
- embed/ephy-embed-shell.h | 3 ---
- src/ephy-session.c | 2 --
- 3 files changed, 28 deletions(-)
-
-commit 08eb12b3bb538f96b23bc2ac7bf21e360b085b4d
-Author: Carlos Garcia Campos
-Date: Tue Jan 19 09:52:01 2016 +0100
-
- embed: Ignore beforeunload events
-
- At least until we properly support them. Connect to WebKitWebView::script-dialog
- to always confirm we want to leave the page and stop the signal
- propagation.
-
- embed/ephy-web-view.c | 23 +++++++++++++++++++++++
- 1 file changed, 23 insertions(+)
-
-commit d66da032f687daa58bc0c00bbfb640fa81795004
-Author: Michael Catanzaro
-Date: Mon Jan 18 22:22:38 2016 -0600
-
- Take safetypes patch from Debian
-
- No clue why this was never proposed upstream....
-
- data/mime-types-permissions.xml | 4 +++-
- 1 file changed, 3 insertions(+), 1 deletion(-)
-
-commit 4960ba02c89102220f4b106f0ab13a6f48fa3d14
-Author: Michael Catanzaro
-Date: Mon Jan 18 22:14:41 2016 -0600
-
- Allow opening .tar.xz files
-
- Really a bad problem that we have a list of MIME types for which using
- the Open button is doomed to fail. A bad problem indeed. Make it seem
- like less of a bad problem by making .tar.xz files work.
-
- data/mime-types-permissions.xml | 1 +
- 1 file changed, 1 insertion(+)
-
-commit 1836df58562df4511a90f3141377d6c0b9db4c3c
-Author: Michael Catanzaro
-Date: Mon Jan 18 16:55:50 2016 -0600
-
- about-handler: Remove unused define
-
- embed/ephy-about-handler.c | 1 -
- 1 file changed, 1 deletion(-)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/NEWS new/epiphany-3.22.5/NEWS
--- old/epiphany-3.22.4/NEWS 2016-12-28 01:27:05.000000000 +0100
+++ new/epiphany-3.22.5/NEWS 2017-01-17 01:24:36.000000000 +0100
@@ -1,4 +1,14 @@
===============
+Epiphany 3.22.5
+===============
+
+- Do not offer to remember empty passwords (#771073)
+- Fix tenth webpage missing in overview (regression from 3.22.4)
+- "Press key to exit fullscreen" message is now legible
+- Fix memory leak when tab is closed before permission request info bar
+- Store permissions for hosts displayed in info bar, not the current page
+
+===============
Epiphany 3.22.4
===============
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/configure new/epiphany-3.22.5/configure
--- old/epiphany-3.22.4/configure 2016-12-28 01:27:52.000000000 +0100
+++ new/epiphany-3.22.5/configure 2017-01-17 01:25:22.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for GNOME Web Browser 3.22.4.
+# Generated by GNU Autoconf 2.69 for GNOME Web Browser 3.22.5.
#
# Report bugs to http://bugzilla.gnome.org/enter_bug.cgi?product=epiphany.
#
@@ -591,8 +591,8 @@
# Identity of this package.
PACKAGE_NAME='GNOME Web Browser'
PACKAGE_TARNAME='epiphany'
-PACKAGE_VERSION='3.22.4'
-PACKAGE_STRING='GNOME Web Browser 3.22.4'
+PACKAGE_VERSION='3.22.5'
+PACKAGE_STRING='GNOME Web Browser 3.22.5'
PACKAGE_BUGREPORT='http://bugzilla.gnome.org/enter_bug.cgi?product=epiphany'
PACKAGE_URL=''
@@ -1454,7 +1454,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures GNOME Web Browser 3.22.4 to adapt to many kinds of systems.
+\`configure' configures GNOME Web Browser 3.22.5 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1524,7 +1524,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of GNOME Web Browser 3.22.4:";;
+ short | recursive ) echo "Configuration of GNOME Web Browser 3.22.5:";;
esac
cat <<\_ACEOF
@@ -1672,7 +1672,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-GNOME Web Browser configure 3.22.4
+GNOME Web Browser configure 3.22.5
generated by GNU Autoconf 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
@@ -2041,7 +2041,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by GNOME Web Browser $as_me 3.22.4, which was
+It was created by GNOME Web Browser $as_me 3.22.5, which was
generated by GNU Autoconf 2.69. Invocation command line was
$ $0 $@
@@ -6044,7 +6044,7 @@
# Define the identity of the package.
PACKAGE='epiphany'
- VERSION='3.22.4'
+ VERSION='3.22.5'
cat >>confdefs.h <<_ACEOF
@@ -17359,7 +17359,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by GNOME Web Browser $as_me 3.22.4, which was
+This file was extended by GNOME Web Browser $as_me 3.22.5, which was
generated by GNU Autoconf 2.69. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -17425,7 +17425,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
-GNOME Web Browser config.status 3.22.4
+GNOME Web Browser config.status 3.22.5
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/configure.ac new/epiphany-3.22.5/configure.ac
--- old/epiphany-3.22.4/configure.ac 2016-12-28 01:21:59.000000000 +0100
+++ new/epiphany-3.22.5/configure.ac 2017-01-17 01:16:20.000000000 +0100
@@ -16,7 +16,7 @@
m4_define([epiphany_version_major],[3])
m4_define([epiphany_version_minor],[22])
-m4_define([epiphany_version_micro],[4])
+m4_define([epiphany_version_micro],[5])
m4_define([epiphany_version],[epiphany_version_major.epiphany_version_minor.epiphany_version_micro])
AC_INIT([GNOME Web Browser],[epiphany_version],[http://bugzilla.gnome.org/enter_bug.cgi?product=epiphany],[epiphany])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/embed/ephy-about-handler.c new/epiphany-3.22.5/embed/ephy-about-handler.c
--- old/epiphany-3.22.4/embed/ephy-about-handler.c 2016-12-28 01:21:44.000000000 +0100
+++ new/epiphany-3.22.5/embed/ephy-about-handler.c 2017-01-17 01:15:54.000000000 +0100
@@ -43,7 +43,7 @@
G_DEFINE_TYPE (EphyAboutHandler, ephy_about_handler, G_TYPE_OBJECT)
-#define EPHY_ABOUT_OVERVIEW_MAX_ITEMS 9
+#define EPHY_ABOUT_OVERVIEW_MAX_ITEMS 10
#define EPHY_PAGE_TEMPLATE_ABOUT_CSS "ephy-resource:///org/gnome/epiphany/page-templates/about.css"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/embed/ephy-web-view.c new/epiphany-3.22.5/embed/ephy-web-view.c
--- old/epiphany-3.22.4/embed/ephy-web-view.c 2016-12-28 01:21:44.000000000 +0100
+++ new/epiphany-3.22.5/embed/ephy-web-view.c 2017-01-17 01:15:54.000000000 +0100
@@ -673,20 +673,49 @@
guint request_id;
} FormAuthRequestData;
+static FormAuthRequestData *
+form_auth_request_data_new (EphyWebView *web_view,
+ guint request_id)
+{
+ FormAuthRequestData *data;
+ data = g_slice_new (FormAuthRequestData);
+ data->web_view = web_view;
+ data->request_id = request_id;
+ return data;
+}
+
+static void
+form_auth_request_data_free (FormAuthRequestData *data)
+{
+ g_slice_free (FormAuthRequestData, data);
+}
+
+static void
+form_auth_save_confirmation_info_bar_destroyed_cb (FormAuthRequestData *data,
+ GObject *where_the_info_bar_was)
+{
+ /* Ensure the hash table entry in the web process is removed. */
+ if (data->web_view->web_extension)
+ ephy_web_extension_proxy_form_auth_data_save_confirmation_response (data->web_view->web_extension,
+ data->request_id,
+ FALSE);
+ form_auth_request_data_free (data);
+}
+
static void
form_auth_data_save_confirmation_response (GtkInfoBar *info_bar,
gint response_id,
FormAuthRequestData *data)
{
- gtk_widget_destroy (GTK_WIDGET (info_bar));
-
if (data->web_view->web_extension) {
ephy_web_extension_proxy_form_auth_data_save_confirmation_response (data->web_view->web_extension,
data->request_id,
response_id == GTK_RESPONSE_YES);
}
- g_slice_free (FormAuthRequestData, data);
+ g_object_weak_unref (G_OBJECT (info_bar), (GWeakNotify)form_auth_save_confirmation_info_bar_destroyed_cb, data);
+ gtk_widget_destroy (GTK_WIDGET (info_bar));
+ form_auth_request_data_free (data);
}
static void
@@ -711,12 +740,11 @@
}
info_bar = ephy_web_view_create_form_auth_save_confirmation_info_bar (web_view, hostname, username);
- data = g_slice_new (FormAuthRequestData);
- data->web_view = web_view;
- data->request_id = request_id;
+ data = form_auth_request_data_new (web_view, request_id);
g_signal_connect (info_bar, "response",
G_CALLBACK (form_auth_data_save_confirmation_response),
data);
+ g_object_weak_ref (G_OBJECT (info_bar), (GWeakNotify)form_auth_save_confirmation_info_bar_destroyed_cb, data);
gtk_widget_show (info_bar);
}
@@ -1238,8 +1266,39 @@
typedef struct {
EphyWebView *web_view;
WebKitPermissionRequest *request;
+ char *host;
} PermissionRequestData;
+static PermissionRequestData *
+permission_request_data_new (EphyWebView *web_view,
+ WebKitPermissionRequest *request,
+ const char *host)
+{
+ PermissionRequestData *data;
+ data = g_new (PermissionRequestData, 1);
+ data->web_view = web_view;
+ /* Ref the decision to keep it alive while we decide */
+ data->request = g_object_ref (request);
+ data->host = g_strdup (host);
+ return data;
+}
+
+static void
+permission_request_data_free (PermissionRequestData *data)
+{
+ g_object_unref (data->request);
+ g_free (data->host);
+ g_slice_free (PermissionRequestData, data);
+}
+
+static void
+permission_request_info_bar_destroyed_cb (PermissionRequestData *data,
+ GObject *where_the_info_bar_was)
+{
+ webkit_permission_request_deny (data->request);
+ permission_request_data_free (data);
+}
+
static void
decide_on_permission_request (GtkWidget *info_bar,
int response,
@@ -1260,14 +1319,14 @@
EphyHostsManager *hosts_manager = ephy_embed_shell_get_hosts_manager (ephy_embed_shell_get_default ());
ephy_hosts_manager_set_notifications_permission_for_address (
hosts_manager,
- address,
+ data->host,
response == GTK_RESPONSE_YES ? EPHY_HOST_PERMISSION_ALLOW : EPHY_HOST_PERMISSION_DENY);
}
}
+ g_object_weak_unref (G_OBJECT (info_bar), (GWeakNotify)permission_request_info_bar_destroyed_cb, data);
gtk_widget_destroy (info_bar);
- g_object_unref (data->request);
- g_slice_free (PermissionRequestData, data);
+ permission_request_data_free (data);
}
static gboolean
@@ -1333,8 +1392,6 @@
host);
}
- g_free (host);
-
label = gtk_label_new (NULL);
gtk_label_set_markup (GTK_LABEL (label), message);
gtk_label_set_line_wrap (GTK_LABEL (label), TRUE);
@@ -1346,14 +1403,12 @@
gtk_widget_show_all (info_bar);
- /* Ref the decision, to keep it alive while we decide */
- data = g_new (PermissionRequestData, 1);
- data->web_view = EPHY_WEB_VIEW (web_view);
- data->request = g_object_ref (decision);
-
+ data = permission_request_data_new (EPHY_WEB_VIEW (web_view), decision, host);
g_signal_connect (info_bar, "response",
G_CALLBACK (decide_on_permission_request),
data);
+ g_object_weak_ref (G_OBJECT (info_bar), (GWeakNotify)permission_request_info_bar_destroyed_cb, data);
+ g_free (host);
if (WEBKIT_IS_GEOLOCATION_PERMISSION_REQUEST (decision))
ephy_web_view_track_info_bar (info_bar, &EPHY_WEB_VIEW (web_view)->geolocation_info_bar);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/embed/web-extension/ephy-web-extension.c new/epiphany-3.22.5/embed/web-extension/ephy-web-extension.c
--- old/epiphany-3.22.4/embed/web-extension/ephy-web-extension.c 2016-12-28 01:21:44.000000000 +0100
+++ new/epiphany-3.22.5/embed/web-extension/ephy-web-extension.c 2017-01-17 01:15:54.000000000 +0100
@@ -280,17 +280,20 @@
gpointer user_data)
{
EphyEmbedFormAuth *form_auth = EPHY_EMBED_FORM_AUTH (user_data);
+ char *password_field_value = NULL;
+
+ g_object_get (ephy_embed_form_auth_get_password_node (form_auth),
+ "value", &password_field_value, NULL);
+ if (password_field_value == NULL || strlen (password_field_value) == 0)
+ goto out;
if (password) {
WebKitDOMNode *username_node;
char *username_field_value = NULL;
- char *password_field_value = NULL;
username_node = ephy_embed_form_auth_get_username_node (form_auth);
if (username_node)
g_object_get (username_node, "value", &username_field_value, NULL);
- g_object_get (ephy_embed_form_auth_get_password_node (form_auth),
- "value", &password_field_value, NULL);
/* FIXME: We use only the first result, for now; We need to do
* something smarter here */
@@ -303,11 +306,14 @@
}
g_free (username_field_value);
- g_free (password_field_value);
} else {
LOG ("No result on query; asking whether we should store.");
request_decision_on_storing (g_object_ref (form_auth));
}
+
+out:
+ if (password_field_value != NULL)
+ g_free (password_field_value);
}
static gboolean
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/lib/widgets/ephy-download-widget.c new/epiphany-3.22.5/lib/widgets/ephy-download-widget.c
--- old/epiphany-3.22.4/lib/widgets/ephy-download-widget.c 2016-12-28 01:21:44.000000000 +0100
+++ new/epiphany-3.22.5/lib/widgets/ephy-download-widget.c 2017-01-17 01:15:54.000000000 +0100
@@ -66,11 +66,11 @@
if (!dest)
return NULL;
- basename = g_filename_display_basename (dest);
- decoded = ephy_uri_decode (basename);
- g_free (basename);
+ decoded = ephy_uri_decode (dest);
+ basename = g_filename_display_basename (decoded);
+ g_free (decoded);
- return decoded;
+ return basename;
}
/* modified from telepathy-account-widgets/tpaw-time.c */
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/src/epiphany-resources.c new/epiphany-3.22.5/src/epiphany-resources.c
--- old/epiphany-3.22.4/src/epiphany-resources.c 2016-12-28 01:28:13.000000000 +0100
+++ new/epiphany-3.22.5/src/epiphany-resources.c 2017-01-17 01:25:40.000000000 +0100
@@ -6,7 +6,7 @@
# define SECTION
#endif
-static const SECTION union { const guint8 data[45996]; const double alignment; void * const ptr;} epiphany_resource_data = { {
+static const SECTION union { const guint8 data[46156]; const double alignment; void * const ptr;} epiphany_resource_data = { {
0x47, 0x56, 0x61, 0x72, 0x69, 0x61, 0x6e, 0x74,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x18, 0x00, 0x00, 0x00, 0xdc, 0x02, 0x00, 0x00,
@@ -41,64 +41,64 @@
0x77, 0x38, 0x00, 0x00, 0xb2, 0x46, 0x46, 0x28,
0x17, 0x00, 0x00, 0x00, 0x77, 0x38, 0x00, 0x00,
0x0c, 0x00, 0x76, 0x00, 0x88, 0x38, 0x00, 0x00,
- 0x09, 0x4d, 0x00, 0x00, 0x78, 0x9c, 0xc8, 0x7a,
- 0x17, 0x00, 0x00, 0x00, 0x09, 0x4d, 0x00, 0x00,
- 0x11, 0x00, 0x76, 0x00, 0x20, 0x4d, 0x00, 0x00,
- 0x2f, 0x55, 0x00, 0x00, 0xc5, 0x01, 0x74, 0x8d,
- 0x17, 0x00, 0x00, 0x00, 0x2f, 0x55, 0x00, 0x00,
- 0x0f, 0x00, 0x76, 0x00, 0x40, 0x55, 0x00, 0x00,
- 0x8b, 0x5e, 0x00, 0x00, 0x2a, 0x3d, 0x8f, 0xff,
- 0x17, 0x00, 0x00, 0x00, 0x8b, 0x5e, 0x00, 0x00,
- 0x1c, 0x00, 0x76, 0x00, 0xa8, 0x5e, 0x00, 0x00,
- 0x2f, 0x66, 0x00, 0x00, 0xb0, 0xb7, 0x24, 0x30,
- 0x0e, 0x00, 0x00, 0x00, 0x2f, 0x66, 0x00, 0x00,
- 0x06, 0x00, 0x4c, 0x00, 0x38, 0x66, 0x00, 0x00,
- 0x3c, 0x66, 0x00, 0x00, 0xad, 0xf1, 0xdf, 0xa2,
- 0x17, 0x00, 0x00, 0x00, 0x3c, 0x66, 0x00, 0x00,
- 0x12, 0x00, 0x76, 0x00, 0x50, 0x66, 0x00, 0x00,
- 0x5f, 0x6a, 0x00, 0x00, 0xe6, 0x7b, 0x45, 0x07,
- 0x17, 0x00, 0x00, 0x00, 0x5f, 0x6a, 0x00, 0x00,
- 0x0f, 0x00, 0x76, 0x00, 0x70, 0x6a, 0x00, 0x00,
- 0x7f, 0x7a, 0x00, 0x00, 0x19, 0xfa, 0xa6, 0xb3,
- 0x17, 0x00, 0x00, 0x00, 0x7f, 0x7a, 0x00, 0x00,
- 0x16, 0x00, 0x76, 0x00, 0x98, 0x7a, 0x00, 0x00,
- 0xa7, 0x7e, 0x00, 0x00, 0x95, 0x8b, 0x84, 0xb4,
- 0x17, 0x00, 0x00, 0x00, 0xa7, 0x7e, 0x00, 0x00,
- 0x14, 0x00, 0x76, 0x00, 0xc0, 0x7e, 0x00, 0x00,
- 0xcf, 0x82, 0x00, 0x00, 0x4b, 0x50, 0x90, 0x0b,
- 0x14, 0x00, 0x00, 0x00, 0xcf, 0x82, 0x00, 0x00,
- 0x04, 0x00, 0x4c, 0x00, 0xd4, 0x82, 0x00, 0x00,
- 0xd8, 0x82, 0x00, 0x00, 0x17, 0x38, 0xe0, 0x94,
- 0x02, 0x00, 0x00, 0x00, 0xd8, 0x82, 0x00, 0x00,
- 0x09, 0x00, 0x76, 0x00, 0xe8, 0x82, 0x00, 0x00,
- 0xf7, 0x8a, 0x00, 0x00, 0x55, 0x9b, 0x9a, 0x71,
- 0x17, 0x00, 0x00, 0x00, 0xf7, 0x8a, 0x00, 0x00,
- 0x0f, 0x00, 0x76, 0x00, 0x08, 0x8b, 0x00, 0x00,
- 0x17, 0x8d, 0x00, 0x00, 0x0c, 0xac, 0xa7, 0x6b,
- 0x17, 0x00, 0x00, 0x00, 0x17, 0x8d, 0x00, 0x00,
- 0x13, 0x00, 0x76, 0x00, 0x30, 0x8d, 0x00, 0x00,
- 0x3f, 0x95, 0x00, 0x00, 0x9b, 0xea, 0x55, 0x32,
- 0x17, 0x00, 0x00, 0x00, 0x3f, 0x95, 0x00, 0x00,
- 0x15, 0x00, 0x76, 0x00, 0x58, 0x95, 0x00, 0x00,
- 0x32, 0x9a, 0x00, 0x00, 0x95, 0x15, 0xaf, 0xf5,
- 0x17, 0x00, 0x00, 0x00, 0x32, 0x9a, 0x00, 0x00,
- 0x13, 0x00, 0x76, 0x00, 0x48, 0x9a, 0x00, 0x00,
- 0x57, 0x9e, 0x00, 0x00, 0xd4, 0xb5, 0x02, 0x00,
- 0xff, 0xff, 0xff, 0xff, 0x57, 0x9e, 0x00, 0x00,
- 0x01, 0x00, 0x4c, 0x00, 0x58, 0x9e, 0x00, 0x00,
- 0x5c, 0x9e, 0x00, 0x00, 0x1c, 0xb2, 0xe8, 0x27,
- 0x17, 0x00, 0x00, 0x00, 0x5c, 0x9e, 0x00, 0x00,
- 0x1f, 0x00, 0x76, 0x00, 0x80, 0x9e, 0x00, 0x00,
- 0x2c, 0xa3, 0x00, 0x00, 0x63, 0xf4, 0x89, 0x16,
- 0x17, 0x00, 0x00, 0x00, 0x2c, 0xa3, 0x00, 0x00,
- 0x1d, 0x00, 0x76, 0x00, 0x50, 0xa3, 0x00, 0x00,
- 0x33, 0xb0, 0x00, 0x00, 0xfd, 0xcf, 0x01, 0xdf,
- 0x09, 0x00, 0x00, 0x00, 0x33, 0xb0, 0x00, 0x00,
- 0x09, 0x00, 0x4c, 0x00, 0x3c, 0xb0, 0x00, 0x00,
- 0x88, 0xb0, 0x00, 0x00, 0x37, 0x9c, 0x42, 0xfc,
- 0x17, 0x00, 0x00, 0x00, 0x88, 0xb0, 0x00, 0x00,
- 0x1a, 0x00, 0x76, 0x00, 0xa8, 0xb0, 0x00, 0x00,
- 0xac, 0xb3, 0x00, 0x00, 0x69, 0x6e, 0x63, 0x6f,
+ 0xae, 0x4d, 0x00, 0x00, 0x78, 0x9c, 0xc8, 0x7a,
+ 0x17, 0x00, 0x00, 0x00, 0xae, 0x4d, 0x00, 0x00,
+ 0x11, 0x00, 0x76, 0x00, 0xc0, 0x4d, 0x00, 0x00,
+ 0xcf, 0x55, 0x00, 0x00, 0xc5, 0x01, 0x74, 0x8d,
+ 0x17, 0x00, 0x00, 0x00, 0xcf, 0x55, 0x00, 0x00,
+ 0x0f, 0x00, 0x76, 0x00, 0xe0, 0x55, 0x00, 0x00,
+ 0x2b, 0x5f, 0x00, 0x00, 0x2a, 0x3d, 0x8f, 0xff,
+ 0x17, 0x00, 0x00, 0x00, 0x2b, 0x5f, 0x00, 0x00,
+ 0x1c, 0x00, 0x76, 0x00, 0x48, 0x5f, 0x00, 0x00,
+ 0xcf, 0x66, 0x00, 0x00, 0xb0, 0xb7, 0x24, 0x30,
+ 0x0e, 0x00, 0x00, 0x00, 0xcf, 0x66, 0x00, 0x00,
+ 0x06, 0x00, 0x4c, 0x00, 0xd8, 0x66, 0x00, 0x00,
+ 0xdc, 0x66, 0x00, 0x00, 0xad, 0xf1, 0xdf, 0xa2,
+ 0x17, 0x00, 0x00, 0x00, 0xdc, 0x66, 0x00, 0x00,
+ 0x12, 0x00, 0x76, 0x00, 0xf0, 0x66, 0x00, 0x00,
+ 0xff, 0x6a, 0x00, 0x00, 0xe6, 0x7b, 0x45, 0x07,
+ 0x17, 0x00, 0x00, 0x00, 0xff, 0x6a, 0x00, 0x00,
+ 0x0f, 0x00, 0x76, 0x00, 0x10, 0x6b, 0x00, 0x00,
+ 0x1f, 0x7b, 0x00, 0x00, 0x19, 0xfa, 0xa6, 0xb3,
+ 0x17, 0x00, 0x00, 0x00, 0x1f, 0x7b, 0x00, 0x00,
+ 0x16, 0x00, 0x76, 0x00, 0x38, 0x7b, 0x00, 0x00,
+ 0x47, 0x7f, 0x00, 0x00, 0x95, 0x8b, 0x84, 0xb4,
+ 0x17, 0x00, 0x00, 0x00, 0x47, 0x7f, 0x00, 0x00,
+ 0x14, 0x00, 0x76, 0x00, 0x60, 0x7f, 0x00, 0x00,
+ 0x6f, 0x83, 0x00, 0x00, 0x4b, 0x50, 0x90, 0x0b,
+ 0x14, 0x00, 0x00, 0x00, 0x6f, 0x83, 0x00, 0x00,
+ 0x04, 0x00, 0x4c, 0x00, 0x74, 0x83, 0x00, 0x00,
+ 0x78, 0x83, 0x00, 0x00, 0x17, 0x38, 0xe0, 0x94,
+ 0x02, 0x00, 0x00, 0x00, 0x78, 0x83, 0x00, 0x00,
+ 0x09, 0x00, 0x76, 0x00, 0x88, 0x83, 0x00, 0x00,
+ 0x97, 0x8b, 0x00, 0x00, 0x55, 0x9b, 0x9a, 0x71,
+ 0x17, 0x00, 0x00, 0x00, 0x97, 0x8b, 0x00, 0x00,
+ 0x0f, 0x00, 0x76, 0x00, 0xa8, 0x8b, 0x00, 0x00,
+ 0xb7, 0x8d, 0x00, 0x00, 0x0c, 0xac, 0xa7, 0x6b,
+ 0x17, 0x00, 0x00, 0x00, 0xb7, 0x8d, 0x00, 0x00,
+ 0x13, 0x00, 0x76, 0x00, 0xd0, 0x8d, 0x00, 0x00,
+ 0xdf, 0x95, 0x00, 0x00, 0x9b, 0xea, 0x55, 0x32,
+ 0x17, 0x00, 0x00, 0x00, 0xdf, 0x95, 0x00, 0x00,
+ 0x15, 0x00, 0x76, 0x00, 0xf8, 0x95, 0x00, 0x00,
+ 0xd2, 0x9a, 0x00, 0x00, 0x95, 0x15, 0xaf, 0xf5,
+ 0x17, 0x00, 0x00, 0x00, 0xd2, 0x9a, 0x00, 0x00,
+ 0x13, 0x00, 0x76, 0x00, 0xe8, 0x9a, 0x00, 0x00,
+ 0xf7, 0x9e, 0x00, 0x00, 0xd4, 0xb5, 0x02, 0x00,
+ 0xff, 0xff, 0xff, 0xff, 0xf7, 0x9e, 0x00, 0x00,
+ 0x01, 0x00, 0x4c, 0x00, 0xf8, 0x9e, 0x00, 0x00,
+ 0xfc, 0x9e, 0x00, 0x00, 0x1c, 0xb2, 0xe8, 0x27,
+ 0x17, 0x00, 0x00, 0x00, 0xfc, 0x9e, 0x00, 0x00,
+ 0x1f, 0x00, 0x76, 0x00, 0x20, 0x9f, 0x00, 0x00,
+ 0xcc, 0xa3, 0x00, 0x00, 0x63, 0xf4, 0x89, 0x16,
+ 0x17, 0x00, 0x00, 0x00, 0xcc, 0xa3, 0x00, 0x00,
+ 0x1d, 0x00, 0x76, 0x00, 0xf0, 0xa3, 0x00, 0x00,
+ 0xd3, 0xb0, 0x00, 0x00, 0xfd, 0xcf, 0x01, 0xdf,
+ 0x09, 0x00, 0x00, 0x00, 0xd3, 0xb0, 0x00, 0x00,
+ 0x09, 0x00, 0x4c, 0x00, 0xdc, 0xb0, 0x00, 0x00,
+ 0x28, 0xb1, 0x00, 0x00, 0x37, 0x9c, 0x42, 0xfc,
+ 0x17, 0x00, 0x00, 0x00, 0x28, 0xb1, 0x00, 0x00,
+ 0x1a, 0x00, 0x76, 0x00, 0x48, 0xb1, 0x00, 0x00,
+ 0x4c, 0xb4, 0x00, 0x00, 0x69, 0x6e, 0x63, 0x6f,
0x67, 0x6e, 0x69, 0x74, 0x6f, 0x2e, 0x70, 0x6e,
0x67, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0xfd, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
@@ -1816,7 +1816,7 @@
0x00, 0x28, 0x75, 0x75, 0x61, 0x79, 0x29, 0x65,
0x70, 0x69, 0x70, 0x68, 0x61, 0x6e, 0x79, 0x2e,
0x63, 0x73, 0x73, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x71, 0x14, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x16, 0x15, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x62, 0x75, 0x74, 0x74, 0x6f, 0x6e, 0x2e, 0x61,
0x63, 0x74, 0x69, 0x76, 0x65, 0x2d, 0x6d, 0x65,
0x6e, 0x75, 0x20, 0x7b, 0x0a, 0x20, 0x20, 0x63,
@@ -2471,10 +2471,30 @@
0x20, 0x20, 0x20, 0x20, 0x20, 0x62, 0x6f, 0x78,
0x2d, 0x73, 0x68, 0x61, 0x64, 0x6f, 0x77, 0x3a,
0x20, 0x6e, 0x6f, 0x6e, 0x65, 0x3b, 0x20, 0x7d,
- 0x0a, 0x00, 0x00, 0x28, 0x75, 0x75, 0x61, 0x79,
- 0x29, 0x68, 0x69, 0x73, 0x74, 0x6f, 0x72, 0x79,
- 0x2d, 0x64, 0x69, 0x61, 0x6c, 0x6f, 0x67, 0x2e,
- 0x75, 0x69, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x0a, 0x0a, 0x2f, 0x2a, 0x20, 0x22, 0x50, 0x72,
+ 0x65, 0x73, 0x73, 0x20, 0x24, 0x4b, 0x45, 0x59,
+ 0x20, 0x74, 0x6f, 0x20, 0x65, 0x78, 0x69, 0x74,
+ 0x20, 0x66, 0x75, 0x6c, 0x6c, 0x73, 0x63, 0x72,
+ 0x65, 0x65, 0x6e, 0x22, 0x20, 0x6f, 0x76, 0x65,
+ 0x72, 0x6c, 0x61, 0x79, 0x20, 0x74, 0x65, 0x78,
+ 0x74, 0x20, 0x2a, 0x2f, 0x0a, 0x23, 0x66, 0x75,
+ 0x6c, 0x6c, 0x73, 0x63, 0x72, 0x65, 0x65, 0x6e,
+ 0x2d, 0x70, 0x6f, 0x70, 0x75, 0x70, 0x20, 0x7b,
+ 0x0a, 0x20, 0x20, 0x70, 0x61, 0x64, 0x64, 0x69,
+ 0x6e, 0x67, 0x3a, 0x20, 0x31, 0x32, 0x70, 0x78,
+ 0x3b, 0x0a, 0x20, 0x20, 0x62, 0x6f, 0x72, 0x64,
+ 0x65, 0x72, 0x2d, 0x72, 0x61, 0x64, 0x69, 0x75,
+ 0x73, 0x3a, 0x20, 0x31, 0x38, 0x70, 0x78, 0x3b,
+ 0x0a, 0x20, 0x20, 0x62, 0x61, 0x63, 0x6b, 0x67,
+ 0x72, 0x6f, 0x75, 0x6e, 0x64, 0x3a, 0x20, 0x72,
+ 0x67, 0x62, 0x61, 0x28, 0x30, 0x2c, 0x20, 0x30,
+ 0x2c, 0x20, 0x30, 0x2c, 0x20, 0x30, 0x2e, 0x36,
+ 0x35, 0x29, 0x3b, 0x0a, 0x20, 0x20, 0x63, 0x6f,
+ 0x6c, 0x6f, 0x72, 0x3a, 0x20, 0x77, 0x68, 0x69,
+ 0x74, 0x65, 0x3b, 0x20, 0x7d, 0x0a, 0x00, 0x00,
+ 0x28, 0x75, 0x75, 0x61, 0x79, 0x29, 0x68, 0x69,
+ 0x73, 0x74, 0x6f, 0x72, 0x79, 0x2d, 0x64, 0x69,
+ 0x61, 0x6c, 0x6f, 0x67, 0x2e, 0x75, 0x69, 0x00,
0xd2, 0x1a, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
0x78, 0xda, 0xe5, 0x59, 0x4b, 0x6f, 0xdb, 0x38,
0x10, 0xbe, 0xf7, 0x57, 0x68, 0x79, 0x5d, 0xa8,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.22.4/src/resources/epiphany.css new/epiphany-3.22.5/src/resources/epiphany.css
--- old/epiphany-3.22.4/src/resources/epiphany.css 2016-12-28 01:21:44.000000000 +0100
+++ new/epiphany-3.22.5/src/resources/epiphany.css 2017-01-17 01:15:54.000000000 +0100
@@ -125,3 +125,10 @@
box-shadow: inset 0 0 0 1px #4a90d9; }
.incognito-mode.titlebar entry:backdrop {
box-shadow: none; }
+
+/* "Press $KEY to exit fullscreen" overlay text */
+#fullscreen-popup {
+ padding: 12px;
+ border-radius: 18px;
+ background: rgba(0, 0, 0, 0.65);
+ color: white; }