[opensuse-buildservice] rep_server.log flooded with perl warnings
Hi all, on my private OBS instance, rep_server.log is flooded with Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382. Any ideas what could be causing this? Could this be cauused by typos in BSConfig.pm? Server version is obs-server-2.7.1-4.1.noarch. rpm --verify says: S.5....T. c /usr/lib/obs/server/BSConfig.pm /var/cache/ should be root:root 0755. (wrong permissions 1777) TIA, Martin -- A: Yes.
Q: Are you sure?
A: Because it reverses the logical flow of conversation.
Q: Why is top posting frowned upon?
| Martin Weber | Razorcat Development GmbH | Witzlebenplatz 4 fon: +49-(30)-536 357 46 | 14057 Berlin fax: +49-(30)-536 357 60 | |-------------------------------------------- | Geschäftsführer: Michael Wittner | Sitz der Gesellschaft: Berlin | Amtsgericht: Berlin, HRB 65326 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Am Montag, 22. August 2016, 14:40:06 CEST schrieb Martin Weber:
Hi all,
on my private OBS instance, rep_server.log is flooded with
Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382.
Any ideas what could be causing this?
Line 378: $r = sysread(...) if $l; seems to fail ($r gets set to undef which causes the warnings afterwards). My guess would be badblocks on the disk (dmesg should show some errors). You could try it with my patched version. Maybe you could find out which files are broken: https://github.com/M0ses/open-build-service/commit/ 028801dda1398546df005ce5e7fac3969c0d48c9 https://raw.githubusercontent.com/M0ses/open-build-service/ fix_sysread_problems/src/backend/BSHTTP.pm
Could this be cauused by typos in BSConfig.pm?
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Am 22.08.2016 um 15:40 schrieb Frank Schreiner:
Am Montag, 22. August 2016, 14:40:06 CEST schrieb Martin Weber:
Hi all,
on my private OBS instance, rep_server.log is flooded with
Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382.
Any ideas what could be causing this?
Line 378: $r = sysread(...) if $l;
seems to fail ($r gets set to undef which causes the warnings afterwards). My guess would be badblocks on the disk (dmesg should show some errors).
That's a perfect guess! Indeed there are 2 inodes with checksum errors reported (btrfs). Will try to repair... -- A: Yes.
Q: Are you sure?
A: Because it reverses the logical flow of conversation.
Q: Why is top posting frowned upon?
| Martin Weber | Razorcat Development GmbH | Witzlebenplatz 4 fon: +49-(30)-536 357 46 | 14057 Berlin fax: +49-(30)-536 357 60 | |-------------------------------------------- | Geschäftsführer: Michael Wittner | Sitz der Gesellschaft: Berlin | Amtsgericht: Berlin, HRB 65326 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 2016-08-22 14:40:06 +0200, Martin Weber wrote:
on my private OBS instance, rep_server.log is flooded with
Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382.
Any ideas what could be causing this?
It seems that the previous sysread failed - the question is why:) Probably this needs some manual debugging... can you add something like print "sysread: $! (filename: " . (ref($filename) ? 'ref' : $filename) . ")\n" unless defined($r); after line 378 in BSHTTP.pm? Then, restart the repserver and try it again. Also, please post some more lines from the rep_server.log (for instance, the api call that causes these errors).
Could this be cauused by typos in BSConfig.pm?
No. Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 2016-08-22 16:06:17 +0200, Marcus Hüwe wrote:
On 2016-08-22 14:40:06 +0200, Martin Weber wrote:
on my private OBS instance, rep_server.log is flooded with
Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382.
Any ideas what could be causing this?
It seems that the previous sysread failed - the question is why:) Probably this needs some manual debugging... can you add something like
print "sysread: $! (filename: " . (ref($filename) ? 'ref' : $filename) . ")\n" unless defined($r);
after line 378 in BSHTTP.pm? Then, restart the repserver and try it again. Also, please post some more lines from the rep_server.log (for instance, the api call that causes these errors).
Oops... I was too late - simply use Frank's patched file:) Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Am 22.08.2016 um 16:06 schrieb Marcus Hüwe:
On 2016-08-22 14:40:06 +0200, Martin Weber wrote:
on my private OBS instance, rep_server.log is flooded with
Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 379. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 382.
[..] print "sysread: $! (filename: " . (ref($filename) ? 'ref' : $filename) . ")\n" unless defined($r);
I added it. Log excerpt follows: 2016-08-22 16:17:55 [12498]: GET /getbinaries?project=Debian:8&repository=standard&arch=armv7l&binaries=base-passwd,user-setup [truncated...] sysread: Input/output error (filename: /srv/obs/build/Debian:8/standard/armv7l/:full/ncurses-bin.deb) Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 380. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 383. sysread: Input/output error (filename: /srv/obs/build/Debian:8/standard/armv7l/:full/ncurses-bin.deb) Use of uninitialized value $r in numeric eq (==) at BSHTTP.pm line 380. Use of uninitialized value $r in subtraction (-) at BSHTTP.pm line 383. Martin -- A: Yes.
Q: Are you sure?
A: Because it reverses the logical flow of conversation.
Q: Why is top posting frowned upon?
| Martin Weber | Razorcat Development GmbH | Witzlebenplatz 4 fon: +49-(30)-536 357 46 | 14057 Berlin fax: +49-(30)-536 357 60 | |-------------------------------------------- | Geschäftsführer: Michael Wittner | Sitz der Gesellschaft: Berlin | Amtsgericht: Berlin, HRB 65326 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (3)
-
Frank Schreiner -
Marcus Hüwe -
Martin Weber