[opensuse-buildservice] [PATCH] commandline: improve ENOTDIR error message for validators
WARNING: source_validator_directory configured but it does not exist:
/usr/lib/osc/source_validators
Install osc-source_validator to fix.
Signed-off-by: Brandon Philips
Hi
Dne Thu, 18 Nov 2010 13:47:01 -0800
Brandon Philips
WARNING: source_validator_directory configured but it does not exist: /usr/lib/osc/source_validators Install osc-source_validator to fix.
Are you sure that three lines warning is better than one line? And is the warning really needed given that the configuration is default? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
I've runned across something very close to that in the past...
What I did (openSUSE 11.3):
Copy .repo[1] file to /etc/zypp/repos.d followed by zypper ref.
Then "zypper in osc-source_validator", which should pull
"osc-plugin-collab-0.92-2.1.x86_64" as a dependency.
After that, no longer I got the reported error. Hope this helps.
Nelson
[1] - http://download.opensuse.org/repositories/openSUSE:/Tools/openSUSE_11.3/open...
2010/11/18 Michal Čihař
Hi
Dne Thu, 18 Nov 2010 13:47:01 -0800 Brandon Philips
napsal(a): WARNING: source_validator_directory configured but it does not exist: /usr/lib/osc/source_validators Install osc-source_validator to fix.
Are you sure that three lines warning is better than one line?
And is the warning really needed given that the configuration is default?
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
-- nelson marques nmo.marques@gmail.com -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi
Dne Thu, 18 Nov 2010 23:58:31 +0000
Nelson Marques
I've runned across something very close to that in the past... What I did (openSUSE 11.3):
Copy .repo[1] file to /etc/zypp/repos.d followed by zypper ref.
Then "zypper in osc-source_validator", which should pull "osc-plugin-collab-0.92-2.1.x86_64" as a dependency.
After that, no longer I got the reported error. Hope this helps.
I know how to install that package. However if it is required for osc, then the package should have a dependency. If not, osc should not complain that verbosely on each run. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Am Freitag, 19. November 2010, 07:51:28 schrieb Michal Čihař:
Hi
Dne Thu, 18 Nov 2010 23:58:31 +0000 Nelson Marques
napsal(a): I've runned across something very close to that in the past... What I did (openSUSE 11.3):
Copy .repo[1] file to /etc/zypp/repos.d followed by zypper ref.
Then "zypper in osc-source_validator", which should pull "osc-plugin-collab-0.92-2.1.x86_64" as a dependency.
After that, no longer I got the reported error. Hope this helps.
I know how to install that package. However if it is required for osc, then the package should have a dependency. If not, osc should not complain that verbosely on each run.
It has a "Recommended:" to that package on the distros that support that. It works still without, but we like to get the sources in a common shape by default and it also helps to find some common pitfalls. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Thanks, patch got imported. Am Donnerstag, 18. November 2010, 22:47:01 schrieb Brandon Philips:
WARNING: source_validator_directory configured but it does not exist: /usr/lib/osc/source_validators Install osc-source_validator to fix.
Signed-off-by: Brandon Philips
--- osc/commandline.py | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/osc/commandline.py b/osc/commandline.py index 0fd14b7..2683ae7 100644 --- a/osc/commandline.py +++ b/osc/commandline.py @@ -3032,7 +3032,9 @@ Please submit there instead, or use --nodevelproject to force direct submission. if opts.skip_validation: validators = None elif not os.path.exists(validators): - print "WARNING: validator directory", validators, "configured, but not existing (please install osc-source_validator). Skipping ..." + print "WARNING: source_validator_directory configured but it "\ + "does not exist:\n\t %s \n"\ + "\t Install osc-source_validator to fix." % validators validators = None
msg = ''
-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (4)
-
Adrian Schröter
-
Brandon Philips
-
Michal Čihař
-
Nelson Marques