[opensuse-buildservice] Support for --changelog removed from osc build
Hi, I just noticed that support for --changelog was removed from "osc build" This breaks local debian builds for people using {package}.changes (since there will be no entry describing the release). Can it please be added back? andrew --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi Andrew, On Mon, Aug 13, 2007 at 02:06:49PM +0200, Andrew Beekhof wrote:
I just noticed that support for --changelog was removed from "osc build" This breaks local debian builds for people using {package}.changes (since there will be no entry describing the release).
Hm, let me get this right. Since I don't know of such an option, I suspect it was something which was ignored by osc, but passed through to build? build --help doesn't list it though. What does it do exactly?
Can it please be added back?
Yes, I'll happy to add it to osc build if I know what it's for :) Peter -- "WARNING: This bug is visible to non-employees. Please be respectful!" SUSE LINUX Products GmbH Research & Development
On Aug 14, 2007, at 10:19 AM, Dr. Peter Poeml wrote:
Hi Andrew,
On Mon, Aug 13, 2007 at 02:06:49PM +0200, Andrew Beekhof wrote:
I just noticed that support for --changelog was removed from "osc build" This breaks local debian builds for people using {package}.changes (since there will be no entry describing the release).
Hm, let me get this right. Since I don't know of such an option, I suspect it was something which was ignored by osc, but passed through to build?
must have
build --help doesn't list it though.
What does it do exactly?
Can it please be added back?
Yes, I'll happy to add it to osc build if I know what it's for :)
it forces the execution of changelog2spec. i believe this is the default on the BS but obviously not for local builds. this is the (existing) code that i was trying to turn on from the command-line: beekhof@vmhost ~ $ grep -n changelog `which build` 329: *-changelog) 539: rm -f $BUILD_ROOT/.build-changelog 544: echo "running changelog2spec --target $CFFORMAT --file $MYSRCDIR/$SPECFILE" 545: if ! $BUILD_DIR/changelog2spec --target $CFFORMAT --file "$MYSRCDIR/$SPECFILE" > $BUILD_ROOT/.build-changelog ; then 546: rm -f $BUILD_ROOT/.build-changelog 695: test -n "$CHANGELOG" -a -f "$BUILD_ROOT/.build-changelog" && CHANGELOGARGS="--changelog $BUILD_ROOT/.build-changelog" Once I added the following, it all worked: beekhof@vmhost ~ $ grep -n changelog /usr/lib64/python2.5/site- packages/osc/build.py 220: if opts.changelog: 221: buildargs.append('--changelog') and: beekhof@vmhost ~ $ grep -n changelog /usr/lib64/python2.5/site- packages/osc/commandline.py 1299: @cmdln.option('--changelog', '--no-changelog', action='store_true', --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi Andrew, On Tue, Aug 14, 2007 at 12:51:18PM +0200, Andrew Beekhof wrote:
I just noticed that support for --changelog was removed from "osc build" This breaks local debian builds for people using {package}.changes (since there will be no entry describing the release).
it forces the execution of changelog2spec. i believe this is the default on the BS but obviously not for local builds.
I see.
1299: @cmdln.option('--changelog', '--no-changelog', action='store_true',
While I see that: the cmdln.option() works a bit different. It doesn't take a "no-" form. It takes different names for the same thing, like '-v', '--verbose' I am adding this: Index: osc/commandline.py =================================================================== --- osc/commandline.py (revision 1972) +++ osc/commandline.py (working copy) @@ -1287,6 +1287,8 @@ @cmdln.option('--clean', action='store_true', help='Delete old build root before initializing it') + @cmdln.option('--changelog', action='store_true', + help='Force update of package changelog from a changes file') @cmdln.option('--noinit', '--no-init', action='store_true', help='Skip initialization of build root and start with build immediately.') @cmdln.option('-p', '--prefer-pkgs', metavar='DIR', action='append', Index: osc/build.py =================================================================== --- osc/build.py (revision 1971) +++ osc/build.py (working copy) @@ -217,6 +217,8 @@ buildargs.append('--clean') if opts.noinit: buildargs.append('--noinit') + if opts.changelog: + buildargs.append('--changelog') buildargs = ' '.join(buildargs) Peter -- "WARNING: This bug is visible to non-employees. Please be respectful!" SUSE LINUX Products GmbH Research & Development
participants (2)
-
Andrew Beekhof -
Dr. Peter Poeml