It looks the buildroot got added twice somewhere.

Hi Marcus Here is the spec file. http://build.opensuse.org/package/edit_spec?package=gcompizthemer&project=Compiz-Quinn&file=gcompizthemer.spec Buildroot appear only once. Thanks -J --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice-unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice-help@opensuse.org

On Sat, Jul 08, 2006 at 10:54:31AM +0200, Marcus Meissner wrote:

On Sat, Jul 08, 2006 at 02:20:27PM +0530, Jigish Gohil wrote:

...

...

It looks the buildroot got added twice somewhere.

Hi Marcus

Here is the spec file.

http://build.opensuse.org/package/edit_spec?package=gcompizthemer&project=Compiz-Quinn&file=gcompizthemer.spec

You must add --mandir=%{_mandir} to the configure call.

One thing, the make DESTDIR=...install part belongs into the %install section.

In the %build section there should be just a "make" call.

There are more strange things left. Among of them are: - It does not make any sense to add an "|| exit 1" after the commands. rpmbuild stops anyway if a command fails. - Why on aerth do you add hundreds of parameters to the %setup macro just to work around problems they produce two lines later? Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."

I've looked over your spec file. So I try to explain some things a bit. It's you package so please use name-version.tar.bz2 so you can use Source: %{name}-%{version}.tar.bz2 ;) -- # norootforbuild norootforbuild is missing, I don't think you need root. -- BuildRequires: pkgconfig gtk2-devel gconf2-devel glib2-devel It's enough to add only the devel files, cause a devel file requries the original package :) -- PreReq: %fillup_prereq Autoreqprov: on should be on to check for requirements. -- %define _prefix /usr _prefix is /usr by default, so it isn't needed here ;) If you want another dir than /usr then redefine _prefix. For example: %define _prefix /opt/gnome %define _mandir /usr/share/man You have to redefine _mandir too or it would be /opt/gnome/share/man ... -- %files %defattr(-, root, root) %{_bindir}/gcompizthemer %{_datadir}/pixmaps/gcompizthemer-icon.png %{_mandir}/man?/*.%{ext_man} %{_datadir}/applications/gcompizthemer.desktop _bindir is _prefix/bin _datadir is _prefix/share ... There are more macros... _lib _libdir _includedir -- %clean section is missing to clean the buildroot %clean %__rm -rf %{buildroot} -- for make you should use the macro and build on more hosts if possible ;) %__make %{?jobs:-j %jobs} -- I've attached the fixed spec file. Cheers, -- andreas Jigish Gohil wrote:

...

- Why on aerth do you add hundreds of parameters to the %setup macro just to work around problems they produce two lines later?

Robert

There are many useless things in many of the spec files I am using, as I am quite new to this package building I copy/paste things over from other spec files and I leave most of the things I dont understand untouched, hopefully everything goes well, till something goes wrong.

Would anyone like to to help me clean up the spec files? In the process I would surely learn few things.

Thanks

-J

--------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice-unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice-help@opensuse.org

-- http://www.cynapses.org/ - cybernetic synapses # # spec file for package gcompizthemer (Version 0.7) # # Copyright (c) 2006 Quinnstorm. # This file and all modifications and additions to the pristine # package are under the same license as the package itself. # norootforbuild Name: gcompizthemer BuildRequires: pkgconfig gtk2-devel gconf2-devel glib2-devel Url: http://compiz.net License: X11/MIT, GPL Group: System/GUI/Other PreReq: %fillup_prereq Autoreqprov: on Version: 0.7 Release: 2 Summary: Easy to use Compiz Theme Configuration tool. Source: %{name}-%{version}.tar.bz2 BuildRoot: %{_tmppath}/%{name}-%{version}-build %description GCompizthemer is a easy to use Compiz theme configuration tool. Authors: -------- Quinnstorm %prep %setup -q %build %configure %__make %{?jobs:-j %jobs} %install %makeinstall %clean %__rm -rf %{buildroot} %files %defattr(-, root, root) %doc AUTHORS COPYING INSTALL README NEWS %{_bindir}/gcompizthemer %{_mandir}/man1/* %{_datadir}/pixmaps/gcompizthemer-icon.png %{_datadir}/applications/gcompizthemer.desktop %changelog -n gcompizthemer * Sat Jul 08 2006 cyberorg@cyberorg.info - Removed themes and moved them to new gcompizthemer-themes package * Tue Jul 04 2006 cyberorg@cyberorg.info - Initial spec

Am Saturday 08 July 2006 16:36 schrieb Andreas Schneider: ..

# norootforbuild

norootforbuild is missing, I don't think you need root.

this comment has no effect, everything gets build as user. -- Adrian Schroeter SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany email: adrian@suse.de --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice-unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice-help@opensuse.org