[opensuse-buildservice] understanding maintenance workflow, reverted fixes
Hi, I just run into a coreutils bug again which I fixed and sr'ed myself. Now I try to understand how could this happen. See the diff -r12:13 in openSUSE:11.4:Update/coreutils below. Why coreutils-cp-al-symlink-timestamp.patch was reverted. The osc commit log does not contain any message. This is really annoying. $ osc diff -r12:13 [...] Index: coreutils.spec =================================================================== --- coreutils.spec (revision 10) +++ coreutils.spec (revision 15) @@ -24,7 +24,7 @@ License: GFDLv1.2 ; GPLv2+ ; GPLv3+ Group: System/Base Version: 8.9 -Release: 5.<RELEASE7> +Release: 5.<RELEASE9> Provides: fileutils = %{version}, sh-utils = %{version}, stat = %version}, textutils = %{version}, mktemp = %{version} Obsoletes: fileutils < %{version}, sh-utils < %{version}, stat < %version}, textutils < %{version}, mktemp < %{version} Obsoletes: libselinux <= 1.23.11-3 libselinux-32bit = 9 libselinux-64bit = 9 libselinux-x86 = 9 @@ -56,8 +56,7 @@ Patch31: coreutils-getaddrinfo.patch Patch32: coreutils-ptr_int_casts.patch Patch33: coreutils-8.9-singlethreaded-sort.patch -# this patch is needed for coreutils 8.0 - 8.10 (openSUSE 11.3 and 11.4) -Patch34: coreutils-cp-al-symlink-timestamp.patch +Patch34: coreutils-bnc#697897-setsid.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build # this will create a cycle, broken up randomly - coreutils is just too core to have other # prerequires @@ -98,7 +97,8 @@ %patch31 %patch32 %patch33 -%patch34 -p1 +%patch34 + [...] cu, Rudi -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Tue, Jan 29, 2013 at 8:34 PM, Ruediger Meier
See the diff -r12:13 in openSUSE:11.4:Update/coreutils below. Why coreutils-cp-al-symlink-timestamp.patch was reverted. The osc commit log does not contain any message. This is really annoying.
The web interface commits without message. It didn't use to, the box that was there to be able to type a message was removed at one point. I'm not saying stuff like coreutils should be changed through the web interface, but it certainly cannot be right to have a web editor that doesn't allow you to do the sensible thing (which is to add a commit message). And sometimes the web interface is really handy for quick fixes. For instance, when I'm in debian (sorry, but happens) I can't "osc vc", so it's easier to add changelog entries with the web interface. I used to be able to attach a commit log for those, no longer the case now. I could have been a factor in this case. Just saying. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
And sometimes the web interface is really handy for quick fixes. For instance, when I'm in debian (sorry, but happens) I can't "osc vc", so it's easier to add changelog entries with the web interface. I used to be able to attach a commit log for those, no longer the case now.
Out of curiosity: Why? Isn't there a debian build of osc? -- Ralf Lang Linux Consultant / Developer Tel.: +49-170-6381563 Mail: lang@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Wed, Jan 30, 2013 at 08:24:23AM +0100, Ralf Lang wrote:
Out of curiosity: Why? Isn't there a debian build of osc?
It is present, but Debian stable packages are old (long release cycle). I tried osc vc on Debian stable: It fails: Error: you need build.rpm with version 2009.04.17 or newer Regards, Martin -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Wed, Jan 30, 2013 at 12:34:57AM +0100, Ruediger Meier wrote:
Hi,
I just run into a coreutils bug again which I fixed and sr'ed myself. Now I try to understand how could this happen.
See the diff -r12:13 in openSUSE:11.4:Update/coreutils below. Why coreutils-cp-al-symlink-timestamp.patch was reverted. The osc commit log does not contain any message. This is really annoying.
This happened before we changed to the new maintenance setup and was apparently not caught by the checkin team. Not sure what exactly Philipp did wrong when checking it out, but perhaps he branched from GA instead of Update. ------------------------------------------------------------------- Wed Jun 8 15:40:52 CEST 2011 - pth@suse.de - Fix vulnerability in su (bnc#697897). ------------------------------------------------------------------- Sat Apr 2 17:48:37 UTC 2011 - sweet_f_a@gmx.de - fix "cp -al does not preserve timestamps of symlinks" (bnc#696389, coreutils 8.0 - 8.10, openSUSE 11.3 and 11.4) I think these days this will not happen as both maintenance and review team have watchful eyes. Ciao, Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Quoting Ruediger Meier
Hi,
I just run into a coreutils bug again which I fixed and sr'ed myself. Now I try to understand how could this happen.
See the diff -r12:13 in openSUSE:11.4:Update/coreutils below. Why coreutils-cp-al-symlink-timestamp.patch was reverted. The osc commit log does not contain any message. This is really annoying.
I can't really say why this happens, but it underlines that a mention of it in .changes is HELPFUL! Be it only to know that this change was intentional and not just an accident (in the current form, it is unclear... it could as well be a package branched off the wrong tree and re-submitted). In general, SUCH CASES are the reason why the review team rejects ANY CHANGE to patches (addition, removal, 'commenting out') which are not mentioned in the .changes files. Hopefully we will be able to prevent such re-occurences in the future. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (6)
-
Claudio Freire -
Dominique Leuenberger a.k.a. Dimstar -
Marcus Meissner -
Martin Koegler -
Ralf Lang -
Ruediger Meier