[opensuse-buildservice] rpmlint and {non-,}executable-crontab-file
Hi, If I remove executable bits rpmlint complains about "non-executable-crontab-file" and vice-versa. Could we please fix that. Ciao -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi, On Monday 01 June 2009 19:10:38 Christian wrote:
If I remove executable bits rpmlint complains about "non-executable-crontab-file" and vice-versa.
Can you refer to a repository/package, .spec file and/or build log with the message? regards, Andreas -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hallo Andreas, Andreas Stieger schrieb:
Can you refer to a repository/package, .spec file and/or build log with the message?
home:computersalat:monitoring/centreon I placed a rpmlintrc, to supress message Regards Chris -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Christian wrote:
If I remove executable bits rpmlint complains about "non-executable-crontab-file" and vice-versa.
Could we please fix that.
Did you actually read the rpmlint message?
entreon.noarch: W: non-executable-script /etc/cron.d/centstorage 0644 centreon.noarch: W: non-executable-script /etc/cron.d/centreon 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
remove the #!/bin/sh in those files and the warning will disappear. Also a glance at the spec file shows several issues not covered by any automatic check: 194 echo $pre_version > /tmp/rpm_%{name} Don't use world writeable directories for such hacks! 212 %{__cat} >> /etc/sudoers << EOF *shudder* don't touch that file! 240 sed -i -e "s,@FQDN@,$(hostname -f)," -e "s,@ALIAS@,$(hostname -s), ... This will cause DNS lookups during install. If at all use the value from /etc/HOSTNAME instead. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi Ludwig, Ludwig Nussel schrieb:
Did you actually read the rpmlint message?
entreon.noarch: W: non-executable-script /etc/cron.d/centstorage 0644 centreon.noarch: W: non-executable-script /etc/cron.d/centreon 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
remove the #!/bin/sh in those files and the warning will disappear.
OK, I will remove it. :)
Also a glance at the spec file shows several issues not covered by any automatic check:
194 echo $pre_version > /tmp/rpm_%{name}
Don't use world writeable directories for such hacks!
Do you have a suggestion ? perhaps /root/ ?
212 %{__cat} >> /etc/sudoers << EOF
*shudder* don't touch that file!
This is easy saying. Please tell me how to add needed stuff to sudoers without breaking perm/ownership.
240 sed -i -e "s,@FQDN@,$(hostname -f)," -e "s,@ALIAS@,$(hostname -s), ...
This will cause DNS lookups during install. If at all use the value from /etc/HOSTNAME instead.
I always thought: - at first files are read - at second dns is asked isn't it ?
cu Ludwig
Thanks Chris -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Christian wrote:
Ludwig Nussel schrieb:
Don't use world writeable directories for such hacks!
Do you have a suggestion ? perhaps /root/ ?
/var/run would be a better place.
212 %{__cat} >> /etc/sudoers << EOF
*shudder* don't touch that file!
This is easy saying. Please tell me how to add needed stuff to sudoers without breaking perm/ownership.
You don't add stuff to the sudoers file. You could at most document what changes are needed to enable sudo support. However, not involving sudo all would be even better.
240 sed -i -e "s,@FQDN@,$(hostname -f)," -e "s,@ALIAS@,$(hostname -s), ...
This will cause DNS lookups during install. If at all use the value from /etc/HOSTNAME instead.
I always thought: - at first files are read - at second dns is asked
isn't it ?
Well, if you are lucky /etc/hosts will prevent an actual DNS lookup but you can't rely on that. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi Ludwig, Ludwig Nussel schrieb:
/var/run would be a better place.
OK
You don't add stuff to the sudoers file. You could at most document what changes are needed to enable sudo support. However, not involving sudo all would be even better.
OK, then it should be made by admin, ;)
240 sed -i -e "s,@FQDN@,$(hostname -f)," -e "s,@ALIAS@,$(hostname -s), ...
This will cause DNS lookups during install. If at all use the value from /etc/HOSTNAME instead.
I always thought: - at first files are read - at second dns is asked
isn't it ?
Well, if you are lucky /etc/hosts will prevent an actual DNS lookup but you can't rely on that.
OK, would you prefer for hostname -f =>`head -n 1 /etc/HOSTNAME` and hostname -s => `head -n 1 /etc/HOSTNAME | awk -F. '{print $1}'` is /etc/HOSTNAME available on all "Linux's" ? Kind Regards Chris -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Christian wrote:
OK, would you prefer for hostname -f =>`head -n 1 /etc/HOSTNAME` and hostname -s => `head -n 1 /etc/HOSTNAME | awk -F. '{print $1}'`
read fqdn < /etc/HOSTNAME h=${fqdn%%.*} 'hostname' without parameters will not cause a DNS lookup so that would be fine as well.
is /etc/HOSTNAME available on all "Linux's" ?
No idea. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi
Dne Tue, 02 Jun 2009 13:07:18 +0000
Christian
OK, would you prefer for hostname -f =>`head -n 1 /etc/HOSTNAME` and hostname -s => `head -n 1 /etc/HOSTNAME | awk -F. '{print $1}'`
is /etc/HOSTNAME available on all "Linux's" ?
I don't see it on any of my Debian boxes, but it has /etc/hostname. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (4)
-
Andreas Stieger
-
Christian
-
Ludwig Nussel
-
Michal Čihař