Hi Michal, On Wed, May 06, 2009 at 05:46:20AM -0600, Novell Forge SVN wrote:

Author: mcihar Date: 2009-05-06 05:46:17 -0600 (Wed, 06 May 2009) New Revision: 7266

Modified: trunk/buildservice/src/clientlib/python/osc/osc/cmdln.py Log: Add support for generating a man page.

Modified: trunk/buildservice/src/clientlib/python/osc/osc/cmdln.py =================================================================== --- trunk/buildservice/src/clientlib/python/osc/osc/cmdln.py 2009-05-06 10:08:08 UTC (rev 7265) +++ trunk/buildservice/src/clientlib/python/osc/osc/cmdln.py 2009-05-06 11:46:17 UTC (rev 7266) @@ -43,6 +43,8 @@ import cmd import optparse from pprint import pprint +from core import get_osc_version +from datetime import date

It looks as if the change is principally a very nice thing, but puts osc-specific code and documentation inside the cmdln module. [1] I think it would be better (if not brilliant) if you would enhance the cmdln module in a way that the change is generically useful. At the same time, it would mean that we won't have problems upgrading our in-tree cmdln module when upstream releases a new version. Right now, somebody would need to forward port your changes. Do you think you could leave out just the osc-specific text (providing it to the functionality from somewhere else), so we can achieve the same (great) functionality in a way that's not totally bound to osc? I'm sure that upstream would be interested in this feature. [1] http://code.google.com/p/cmdln/ (The module also exists as python-cmdln package in the buildservice, and it would also be possible to use that instead of an in-tree copy. The package is not on any product though, I think.) Thanks, Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development