check-files complans about non-existant files...
Hi, I just set-up a minor release upgrade for Orthanc https://build.opensuse.org/package/show/home:DocB:Orthanc/orthanc and run into the error: [ 208s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/ abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64 [ 208s] error: Installed (but unpackaged) file(s) found: [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so.1.11.2 [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so.1.11.2 The strange thing is ...when I do a local build, these files do not exist in /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ And in the old package (graphics/orthanc version 1.11.0), there is no complaint about libConnectivityChecks.so Any idea, someone? Thx Axel
Nobody an idea?
Schöne Grüße
Axel
--
Written from cell phone - excuses for typos
Am 27. September 2022 15:42:04 MESZ schrieb Axel Braun
Hi,
I just set-up a minor release upgrade for Orthanc https://build.opensuse.org/package/show/home:DocB:Orthanc/orthanc
and run into the error: [ 208s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/ abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64 [ 208s] error: Installed (but unpackaged) file(s) found: [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so.1.11.2 [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so.1.11.2
The strange thing is ...when I do a local build, these files do not exist in /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/
And in the old package (graphics/orthanc version 1.11.0), there is no complaint about libConnectivityChecks.so
Any idea, someone? Thx Axel
Hi Axel, the paths are relative to the BUILDROOT specified, so have you looked at /home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ ? best, Georg On 27/09/2022 15:42, Axel Braun wrote:
Hi,
I just set-up a minor release upgrade for Orthanc https://build.opensuse.org/package/show/home:DocB:Orthanc/orthanc
and run into the error: [ 208s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/ abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64 [ 208s] error: Installed (but unpackaged) file(s) found: [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so.1.11.2 [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so.1.11.2
The strange thing is ...when I do a local build, these files do not exist in /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/
And in the old package (graphics/orthanc version 1.11.0), there is no complaint about libConnectivityChecks.so
Any idea, someone? Thx Axel
-- Jülich Centre for Neutron Science JCNS at Heinz Maier-Leibnitz Zentrum MLZ Forschungszentrum Jülich GmbH Lichtenbergstraße 1 85747 Garching GERMANY Telefon: +49 - 89 158860 731 Telefax: +49 - 89 158860 799 --------------------------------------------------------------------------------------------- Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Volker Rieke Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Frauke Melchior ---------------------------------------------------------------------------------------------
Hello Georg Am Freitag, 30. September 2022, 10:10:30 CEST schrieb Georg Brandl:
the paths are relative to the BUILDROOT specified, so have you looked at
/home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/abuild/rpmbuild /BUILD/Orthanc-1.11.2/build/
That was indeed a good point, however - why these 2 libs appear under /home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/... is a miracle to me, as the .spec file was basically not changed (and other plugins do not show up there either) - .../home is definitely a path we dont want to distribute. While forensics can go on I used a pragmatic approach and deleted the .../home part Thanks for the hint Axel
On 9/27/22 15:42, Axel Braun wrote:
Hi,
I just set-up a minor release upgrade for Orthanc https://build.opensuse.org/package/show/home:DocB:Orthanc/orthanc
and run into the error: [ 208s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/ abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64 [ 208s] error: Installed (but unpackaged) file(s) found: [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libConnectivityChecks.so.1.11.2 [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so [ 208s] /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ libDelayedDeletion.so.1.11.2
The strange thing is ...when I do a local build, these files do not exist in /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/
And in the old package (graphics/orthanc version 1.11.0), there is no complaint about libConnectivityChecks.so
Any idea, someone? Thx Axel
See buildlog: [ 58s] /usr/bin/make -f CMakeFiles/Makefile2 preinstall [ 58s] make[4]: Nothing to be done for 'preinstall'. [ 59s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ConnectivityChecks-build' [ 59s] Install the project... [ 59s] /usr/bin/cmake -P cmake_install.cmake [ 59s] -- Install configuration: "RelWithDebInfo" [ 59s] -- Installing: /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/./libConnectivityChecks.so.1.11.2 [ 59s] -- Installing: /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/./libConnectivityChecks.so [ 59s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ConnectivityChecks-build' [ 59s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build' [ 59s] cd /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ConnectivityChecks-build && /usr/bin/cmake -E touch /home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build/ConnectivityChecks-prefix/src/ConnectivityChecks-stamp/ConnectivityChecks-install [ 59s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build' [ 59s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/Orthanc-1.11.2/build' [ 59s] [ 27%] Completed 'ConnectivityChecks' Have a nice day, Berny
On Freitag, 30. September 2022 14:00:34 CEST Axel Braun wrote:
Hello Georg
Am Freitag, 30. September 2022, 10:10:30 CEST schrieb Georg Brandl:
the paths are relative to the BUILDROOT specified, so have you looked at
/home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/abuild/rpmbui ld /BUILD/Orthanc-1.11.2/build/
That was indeed a good point, however - why these 2 libs appear under /home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/... is a miracle to me, as the .spec file was basically not changed (and other plugins do not show up there either) - .../home is definitely a path we dont want to distribute. While forensics can go on I used a pragmatic approach and deleted the .../home part
Upstream has a broken invocation of ExternalProject_Add, https://hg.orthanc-server.com/orthanc/file/tip/OrthancServer/ CMakeLists.txt#l638 ``` externalproject_add(DelayedDeletion ... CMAKE_ARGS ... -DCMAKE_INSTALL_PREFIX=${CMAKE_CURRENT_BINARY_DIR} ``` CMAKE_CURRENT_BINARY_DIR is "/home/abuild/rpmbuild /BUILD/Orthanc-1.11.2/ build/" here. When "make DESTDIR=<BUILDROOT>/ install" is invoked, this gets contatenated to "/home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/abuild/rpmbuild /BUILD/Orthanc-1.11.2/build/". The correct approach is to pass `INSTALL_COMMAND ""` to ExternalProject_Add. Regards, Stefan
Hello Stefan, Am Samstag, 1. Oktober 2022, 04:09:00 CEST schrieb Stefan Brüns: ...
That was indeed a good point, however - why these 2 libs appear under /home/abuild/rpmbuild/BUILDROOT/orthanc-1.11.2-0.x86_64/home/... is a miracle to me, as the .spec file was basically not changed (and other plugins do not show up there either) - .../home is definitely a path we dont want to distribute. While forensics can go on I used a pragmatic approach and deleted the .../home part
Upstream has a broken invocation of ExternalProject_Add, https://hg.orthanc-server.com/orthanc/file/tip/OrthancServer/ CMakeLists.txt#l638 ....
Thank you for the analysis Stefan! I passed this to upstream Have a good weekend Axel
participants (5)
-
Axel Braun
-
Axel Braun
-
Bernhard Voelker
-
Georg Brandl
-
Stefan Brüns