Hi, On Wed, May 13, 2015 at 08:38:49PM +0200, Marcus Meissner wrote:

On Wed, May 13, 2015 at 07:29:26PM +0200, Lars Müller wrote:

...

home:lmuelle:bnc906336/samba.openSUSE_13.1_Update and home:lmuelle:bnc906336/samba.openSUSE_13.2_Update both have the identical baselibs.conf as it is used at network:samba:STABLE/samba or network:samba:MAINTAINED:SLE_12/samba

While it was possible to commit to network:samba:STABLE/samba both home:lmuelle:bnc906336/samba.openSUSE_13.*_Update projects don't accept the same commit.

While calling osc commit I get:

###ASK /home/lmuelle/opensuse/home:lmuelle:bnc906336/samba.openSUSE_13.1_Update/baselibs.conf - package has samba-client-rpmlintrc: (unchanged) ERROR: '#' referenced in baselibs.conf is not being built ERROR: 'The' referenced in baselibs.conf is not being built ERROR: 'next' referenced in baselibs.conf is not being built ERROR: 'line' referenced in baselibs.conf is not being built ERROR: 'is' referenced in baselibs.conf is not being built ERROR: 'required' referenced in baselibs.conf is not being built ERROR: 'for' referenced in baselibs.conf is not being built ERROR: 'pre-11.0' referenced in baselibs.conf is not being built ERROR: 'builds' referenced in baselibs.conf is not being built ERROR: 'of' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built Aborting: service call failed: /usr/lib/obs/service/source_validator --outdir /tmp/tmpZ6mSdL A service failed with error: 1

Perhaps the file does not allow comments?

The comment is in the baselibs.conf file since 2008 and the build only fails in the branched project home:lmuelle:bnc906336/ While it still works as expected inside network:samba:STABLE/samba or network:samba:MAINTAINED:SLE_12/samba Also the (in openSUSE Factory) non existing package libsmbclient doesn't cause any harm in network:samba:STABLE/samba or network:samba:MAINTAINED:SLE_12/samba while this results in the above quoted error messages in my branch. Cheers, Lars -- Lars Müller [ˈlaː(r)z ˈmʏlɐ] Samba Team + SUSE Labs SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany

Hi, On Wed, May 13, 2015 at 10:01:15PM +0200, Bernhard Voelker wrote:

On 05/13/2015 07:29 PM, Lars Müller wrote:

...

home:lmuelle:bnc906336/samba.openSUSE_13.1_Update and home:lmuelle:bnc906336/samba.openSUSE_13.2_Update both have the identical baselibs.conf as it is used at network:samba:STABLE/samba or network:samba:MAINTAINED:SLE_12/samba

While it was possible to commit to network:samba:STABLE/samba both home:lmuelle:bnc906336/samba.openSUSE_13.*_Update projects don't accept the same commit.

While calling osc commit I get:

###ASK /home/lmuelle/opensuse/home:lmuelle:bnc906336/samba.openSUSE_13.1_Update/baselibs.conf - package has samba-client-rpmlintrc: (unchanged) ERROR: '#' referenced in baselibs.conf is not being built ERROR: 'The' referenced in baselibs.conf is not being built ERROR: 'next' referenced in baselibs.conf is not being built ERROR: 'line' referenced in baselibs.conf is not being built ERROR: 'is' referenced in baselibs.conf is not being built ERROR: 'required' referenced in baselibs.conf is not being built ERROR: 'for' referenced in baselibs.conf is not being built ERROR: 'pre-11.0' referenced in baselibs.conf is not being built ERROR: 'builds' referenced in baselibs.conf is not being built ERROR: 'of' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built Aborting: service call failed: /usr/lib/obs/service/source_validator --outdir /tmp/tmpZ6mSdL A service failed with error: 1

Is this the same why https://build.opensuse.org/request/show/306597 got declined this morning? Someone fixed it, and DimStar told me to submit a new request. It seems to work now.

I've prurged home:lmuelle:bnc906336 and started from scratch and am again at the same point. I've updated home:lmuelle:bnc906336/samba.openSUSE_13.2_Update/ with samba 4.1.18 and independent if I modify baselibs.conf or not I get on commit the same error messages as with the former home:lmuelle:bnc906336 project: ###ASK /home/lmuelle/opensuse/home:lmuelle:bnc906336/samba.openSUSE_13.2_Update/baselibs.conf - package has samba-client-rpmlintrc: (unchanged) ERROR: '#' referenced in baselibs.conf is not being built ERROR: 'The' referenced in baselibs.conf is not being built ERROR: 'next' referenced in baselibs.conf is not being built ERROR: 'line' referenced in baselibs.conf is not being built ERROR: 'is' referenced in baselibs.conf is not being built ERROR: 'required' referenced in baselibs.conf is not being built ERROR: 'for' referenced in baselibs.conf is not being built ERROR: 'pre-11.0' referenced in baselibs.conf is not being built ERROR: 'builds' referenced in baselibs.conf is not being built ERROR: 'of' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built Aborting: service call failed: /usr/lib/obs/service/source_validator --outdir /tmp/tmpJiME9g A service failed with error: 1 The content of baselibs.conf is identical to the one from network:samba:STABLE/samba/baselibs.conf There I had no trouble while committing and all builds despite armv6l Factory target succeeded. Cheers, Lars -- Lars Müller [ˈlaː(r)z ˈmʏlɐ] Samba Team + SUSE Labs SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany

Hi, On Thu, May 14, 2015 at 08:17:22AM +0100, Dominique Leuenberger / DimStar wrote:

On Wed, 2015-05-13 at 19:29 +0200, Lars Müller wrote:

...

home:lmuelle:bnc906336/samba.openSUSE_13.1_Update and home:lmuelle:bnc906336/samba.openSUSE_13.2_Update both have the identical baselibs.conf as it is used at network:samba:STABLE/samba or network:samba:MAINTAINED:SLE_12/samba

While it was possible to commit to network:samba:STABLE/samba both home:lmuelle:bnc906336/samba.openSUSE_13.*_Update projects don't accept the same commit.

While calling osc commit I get:

###ASK /home/lmuelle/opensuse/home:lmuelle:bnc906336/samba.openSUSE_13.1_Upd ate/baselibs.conf - package has samba-client-rpmlintrc: (unchanged) ERROR: '#' referenced in baselibs.conf is not being built ERROR: 'The' referenced in baselibs.conf is not being built ERROR: 'next' referenced in baselibs.conf is not being built ERROR: 'line' referenced in baselibs.conf is not being built ERROR: 'is' referenced in baselibs.conf is not being built ERROR: 'required' referenced in baselibs.conf is not being built ERROR: 'for' referenced in baselibs.conf is not being built ERROR: 'pre-11.0' referenced in baselibs.conf is not being built ERROR: 'builds' referenced in baselibs.conf is not being built ERROR: 'of' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built Aborting: service call failed: /usr/lib/obs/service/source_validator --outdir /tmp/tmpZ6mSdL A service failed with error: 1

https://github.com/openSUSE/obs-service-source_validator/pull/20 takes care of allowing comments in baselibs.conf.

For samba, there are some more issues though, where baselibs.conf seems not really to show what is currently built: and the idea of the new parser is to actually have baselibs.conf make sense in accordance to the .spec file.. something, a lot of packages drifted far apart from.

I still get: ERROR: 'libldb1' referenced in baselibs.conf is not being built ERROR: 'libsmbclient' referenced in baselibs.conf is not being built ERROR: 'libtalloc2' referenced in baselibs.conf is not being built ERROR: 'libtdb1' referenced in baselibs.conf is not being built ERROR: 'libtevent0' referenced in baselibs.conf is not being built

at least talloc, tevent, ldb1 and tdb1 are certainly no longer built by samba.spec, as they are sep packages.

Wed May 13 16:10:00 UTC 2015 - lmuelle@suse.com - Remove the independently built libraries ldb, talloc, tdn, and tevent from baselibs.conf. Looks to me like you're looking at an older baselibs.conf I talk about the one from network:samba:STABLE/samba/ ;)

libsmbclient is only built for openSUSE < 10.3.1 (but in fact the parser won't ever be able to guess that)

Till now the OBS had no issue with this and even has none inside of network:samab:STABLE but it fails in home:lmuelle:bnc906336 Isn't that a bit inconsistent? And this discrepancy I tried to stress with my initial mail.

So, besides the comment not being ignored, 4 out of the 5 fails marked are 100% correct to be flagged and ought to be corrected. The last one is debatable, but imho not worthy to keep it.

But we need it for the SUSE Linux Enterprise 10 build target. Cheers, Lars -- Lars Müller [ˈlaː(r)z ˈmʏlɐ] Samba Team + SUSE Labs SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany