Quoting Olaf Hering :

On Mon, Oct 21, Dominique Leuenberger a.k.a. Dimstar wrote:

...

Quoting Olaf Hering :

...

I'm trying to submit revision 242 of Virtualization/libguestfs, but somehow this fails:

https://build.opensuse.org/request/diff/204088

Is there anything to be done on my side to submit rev 242?

olaf,

the decline message is: libguestfs's sources were changed after submissions and the old sources never built. Please resubmit

=> has rev 242 ever built?

I'm sure it builds ok, just not for 11.4 and older at this point.

That might be valid, but the fact is: it never builT on OBS in this rev... and as such, the script has no chance of knowing if it would build. The followup checkin was too soon. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Quoting Olaf Hering :

On Mon, Oct 21, Dominique Leuenberger a.k.a. Dimstar wrote:

...

...

I'm sure it builds ok, just not for 11.4 and older at this point.

That might be valid, but the fact is: it never builT on OBS in this rev... and as such, the script has no chance of knowing if it would build.

So if I had submitted it at the time 242 has the most recent version it would have been ok? I just double checked, 242 builds fine for 13.1.

It would not have rejected it immediately, but it would also not have accepted before the build passed at least once. Factory-auto ONLY accepts the review when it can VERIFY that the sources built. It does not matter how long it has to wait; as long as the rev is LATEST, it will keep on verifying.. if LATEST is newer than what was submitted, and the submitted never built, it is declined. In your case. the best way is to either: - Submit HEAD (ensure to fixup .changes to comply to the packaging guidelines; there was not changelog for r 243). - Revert rev 243 and resubmit Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Quoting Olaf Hering :

On Mon, Oct 21, Dominique Leuenberger a.k.a. Dimstar wrote:

...

Quoting Olaf Hering :

...

On Mon, Oct 21, Dominique Leuenberger a.k.a. Dimstar wrote:

...

...

I'm sure it builds ok, just not for 11.4 and older at this point.

That might be valid, but the fact is: it never builT on OBS in this rev... and as such, the script has no chance of knowing if it would build.

So if I had submitted it at the time 242 has the most recent version it would have been ok? I just double checked, 242 builds fine for 13.1.

It would not have rejected it immediately, but it would also not have accepted before the build passed at least once.

What does it check to verify if rev N is good? I see its been 6 hours between 242 and 243. To me it looks like something never attempts to built what was actually submitted. Are you saying OBS just waits for results in the origin, instead of building the submitted, different sources once more? If so, that smells like a error.

The verification is rather simple: - Does rev N as submitted build This simple check can not be verified for Rev 242. Many reasons why rev 242 never built: no worker available is the most common one (you're not new to OBS.. you know that at times it can be lengthy to get to a build result). rebuilding stuff on submit does not sound like the best plan neither.. The main question should probably be: why was there a rev 243 checked in and why would this not be important enough to be forwarded (well in fact it WAS forwarded, but the request was declined (by me) for not following the packaging guidelines). IF this request would have been accepted, what would have been the point of rev 242? Are we just having a meta-discussion here? The solution stays simple: - Submit a fixed HEAD - Revert the changes of r243 and resubmit after it built Anything else will not get your package into Factory... Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Quoting Olaf Hering :

On Mon, Oct 21, Dominique Leuenberger a.k.a. Dimstar wrote:

...

Quoting Olaf Hering :

...

What does it check to verify if rev N is good? I see its been 6 hours between 242 and 243. To me it looks like something never attempts to built what was actually submitted. Are you saying OBS just waits for results in the origin, instead of building the submitted, different sources once more? If so, that smells like a error.

The verification is rather simple: - Does rev N as submitted build

This is probably what should happen, but its not whats happening today.

It is what is checked: but it relies on OBS history data and does not go out and build stuff.. Just imagine the waste of time for LO => the script would be 'waiting' for 6 hours.. and so does the OBS worker building it. This sounds like a duplication of tasks for the rare benefit of this special case where the maintainer submitted, changed and submitted; expecting the old SR to be valid.

...

rebuilding stuff on submit does not sound like the best plan neither.. The main question should probably be: why was there a rev 243 checked in and why would this not be important enough to be forwarded (well in fact it WAS forwarded, but the request was declined (by me) for not following the packaging guidelines).

IF this request would have been accepted, what would have been the point of rev 242? Are we just having a meta-discussion here?

I dont think so. Its not so much about this specific package.

It is a corner case which happens once in a while.. investing additional workers dedicated to this corner case does not sound like the right thing to do. Better educate the prj maintainers about this. BTW: the reason is always the same: prj maintainer changed the package after submitting, but before successful builds. In most of those cases, the prj maintainer ever would want the latest modification in as well (so, submitting HEAD as recommended would be the right thing)

If 'osc sr -r N' does not work, whats the point of having it? Perhaps the checks for Factory are just incomplete. As I said, if submitted rev does not match HEAD, then the checker should use and build "submitted rev" instead of looking at something that was not submitted.

osc sr -r N DOES work (against all random projects). simply for Factory there is the additional check: did -r N ever successfully build. The checker really ought to do what it's name sais 'check'. Not build.. building is a waste of power, if you get a full stack of 500 packages submitted. Throwing workers at it would mean other packages don't have workers available.. All in all: it's a corner case imho that is not worthy the effort of special build power. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org