Am Dienstag, 25. Mai 2010, 08:51:09 schrieb JF Ding:
> Marcus,
> thanks for your reviewing.
> Yes, it will be perfect if the mailing list feature is implemented at
> obs server side.
Actually it is. But you need to setup and run hermes. This is unfortunatly
not yet in a shape that we make it part of our OBS release.
But AFAIK Klaas is working on improving it so that we can make it part of it.
Klaas, what is missing here ? Can others help ?
Hermes wiki page:
http://en.opensuse.org/Hermes
bye
adrian
> But the current osc method is probably the simplest
> to do
> this work, and can be delivered to end user easily, without upgrade
> and configure ther server components.
>
> And we can consider the mailinglist support per apiurl is the first
> step, and it can meet most of requirements. Mailing list per project
> can also be implemented in osc, with extra project attribute. If the
> need for it is popular, I'll try to add it later.
>
> The "src_rev" problem was fixed in one new commit, thanks for your reminding.
>
> - JF Ding
>
>
> On Tue, May 25, 2010 at 4:49 AM, Marcus Hüwe <suse-tux@gmx.de> wrote:
> > Hi,
> >
> > On 2010-05-24 19:16:47 +0800, JF Ding wrote:
> >> As we using obs/osc in Moblin/MeeGo development, we have maintained
> >> several internal used plugins to support new commands for special
> >> usage. One of the most used one, 'mobsr' (stands for
> >> moblin-send-request), is a wrapper to the built-in 'sr' command and
> >> with extra checking and function to send mail to mailing list.
> >> We consider the sendmail feature can be a generic enhancement to
> >> original 'sr' command, so I am trying to rewrite the code based on
> >> upstream osc git.
> > Hmm I'm not quite sure if this functionality should be implemented in osc
> > itself. It rather should be implemented in the api/backend. Then you could
> > specify for each project something like a mailinglist attribute or something
> > else and hermes (or another notification delivery tool) can send the
> > notification. This way you would also get notifications if a user uses
> > webui.
> >
> > I just had a quick glance at your patch and there are some issues IMHO:
> > * with the current implementation you would always send emails to the
> > the mailinglist regardless of the project etc. (it would be better if
> > you could specify a mailinglist on a per project basis)
> > * in get_source_file_content():
> > it's probably better to pass in the "src_rev" attribute from the request
> > instead of using the latest upstream revision.
> > (The same applies to the meta_get_filelist() call)
> >
> >
> >
> > Marcus
> > --
> > To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org
> > For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
> >
> >
>
--
Adrian Schroeter
SUSE Linux Products GmbH
email: adrian@suse.de