[Bug 543470] New: firmwarekit-3-45.39: missing call to pclose
http://bugzilla.novell.com/show_bug.cgi?id=543470 Summary: firmwarekit-3-45.39: missing call to pclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package firmwarekit-3-45.39 source code file linuxfirmwarekit/pciresource/pciinfo.c function gather_pci_info local variable file. I notice the following code file = popen(lspci_cmd, "r"); but I fail to notice any matching call to pclose. This looks like a resource leak to me. Suggest add a call to pclose near the end of the block to plug the leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543470
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=543470
User rguenther@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=543470#c1
--- Comment #1 from Richard Guenther
Note that it is perfectly fine to have "resource leaks" at the end of a program IMO it's always worth freeing memory and file descriptors, also at the end of a
http://bugzilla.novell.com/show_bug.cgi?id=543470
User trenn@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=543470#c2
Thomas Renninger
participants (1)
-
bugzilla_noreply@novell.com