https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c Thomas Blume changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #577065|application/octet-stream |text/plain mime type| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c4 --- Comment #4 from Thomas Blume 2014-02-04 11:11:14 UTC --- Further investigation on my vm showed that enabling lvm2-lvmetad.service indeed works out. On my physical machine it didn't work, but this seems to be rather an lvm problem. When running pvscan on this machine I get: linux-rvj1:~ # pvscan WARNING: lvmetad is running but disabled. Restart lvmetad before enabling it! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c Robert Milasan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED CC| |dmzhang@suse.com Severity|Normal |Major -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c9 --- Comment #9 from Robert Milasan 2014-02-04 13:20:43 UTC --- Actually it should be both: %post %service_add_post blk-availability.service lvm2-monitor.service lvm2-lvmetad.socket /usr/bin/systemctl enable lvm2-lvmetad.socket [ -x /sbin/mkinitrd ] && /sbin/mkinitrd /sbin/ldconfig %preun %service_del_preun blk-availability.service lvm2-monitor.service lvm2-lvmetad.socket lvm2-lvmetad.service You see that at %preun lvm2-lvmetad.service is remove, but not added at %post, so We should do: %service_add_post blk-availability.service lvm2-monitor.service lvm2-lvmetad.socket lvm2-lvmetad.service /usr/bin/systemctl enable lvm2-lvmetad.socket /usr/bin/systemctl enable lvm2-lvmetad.service -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c12 --- Comment #12 from Thomas Blume 2014-02-04 15:06:13 UTC --- I did a test on my machine. Enabling lvm2-lvmetad.socket is indeed sufficient: linux-tv7k:~ # systemctl is-enabled lvm2-lvmetad.service disabled linux-tv7k:~ # systemctl is-enabled lvm2-lvmetad.socket enabled And the boot log shows then: Installed new job lvm2-lvmetad.socket/start as 59 lvm2-lvmetad.socket changed dead -> listening Job lvm2-lvmetad.socket/start finished, result=done Incoming traffic on lvm2-lvmetad.socket Trying to enqueue job lvm2-lvmetad.service/start/replace Installed new job lvm2-lvmetad.service/start as 124 Enqueued job lvm2-lvmetad.service/start as 124 lvm2-lvmetad.socket changed listening -> running About to execute: /sbin/lvmetad Forked /sbin/lvmetad as 333 lvm2-lvmetad.service changed dead -> start Received SIGCHLD from PID 333 (lvmetad). Got SIGCHLD for process 333 (lvmetad) Child 333 belongs to lvm2-lvmetad.service lvm2-lvmetad.service: control process exited, code=exited status=0 lvm2-lvmetad.service got final SIGCHLD for state start lvm2-lvmetad.service changed start -> running Job lvm2-lvmetad.service/start finished, result=done So the question is, why wasn't lvm2-lvmetad.socket enabled by the post script? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c14 Andrey Borzenkov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arvidjaar@gmail.com --- Comment #14 from Andrey Borzenkov 2014-02-04 15:43:10 UTC --- (In reply to comment #11)

don't know or not sure if having the socket only works.

Yes, it works and is sufficient as long as lvmetad is always connected to via this socket. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c16 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@suse.com --- Comment #16 from Marcus Meissner 2014-02-04 21:59:42 UTC --- I removed the lvm2 update from openSUSE:Maintenance:2466 from the mirrors again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c18 --- Comment #18 from Thomas Blume 2014-02-05 12:37:58 UTC --- Concerning the second problem, it should be sufficient to set the global_filter parameter in lvm.conf. For details, see the docu above this parameter: # Since "filter" is often overriden from command line, it is not suitable # for system-wide device filtering (udev rules, lvmetad). To hide devices # from LVM-specific udev processing and/or from lvmetad, you need to set # global_filter. The syntax is the same as for normal "filter" # above. Devices that fail the global_filter are not even opened by LVM. But I think it is better to open another bug therefore. This one is about a failure to enable the socket, so no context with the lvmetad device scanning. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c21 --- Comment #21 from Andrey Borzenkov 2014-02-06 02:58:54 UTC --- I do not think so. Package update is not expected (and should not) change existing services configuration. So if service (unit) is disabled before update, it is quite rightfully remains disabled after update. Same is about setting use_lvmetad=1 - it will not be changed if lvm.conf was modified by user. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c23 --- Comment #23 from Thomas Blume 2014-02-06 13:18:13 UTC --- Concerning the macro call, I've found that the %service_add_post macro actually strips the suffix from the passed arguments. So, my test above with: /usr/sbin/systemd-sysv-convert --apply lvm2-lvmetad.socket was invalid. It should have been: /usr/sbin/systemd-sysv-convert --apply lvm2-lvmetad instead. However, there seems to be still a problem with using this macro. The macro is provided by systemd-rpm-macros. It seems that the lvm2 package should have a dependency on systemd-rpm-macros if the post script is using it. But this package was not installed on my machine. The dependency resolver showed: -->-- # zypper ve Loading repository data... Reading installed packages... Dependencies of all installed packages are satisfied. --<-- After installing the package rpm shows: -->-- # rpm -q --whatrequires systemd-rpm-macros no package requires systemd-rpm-macros --<-- Seems the lvm2 package is missing this dependency. Also I guess there are other packages that use this macro. I guess they all should have a dependency on this package? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c25 --- Comment #25 from Andrey Borzenkov 2014-02-06 17:10:58 UTC --- (In reply to comment #22)

I'll beef up patch this week.

See home:arvidjaar:bnc:862076/lvm2, specifically autoactivate-lvmetad-with-generator.patch. With this patch I can set use_lvmetad to 0 and 1 and system boots every time without any need to manually activate lvm2-lvmetad.{socket,service}. It also removes unit from post/preun as it is now redundant. User still can disable lvmetad completely by masking it (systemctl mask lvm2-lvmetad.socket). For upstream we need propagate systemdsystemunitdir into C files (is not done currently). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c27 dong mao zhang changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|systemd-maintainers@suse.de |thomas.blume@suse.com --- Comment #27 from dong mao zhang 2014-02-12 17:02:23 HKT --- Can you (In reply to comment #18)

Concerning the second problem, it should be sufficient to set the global_filter parameter in lvm.conf. For details, see the docu above this parameter:

# Since "filter" is often overriden from command line, it is not suitable # for system-wide device filtering (udev rules, lvmetad). To hide devices # from LVM-specific udev processing and/or from lvmetad, you need to set # global_filter. The syntax is the same as for normal "filter" # above. Devices that fail the global_filter are not even opened by LVM.

But I think it is better to open another bug therefore. This one is about a failure to enable the socket, so no context with the lvmetad device scanning.

I think we could open another bug for this -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c29 Lars Müller changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|thomas.blume@suse.com |systemd-maintainers@suse.de --- Comment #29 from Lars Müller 2014-02-12 12:00:26 CET --- The information requested with comment #20 wasn't provided yet by one of the systemd maintainers. Is this a bug in %service_add_post() from /etc/rpm/macros.systemd ? @Thomas: Please consider to make comment #19 public accessible as it might be of value to others. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c Robert Milasan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|systemd-maintainers@suse.de | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c32 --- Comment #32 from Lars Müller 2014-02-12 14:47:23 CET --- systemd-rpm-macros has to be installed at _build_ time and then the macros gets expanded. And not at install time of the actual package. See Andrey's comment #24 too. systemd-rpm-macros is required by rpm-build and this package is very likely part of the base system OBS package list. Thomas also corrected his comment #19 himself with comment #23. @Andrey: How about a submit request from home:arvidjaar:bnc:862076 to update/13.1-test/ ? Do we need this in Factory too? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c34 --- Comment #34 from Benjamin Brunner 2014-02-12 17:03:37 CET --- (In reply to comment #33)

(In reply to comment #32)

...

@Andrey: How about a submit request from home:arvidjaar:bnc:862076 to update/13.1-test/ ?

How? Which destination (repo etc)?

A submitrequest doesn't work. Could you open a maintenancerequest for openSUSE:13.1:Update please? (osc mr --incident=2466 home:arvidjaar:bnc:862076 lvm2 openSUSE:13.1:Update) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c36 --- Comment #36 from Andrey Borzenkov 2014-02-12 16:17:11 UTC --- (In reply to comment #34)

Could you open a maintenancerequest

MR#222057 (In reply to comment #35)

we'll first see the binary RPMs in the update/13.1-test/ tree.

Ah, well, I was not aware of it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c38 --- Comment #38 from Lars Müller 2014-02-14 17:20:22 CET --- *** Bug 858228 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=858228 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c40 --- Comment #40 from Bernhard Wiedemann 2014-02-18 16:02:13 CET --- This update seems to somehow break openSUSE-13.1 installation with updates. During 2nd stage systemctl commands block on dbus e.g. when yast2 2nd stage does systemctl enable SuSEfirewall2_init... and I tried manually systemctl status when using an update-test repo without the lvm2 update, it worked again -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c42 --- Comment #42 from Benjamin Brunner 2014-02-18 16:46:39 CET --- Bernhard, thanks for reporting. We already stopped the update again, after Marcus also found problems. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c45 --- Comment #45 from Andrey Borzenkov 2014-02-19 13:25:09 UTC --- Created an attachment (id=579120) --> (http://bugzilla.novell.com/attachment.cgi?id=579120) generator strace during "systemctl daemon-reload" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c47 --- Comment #47 from Andrey Borzenkov 2014-02-19 19:53:31 UTC --- (In reply to comment #44)

For some reasons lvmetad is stopped

It is not stopped, it is not yet started ... So full story: generator calls lvm_init() which among other things tries to contact lvmetad if it is enabled. When generator is initially called, socket (/run/lvm/lvmetad.socket) does not yet exists so nothing happens here - opening socket fails that's all. And if you do not have any LVM activity after startup, lvmetad is not started as well. When generator is called as part of daemon-reload, socket *does* exist (it is created by systemd) but systemd does not process socket requests until daemon-reload is completed. So we have deadlock here - systemd waits for generator to complete which in turn waits for accept on socket which never comes. Looks like we need to always start both lvmetad.socket and lvmetad.service to ensure lvmetad is running. Which is a pity actually, as the whole point of having socket activation is to avoid running program which is never needed. Is there any more lightweight way to check for use_lvmetad=1? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c49 --- Comment #49 from Andrey Borzenkov 2014-02-20 16:37:38 UTC --- (In reply to comment #48)

Hm, why not simly checking the config?

lvm dumpconfig | grep use_lvmetad

It does lvm_init() as well. Anyway, it is fixed upstream in commit 983f0b46f2de85b8de0e2d7f8afbdf53f132a87a: lvmetad: Init lazily, to avoid socket access on config overrides. Tested on 13.1. So ... Aller guten Dinge sind drei Factory: SR#223260 13.1: SR#223261 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c51 --- Comment #51 from Andrey Borzenkov 2014-02-21 12:45:40 UTC --- (In reply to comment #50)

If so, do we still need the patch autoactivate-lvmetad-with-generator.patch ?

You are probably right, we can simply always enable lvmetad.socket. It is really easier.

we can 'systemctl enable lvm2-lvmetad.socket' after install.

The problem is there is no way to do it while respecting user (admin) choice. Having [Install] section implies that unit could be disabled so you should not unconditionally enable it in RPM. But if you do not unconditionally enable it, you also cannot unconditionally enable use_lvmetad as you do currently. We are back at square one. I would actually vote for removing [Install] section from lvmetad.socket and simply enabling it statically. For Factory :)

After this patch, systemctl will not hang any more.

Well ... we are at 2.0.98 and since then upstream has several dozens of lvmetad fixes. So I'm not sure if this is really appropriate for 13.1 to make such a huge behavior change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c53 --- Comment #53 from Benjamin Brunner 2014-03-03 10:33:32 CET --- Update released for openSUSE 13.1 and checked in into Factory. Feel free to close the bug if everything is working as expected. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c54 dong mao zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #54 from dong mao zhang 2014-03-19 16:45:09 HKT --- close -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c56 --- Comment #56 from Andrey Borzenkov 2014-04-04 11:45:52 UTC --- (In reply to comment #55)

# systemctl is-enabled lvm2-lvmetad.socket disabled

Please check with "systemctl status". is-enabled just tells, whether links in [Install] section are present; and lvm2-lvmetad.socket is enabled dynamically on boot depending on the value of use_lvmetad. We should either statically enable lvm2-lvmetad.socket or at least remove [Install] section to avoid confusion. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=862076 https://bugzilla.novell.com/show_bug.cgi?id=862076#c58 --- Comment #58 from Andreas Otto 2014-04-04 12:00:15 UTC --- sorry for my posts to this bug -> I now using my own BUG 871704 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.