https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c1 Hannes Reinecke changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hare@suse.com |lduncan@suse.com --- Comment #1 from Hannes Reinecke 2013-04-20 13:55:49 UTC --- Lee, can you have a look? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c2 --- Comment #2 from Lee Duncan 2013-04-23 11:57:31 PDT --- Stefan: are you using a distribution upgrade online update, or an update using CD/DVD media? The results you experienced are surprising considering that there is no place in the newly-added %post script that renames anything to /etc/iet/ietd.conf.rpmsave. The logic added is: - if there is a user-modified file in /etc/ietd.conf then - if there is a user-modified file in /etc/iet/ietd.conf then - move /etc/iet/ietd.conf to /etc/iet/ietd.conf.save - else (no user-modified /etc/iet/ietd.conf) - move /etc/iet/ietd.conf (if present) to /etc/iet/ietd.conf.installed - move /etc/ietd.conf to /etc/iet/ietd.conf <=== NOTE So in the case where there is a modifed config file in the old location and the new location has either no config file or one that has not been user-modified, the script copied the old config file to the new location. The only names created by this %post script are "/etc/iet/ietd.conf.save" and "/etc/iet/ietd.conf.installed". I believe the RPM packaging software renames any listed "%config" files in this way if it does not want to delete them. This should only happen if (1) there is a possibly-modified config file in place before an RPM is installed, or (2) a modified config file is present when an RPM is removed. What is _supposed_ to happen if you have an existing user-modified /etc/ietd.conf is: - old version gets removed, but config file is not removed because it has been modified - ??? Perhaps package manager renames it to /etc/ietd.conf.rpmsave here ??? - new version gets installed in /etc/iet/ietd.conf - the "%post" runs and finds a user-modified config file in /etc/ietd.conf as well as a non-modified /etc/iet/ietd.conf, so it: - moves the newly-installed non-modified /etc/iet/ietd.conf to /etc/iet/ietd.conf.installed - moves /etc/ietd.conf to /etc/iet/ietd.conf But this obviously is not happening, hence my question to you on how you upgraded. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c3 --- Comment #3 from Stefan Münkner 2013-04-24 08:16:39 UTC --- Lee, sorry my fault, I did not specify it. I did an online dist upgrade on two (pratically identically installed) machines. It happened on both _and_ there was no /etc/iet sub directory before the upgrade on the first machine. I checked on that via the backup that ran before the upgrade. So in fact during the upgrade there was no /etc/iet/ietd.conf on that machine. /etc/ietd.conf was moved over to /etc/ietd.rpmsave and /etc/iet/ contains no ietd.conf.rpmsave. On the second machine, having had the results of the upgrade on the first machine, I actually created /etc/iet and copied all the files from the first (already upgraded) machine, adapted them and still /etc/ietd.conf got overwritten. It may be that it is a strange combination of things, but especially the upgreade "failure" on the second machine made me write the report. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c6 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |stefan.muenkner@mx.uni-saar | |land.de --- Comment #6 from Lee Duncan 2013-04-24 11:22:50 PDT --- (In reply to comment #3)

Lee,

sorry my fault, I did not specify it. I did an online dist upgrade on two (pratically identically installed) machines. It happened on both _and_ there was no /etc/iet sub directory before the upgrade on the first machine. I checked on that via the backup that ran before the upgrade. So in fact during the upgrade there was no /etc/iet/ietd.conf on that machine.

/etc/ietd.conf was moved over to /etc/ietd.rpmsave and /etc/iet/ contains no ietd.conf.rpmsave.

I assume you mean that /etc/ietd.conf was moved over to /etc/ietd.conf.rpmsave. It sounds like it may be the same results I found in testing. I suspect your /etc/ietd.conf.rpmsave is a symlink /etc/iet/ietd.conf.

On the second machine, having had the results of the upgrade on the first machine, I actually created /etc/iet and copied all the files from the first (already upgraded) machine, adapted them and still /etc/ietd.conf got overwritten.

What does "adapted them" mean? And how many files did you move? The 12.1 iscsitarget package only owned /etc/ietd.conf, so there is only one package file to copy. The post-install script does not look for other non-package iscsitarget files which may be present.

It may be that it is a strange combination of things, but especially the upgreade "failure" on the second machine made me write the report.

I tested this and got the same results as in the previous test, i.e.: - install 12.1 iscsitarget, and modify /etc/ietd.conf with a new target - mkdir /etc/iet and copy /etc/ietd.conf to /etc/iet/ietd.conf - note that I left /etc/ietd.conf present as well as /etc/iet/ietd.conf - Upgrade to 12.2 iscsitarget script Again, I get an incorrect symlink of /etc/ietd.conf.rpmsave that points to /etc/iet/ietd.conf. And /etc/iet/ietd.conf does indeed contain the correct user-added configuration. Can you do this for both systems: "ls -lR /etc/iet*" on both systems for me? When you add the info, please change STATUS back to ASSIGNED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c8 Stefan Münkner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|stefan.muenkner@mx.uni-saar | |land.de | --- Comment #8 from Stefan Münkner 2013-04-26 12:38:18 UTC --- (In reply to comment #6)

(In reply to comment #3)

I assume you mean that /etc/ietd.conf was moved over to /etc/ietd.conf.rpmsave.

correct

It sounds like it may be the same results I found in testing. I suspect your /etc/ietd.conf.rpmsave is a symlink /etc/iet/ietd.conf.

No it is not. Listings are attached.

What does "adapted them" mean? And how many files did you move?

The two targets are identified by ...:target1 and ....:target2 in ietd.conf and I changed that before doing the upgrade, so that, if after the upgrade ietd could presumably start with the correct target definitions. I rsynced the whole directory from one machine to the other (since it did not exist on the second machine prior to the upgrade), then modified (only, IIRC) ietd.conf. There were however some more files involved (see below, and attachment above).

The 12.1 iscsitarget package only owned /etc/ietd.conf, so there is only one package file to copy.

The currently installed package is: Name : iscsitarget Version : 1.4.20.3 Release : 2.16.1 Architecture: x86_64 Install Date: Thu Apr 18 08:55:57 2013 it owns the following files/dirs in /etc/iet rpm -ql iscsitarget | grep /etc /etc/iet /etc/iet/ietd.conf /etc/iet/initiators.allow /etc/iet/initiators.deny /etc/iet/targets.allow This already is an update installed after my change from 12.1 -> 12.2

...

It may be that it is a strange combination of things, but especially the upgreade "failure" on the second machine made me write the report.

I tested this and got the same results as in the previous test, i.e.:

- install 12.1 iscsitarget, and modify /etc/ietd.conf with a new target

- mkdir /etc/iet and copy /etc/ietd.conf to /etc/iet/ietd.conf

- note that I left /etc/ietd.conf present as well as /etc/iet/ietd.conf

- Upgrade to 12.2 iscsitarget script

Again, I get an incorrect symlink of /etc/ietd.conf.rpmsave that points to /etc/iet/ietd.conf.

And /etc/iet/ietd.conf does indeed contain the correct user-added configuration.

Can you do this for both systems: "ls -lR /etc/iet*" on both systems for me?

See, attachment (above)

When you add the info, please change STATUS back to ASSIGNED.

-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c10 --- Comment #10 from Lee Duncan 2013-05-01 10:56:05 PDT --- Created an attachment (id=537574) --> (http://bugzilla.novell.com/attachment.cgi?id=537574) New test iscsitarget RPM for openSUSE 12.2 Test iscsitarget openSUSE 12.2 RPM. Please test upgrade to this target from the openSUSE 12.1 target. Note that you can test using "rpm -Uhv iscsitarget-*.rpm". -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c11 Stefan Münkner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|stefan.muenkner@mx.uni-saar | |land.de | --- Comment #11 from Stefan Münkner 2013-05-06 10:13:47 UTC --- Lee, as You said it would be rather difficult to re-test the upgrade. All machines are on 12.2 now, and I would prefer not to meddle with it any more. However I have installed your RPM and that seemd to work with the current setup. So I think, especially since nobody else complained, we can close this one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801469 https://bugzilla.novell.com/show_bug.cgi?id=801469#c13 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |Final --- Comment #13 from Lee Duncan 2013-05-07 09:17:53 PDT --- looks like this one is done -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.