https://bugzilla.novell.com/show_bug.cgi?id=427372 User dl9pf@gmx.de added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c1 --- Comment #1 from Jan-Simon Möller 2008-09-18 08:47:22 MDT --- Created an attachment (id=240342) --> (https://bugzilla.novell.com/attachment.cgi?id=240342) 2nd code-snipped -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c3 --- Comment #3 from Klaus Kämpf 2008-09-19 07:41:34 MDT --- Complete backtrace: #0 0x00007ff0b2de4368 in __dynamic_cast () from /usr/lib64/libstdc++.so.6 #1 0x00007ff0b232102e in NCTable::selectItem (this=0x84d0c0, yitem=0x0, selected=true) at NCTable.cc:292 #2 0x00007ff0b23209e8 in NCTable::wHandleInput (this=0x84d0c0, key=2991989152) at NCTable.cc:495 #3 0x00007ff0b22ec9d4 in NCDialog::wHandleInput (this=<value optimized out>, ch=6) at NCDialog.cc:1265 #4 0x00007ff0b22eeb63 in NCDialog::getInputEvent (this=0x849d10, ch=258) at NCDialog.cc:1255 #5 0x00007ff0b22effd4 in NCDialog::processInput (this=0x849d10, timeout_millisec=-1) at NCDialog.cc:1233 #6 0x00007ff0b22f295f in NCDialog::userInput (this=0x849d10, timeout_millisec=-1) at NCDialog.cc:955 #7 0x00007ff0b22f2e92 in NCDialog::waitForEventInternal (this=0x849d10, timeout_millisec=-1) at NCDialog.cc:973 #8 0x00007ff0b308b420 in YDialog::waitForEvent (this=0x849d10, timeout_millisec=0) at YDialog.cc:348 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c5 --- Comment #5 from Klaus Kämpf 2008-09-19 07:47:05 MDT --- This has no easy fix from my POV. Over to Stefan. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c7 --- Comment #7 from Stefan Hundhammer 2008-09-19 10:04:31 MDT --- For that YTableItem problem, I liberally added debug logging, and it turns out that either Python or SWIG are too over-eager to delete those items right after they were inserted: <_M_> [ui] YUI.cc:62 YUI(): Creating UI without threads <_M_> [ui] YUI.cc:215 topmostConstructorHasFinished(): Running without threads <_M_> [qt-ui] YQUI.cc:284 processCommandLineArgs(): Qt argument: python <_M_> [qt-ui] YQUI.cc:284 processCommandLineArgs(): Qt argument: test2.py <_M_> [qt-ui] YQUI.cc:417 calcDefaultSize(): Default size: 895 x 684 <_M_> [qt-styler] QY2Styler.cc:64 setStyleSheet(): Using style sheet "style.qss" <_M_> [qt-ui] YQUI.cc:248 initUI(): Forcing /usr/lib/libQtGui.so.4 open failed <_M_> [qt-ui] YQApplication.cc:134 loadPredefinedQtTranslations(): Loaded translations for predefined Qt dialogs from /usr/share/qt4/translations/qt_de.qm <_M_> [qt-ui] YQUI.cc:261 initUI(): YQUI initialized. Thread ID: 0xb7c416c0 <dbg> [qt-ui] YQMainWinDock.cc:56 YQMainWinDock(): MainWinDock initial size: 895 x 684 <dbg> [qt-ui] YQDialog.cc:140 chooseParent(): Adding dialog to mainWinDock <dbg> [qt-ui] YQMainWinDock.cc:135 add(): Adding dialog 0x811a4a0 to mainWinDock <dbg> [qt-ui] YQMainWinDock.cc:99 resizeVisibleChild(): Resizing child dialog 0x811a4a0 to 895 x 684 <_M_> [ui] YTableItem.cc:76 YTableItem(): YTableItem 0x8195488 X busybox-abc 1.2.1 1dasdkl <dbg> [ui] YSelectionWidget.cc:163 addItem(): Adding item 0x8195488 <_M_> [ui] YTableItem.cc:76 YTableItem(): YTableItem 0x80d3f48 busybox-def 1.3.1 2dasdkl <dbg> [ui] YSelectionWidget.cc:163 addItem(): Adding item 0x80d3f48 <dbg> [qt-ui] YQDialog.cc:494 setDefaultButton(): New default button: YPushButton "OK" at 0x81e679c <_M_> [ui] YTableItem.cc:89 ~YTableItem(): Deleting 0x8195488 <_M_> [ui] YTableItem.cc:89 ~YTableItem(): Deleting 0x80d3f48 <dbg> [ui-shortcuts] YShortcutManager.cc:56 checkShortcuts(): Checking keyboard shortcuts <dbg> [ui-shortcuts] YShortcutManager.cc:149 checkShortcuts(): No shortcut conflicts This is the log output right after the program was started, with the dialog still open. The next click into the table will of course reference the now-deleted items, which results in a segfault. We need to tell Python and/or SWIG that YTable (like all YSelectionWidget subclasses) assumes ownership of items added with addItem() or addItems() - and of the YTableHeader, too. -> back to libyui-bindings maintainer -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sh@novell.com |kkaempf@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User dl9pf@gmx.de added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c10 --- Comment #10 from Jan-Simon Möller 2008-09-20 16:30:12 MDT --- I checked the code and here's a slightly modified version of example #1: import yui factory = yui.YUI.widgetFactory() dialog = factory.createMainDialog() VBox = factory.createVBox(dialog) yTableHeader = yui.YTableHeader() yTableHeader.addColumn("aaaaa") yTableHeader.addColumn("bbbbb") yTableHeader.addColumn("ccccc") yTableHeader.addColumn("ddddd") myTableMinSize = factory.createMinSize(VBox, 50, 12) myTable = factory.createTable(myTableMinSize, yTableHeader) myOK = factory.createPushButton(VBox, "OK") # note YItemCollection seems unavailable ! myItem = yui.YTableItem("X", "foo", "1.2.1", "qwertz") myTable.addItem(myItem) myItem2 = yui.YTableItem("", "bar", "1.3.1", "asdasdasd") myTable.addItem(myItem2) event1 = dialog.waitForEvent() print 1 myTable.deleteAllItems() print 2 #crashes now. del myItem del myItem2 print 3 # if not "del" before, crashes here. myItem = yui.YTableItem("X3", "foo3", "1.2.13", "qwertz3") print 4 myTable.addItem(myItem) print 5 myItem2 = yui.YTableItem("4", "bar4", "1.3.14", "asdasdasd4") print 6 myTable.addItem(myItem2) # should already have crashed event2 = dialog.waitForEvent() event3 = dialog.waitForEvent() dialog.destroy() The old example #1 worked because I used always _new_ variables to store the YTableItems. If I want to do a changeable Table, I would store the Items e.g. in a (python) Dictionary, but this will crash as I remove/rewrite the variables inside the Dictionary. For example: def updateTable() software_itemdict_ = {} softwarelist = [ "blah", "fasel", "spam", "eggs"] myTable.deleteAllItems() n = 0 # just to get same indexes for i in softwarelist: software_itemdict_[n]=yui.YTableItem(str(n), str(i), "1.3.14", "asdasdasd4") myTable.addItem(software_itemdict_[n]) n = n + 1 It crashes on 2nd run. I assume a rewrite of a variable calls a "del" and although the Item got deleted from the Table, it needs to be there or maybe destruction segfaults. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User dl9pf@gmx.de added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c12 --- Comment #12 from Jan-Simon Möller 2008-09-21 16:58:29 MDT ---

From YSelectionWidget.cc:

[...] void YSelectionWidget::deleteAllItems() { YItemIterator it = itemsBegin(); while ( it != itemsEnd() ) { YItem * item = *it; ++it; delete item; // No need to check for item->hasChildren() and iterate recursively // over the children: The item will take care of its children in its // destructor. } priv->itemCollection.clear(); } [...] Here the Items are deleted. I'd need just priv->itemCollection.clear(), right ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User dl9pf@gmx.de added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c14 --- Comment #14 from Jan-Simon Möller 2008-09-22 07:24:06 MDT --- I see also many crashes like this: Program terminated with signal 11, Segmentation fault. [New process 25751] #0 0x00007f8ea1257a09 in YSelectionWidget::findSelectedItems () from /opt/yuitest/lib64/libyui.so.3 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c16 Klaus Kämpf changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kkaempf@novell.com |sh@novell.com Component|YaST2 |YaST2 Priority|P5 - None |P3 - Medium Product|openSUSE 11.0 |openSUSE 11.1 --- Comment #16 from Klaus Kämpf 2009-01-08 05:19:37 MST --- This can be fixed by SWIGs 'disown' typemap. So the YTable (resp. YSelectionWidget) function addItem( YItem *item) must get a 'disown' typemap in order to flag tranfer of ownership to the called function. However, typemaps match on argument type and name only, *not* on function names. A proper fix is to name function arguments(!) appropriately in order to denote transfer of ownership. This needs fixing in libyui header files. E.g. addItem( YItem *item) should be redeclared as addItem( YItem *item_disown) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Major -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c18 --- Comment #18 from Klaus Kämpf 2009-01-08 05:45:05 MST --- Great, thanks. YTableHeader:addColumn is certainly a candidate ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c20 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #20 from Stefan Hundhammer 2009-01-15 04:15:53 MST --- Fixed in SVN trunk. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c22 --- Comment #22 from Klaus Kämpf 2009-01-16 03:32:02 MST --- (In reply to comment #18)

Great, thanks.

YTableHeader:addColumn is certainly a candidate ;-)

No, its not. String references apparently are no problem. The real culprit was passing the YTableHeader pointer to YWidgetFactory::createTable(). Fixed in libyui svn rev 54677. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c24 Klaus Kämpf changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WORKSFORME --- Comment #24 from Klaus Kämpf 2009-01-16 03:54:34 MST --- Hmm, some example die deep inside libQt4 upon exit now. I cannot fix this any further :-( So WORKSFORME for now (the YTable example above runs fine). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=427372 User dl9pf@gmx.de added comment https://bugzilla.novell.com/show_bug.cgi?id=427372#c26 --- Comment #26 from Jan-Simon Möller 2009-01-19 16:27:11 MST --- Well done ! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.