[Bug 808565] New: screen status bar broken
https://bugzilla.novell.com/show_bug.cgi?id=808565 https://bugzilla.novell.com/show_bug.cgi?id=808565#c0 Summary: screen status bar broken Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 0 Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: seife@novell.slipkontur.de QAContact: qa-bugs@suse.de CC: jw@suse.com, mls@suse.com, trenn@suse.com Found By: Third Party Developer/Partner Blocker: --- Until todays Factory update, screen's status bar was like this: susi 5 bash - 0 mess 1 vdr 2 dslm 3 didl 4 gbx 5* bash 6 bash 7 ttyS0 now it is: susi 1 bash - 0 bash 1 bash 2 bash The asterisk * at the current session is missing. I'm pretty sure this was introduced by one of the last two changes: * Mon Feb 18 2013 trenn@suse.de - Introduce Xx string escape showing the executed command of a window patch: show_all_active.patch * Tue Feb 05 2013 trenn@suse.de - Add zombie and enhance windows commands -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c1
--- Comment #1 from Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c2
Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c3
--- Comment #3 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c4
Michael Schröder
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c
Michael Schröder
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c5
FeiXiang Zhang
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c6
Thomas Renninger
Thomas, is this really an intended change? No. I mixed up this: (longflg ? 0 : 2) in this line: ss = AddWindows(p, l - 1, (*s == 'w' ? 0 : 1) | (longflg ? 0 : 2) |\ (plusflg ? 4 : 0) | (minusflg ? 8 : 0), win ? win->w_number : -1);
longflg is set via L and is rather undocumented together with wW string escapes. So flag bit "2" is by default passed, but I thought it's not. I would like to remove this part totally: (longflg ? 0 : 2) %Lw would more or less get back what you had. With (longflg ? 0 : 2) part removed this is what you get via %w then. It would still be a minor change (more windows flags are displayed, like previous, Zombie) but this should be acceptable? Argh, it's not easy to take this into words. Again I would like to make: %Lw to %w and %Lw would not make a difference any more. Why? Because this allows quite some code cleanup. I use AddWindows() somewhere else and the flags adding is evil/hackish/... and it would get worse and worse. I now removed (longflg ? 0 : 2) in obs in Base:System/screen, could give it a try. This should be an acceptable change in wW display behavior? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c7
Thomas Renninger
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c8
Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c9
Thomas Renninger
I did not have the $ signs before...but that's not really a problem Yep, this was the slight change in favor for code cleaness I mentioned in the changelog and it's intended. Thanks. Setting resolved again.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c10
Jiri Bohac
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c
Michael Schröder
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c11
Michael Schröder
https://bugzilla.novell.com/show_bug.cgi?id=808565
https://bugzilla.novell.com/show_bug.cgi?id=808565#c12
Michael Schröder
participants (1)
-
bugzilla_noreply@novell.com