https://bugzilla.novell.com/show_bug.cgi?id=421588 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=421588#c1 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zypp-maintainers@forge.provo.novell.com Status|ASSIGNED |NEEDINFO Info Provider| |schubi@novell.com Priority|P4 - Low |P2 - High --- Comment #1 from Ján Kupec 2008-10-05 04:32:04 MDT --- No, --force should only trigger installation of a package even if it is alread installed. I guess this became broken when we switched to sat solover, but i'm not sure. 'zypper in --force' uses: PoolItem candidate = findCandidate(installed); // find better than the current one if (!candidate) candidate = installed; // fall back to the installed one if(!candidate.status().setToBeInstalled(zypp::ResStatus::USER)) candidate.status().setTransact(true, zypp::ResStatus::USER); This worked before, but now it triggers removal of the installed object instead of it's reinstallation. Schubi, what API should i use to force the solver to install the package despite it is already installed? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=421588 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=421588#c3 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |schubi@novell.com --- Comment #3 from Ján Kupec 2008-10-05 10:45:10 MDT --- (In reply to comment #2 from Stefan Schubert)

If "installed" is really an installed item then this item will be deleted in your code: setTransact.

Exactly.

So I believe that the "old" findCandite has returned an candidate everytime. (At least an item with the same NVRA as the installed) whereas findCanidate

Yes, that's why the behavior as described in this report. I fixed that already, but the --force issue is still not solved.

returns now NULL if there is no BETTER candidate available. So do not use setTransact. Just use setToBeInstalled.

Just setToBeInstalled does not work :O( It does nothing. It can be seen also from the implementation. If the status is installed, it just returns false: bool setToBeInstalled (TransactByValue causer) { if (isInstalled()) return false; return setTransact (true, causer); } But we need to make it install again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=421588 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=421588#c5 --- Comment #5 from Ján Kupec 2008-10-05 11:55:07 MDT --- Aaah, i see :O) OK, i will at least do it 'somehow' until Michl answers. But this should be fast enough: struct PoolItemGetter { PoolItem item; bool operator()(const PoolItem & pi) { item = pi; return false; } } PoolItem findInstalledItemInRepos(const PoolItem & installed) { const zypp::ResPool& pool = God->pool(); PoolItemGetter getter; invokeOnEach( pool.byIdentBegin(installed->kind(), installed->name()), pool.byIdentEnd(installed->kind(), installed->name()), functor::chain( functor::chain( resfilter::ByUninstalled(), resfilter::byEdition(installed->edition())), resfilter::byArch(installed->arch())), functor::functorRef(getter)); return getter.item; } I can also do it with a Selectable (we can add such method to the selectable) PoolItem Selectable::findInAvailable(const PoolItem & item) { PoolItemGetter getter; invokeOnEach( availableBegin(), availableEnd(), functor::chain( resfilter::byEdition(item->edition()), resfilter::byArch(item->arch()), functor::functorRef(getter)); return getter.item; } -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=421588 User ma@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=421588#c7 Michael Andres changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|ma@novell.com | --- Comment #7 from Michael Andres 2008-10-06 07:23:57 MDT --- Using byIdent iterator should be fast enough, as there's an index for it. - But 'pool.byIdentBegin(installed)' would be sufficient to construct the iterator. - PoolItemGetter does a common task, it picks the first match and stores it in a variable. I templated it and slightly rewrote it to get rid of the functorRef stuff. It's now in available in libzypp as functor::getFirst. - I also added filter::SameItemAs to libzypp, to encapsulate the 'is the same' package condition (it also includes a vendor check). Your code could look like this: PoolItem findInstalledItemInRepos( const PoolItem & installed) { zypp::ResPool pool(zypp::ResPool::instance()); PoolItem result; invokeOnEach( pool.byIdentBegin(installed), pool.byIdentEnd(installed), filter::SameItemAs( installed ), functor::getFirst( result ) ); return result; } -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=421588 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=421588#c9 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Status Whiteboard|in-svn | --- Comment #9 from Ján Kupec 2008-10-08 00:30:58 MDT --- submitted -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.