http://bugzilla.novell.com/show_bug.cgi?id=505153 User ptesarik@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c2 --- Comment #2 from Petr Tesařík 2009-05-28 06:57:36 MDT --- After another thousands of crashes, I decided to run Evolution in gdb again. And I've got a different backtrace this time: #0 0x00007f8b5a3c2a4b in camel_message_info_ptr (mi=0x7f8b3c496940, id=1) at camel-folder-summary.c:4556 #1 0x00007f8b43944f41 in update_junk_list (store=0x7c0ee0, info=0x7f8b3c496940, flag=1) at camel-groupwise-folder.c:538 #2 0x00007f8b439481ff in groupwise_sync (folder=0xc871b0, expunge=0, ex=0x7f8b30fc9660) at camel-groupwise-folder.c:592 #3 0x00007f8b4394dabf in groupwise_get_folder_info (store=0x7c0ee0, top=0x0, flags=<value optimized out>, ex=0x7f8b30fc9660) at camel-groupwise-store.c:1190 #4 0x00007f8b5a3e5f07 in camel_store_get_folder_info (store=0x7c0ee0, top=0x0, flags=7, ex=0x7f8b30fc9660) at camel-store.c:894 #5 0x00007f8b48d2b8c8 in get_folderinfo_exec (m=0x7f8b30fc9640) at mail-ops.c:1075 #6 0x00007f8b48d28a44 in mail_msg_proxy (msg=0x7f8b30fc9640) at mail-mt.c:520 #7 0x00007f8b4d489d27 in ?? () from /usr/lib64/libglib-2.0.so.0 #8 0x00007f8b4d488784 in ?? () from /usr/lib64/libglib-2.0.so.0 #9 0x00007f8b583b7070 in start_thread () from /lib64/libpthread.so.0 #10 0x00007f8b4d19f10d in clone () from /lib64/libc.so.6 #11 0x0000000000000000 in ?? () At frame #2, you're apparently getting an invalid folder pointer: (gdb) p *folder $5 = {parent_object = {klass = 0x0, magic = 0, hooks = 0xe73540, ref_count = 0, flags = 1, next = 0x0, prev = 0xc87270}, priv = 0x7f8b30b21610, name = 0x7f8b30b21440 "\220ϴ0\213\177", full_name = 0x7f8b30b21420 "p\024�0\213\177", description = 0x0, parent_store = 0x7c0ee0, summary = 0xd116c0, folder_flags = 7, permanent_flags = 31, later = {0x0, 0x0, 0x0, 0x0}} (gdb) p folder $6 = (CamelFolder *) 0xc871b0 (gdb) up #3 0x00007f8b4394dabf in groupwise_get_folder_info (store=0x7c0ee0, top=0x0, flags=<value optimized out>, ex=0x7f8b30fc9660) at camel-groupwise-store.c:1190 1190 CAMEL_FOLDER_CLASS (CAMEL_OBJECT_GET_CLASS (groupwise_store->current_folder))->sync(groupwise_store->current_folder, FALSE, ex); (gdb) p *(CamelGroupwiseStore*)store $18 = {parent_object = {parent_object = {parent_object = {parent_object = { klass = 0x7c15c0, magic = 2007188717, hooks = 0x887e80, ref_count = 7, flags = 0, next = 0x0, prev = 0x0}, priv = 0x818400, session = 0x746670, provider = 0x7f8b43b55fa0, status = CAMEL_SERVICE_CONNECTED, connect_op = 0x0, url = 0x818630}, priv = 0x818580, folders = 0x818480, cdb_r = 0x9a03d0, cdb_w = 0x9d1f00, flags = 4, mode = 3, later = {0x0, 0x0, 0x0, 0x0}}, state = 0}, summary = 0x87d170, root_container = 0xe41da0 "6.EMEA5.EMEA5-1.100.0.1.0.1@15", priv = 0x8185d0, current_folder = 0xc871b0, refresh_stamp = 0, list_loaded = 1} ^^^^^^^^^^^^^^^^^^^^^^^^^^ This is where the invalid value originated. <frustration>I wonder if anybody's interested in fixing Evolution, or if we should rather drop it.</frustration> -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User ptesarik@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c4 Petr Tesařík changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Evolution segfaults |Evolution segfaults |frequently after update |frequently after update - | |fully analyzed --- Comment #4 from Petr Tesařík 2009-05-28 09:38:45 MDT --- Got the sucker! Hardware watchpoint 3: *10886536 Old value = 1 New value = 0 camel_object_unref (vo=<value optimized out>) at camel-object.c:893 893 if (o->ref_count > 0 (gdb) bt #0 camel_object_unref (vo=<value optimized out>) at camel-object.c:893 #1 0x00007f718328791e in groupwise_store_set_current_folder ( groupwise_store=0x7d56e0, folder=0xa61d70) at camel-groupwise-storec:269 #2 0x00007f7183283dda in groupwise_transfer_messages_to (source=0xa61d70, uids=0x27487c0, destination=0xa61e30, transferred_uids=0x8, delete_originals=1, ex=0x2d14420) at camel-groupwise-folder.c:2373 #3 0x00007f71832841ee in groupwise_sync (folder=0xa61d70, expunge=0, ex=0x2d14420) at camel-groupwise-folder.c:616 #4 0x00007f7183289abf in groupwise_get_folder_info (store=0x7d56e0, top=0x0, flags=<value optimized out>, ex=0x2d14420) at camel-groupwise-storec:1190 #5 0x00007f719a75ef07 in camel_store_get_folder_info (store=0x7d56e0, top=0x0, flags=7, ex=0x2d14420) at camel-store.c:894 #6 0x00007f7187ff88c8 in get_folderinfo_exec (m=0x2d14400) at mail-ops.c:1075 #7 0x00007f7187ff5a44 in mail_msg_proxy (msg=0x2d14400) at mail-mt.c:520 #8 0x00007f718d802d27 in ?? () from /usr/lib64/libglib-2.0.so.0 #9 0x00007f718d801784 in ?? () from /usr/lib64/libglib-2.0.so.0 #10 0x00007f7198730070 in start_thread () from /lib64/libpthread.so.0 #11 0x00007f718d51810d in clone () from /lib64/libc.so.6 #12 0x0000000000000000 in ?? () If groupwise_sync() calls groupwise_transfer_messages_to(), which in turn can destroy the folder which was passed as argument to groupwise_sync(), then you cannot call update_junk_list() later in that function. Either you must revalidate that pointer somehow, or you must take an extra reference count on it. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User ptesarik@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c6 --- Comment #6 from Petr Tesařík 2009-05-29 05:50:29 MDT --- Created an attachment (id=295183) --> (http://bugzilla.novell.com/attachment.cgi?id=295183) bnc-505153-groupwise-crash.patch This patch seems to solve the issue for me. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User pchenthill@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c8 --- Comment #8 from Chenthill palanisamy 2009-06-01 01:31:25 MDT --- Petr, Thanks a lot for the patch. I think the patch just solves the symptom, but the actual problem seems elsewhere because groupwise_store_set_current_folder would just reset the current folder, it would just destroy the reference of current_folder which it holds. I suspect some other piece of code which is unreffing it. Please provide the valgrind traces also, it might show who is actually doing the extra unref. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User pchenthill@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c10 --- Comment #10 from Chenthill palanisamy 2009-06-01 02:27:36 MDT --- (In reply to comment #9)

Hi Chenthill, I'm not sure which unreffing you mean. As you can see, groupwise_sync() is entered with folder->ref_count = 1, and it first gets decremented to zero in groupwise_store_set_current_folder(), so it clearly doesn't keep the refcount balanced.

Do you mean the caller of groupwise_store_set_current_folder() should have incremented the refcount prior to calling it? Yes set_current_folder should have incremented it once. As you can see in the function, it adds a reference count while setting the current folder.

So i suspect somewhere else in the code, the reference count is decremented when it is not needed. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User ptesarik@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c12 --- Comment #12 from Petr Tesařík 2009-06-01 02:59:20 MDT --- Done. Unfortunately, I cannot see any function named set_current_folder(). What I _can_ see is the following sequence: 1. groupwise_sync() entered with folder->ref_count set to 1 2. ref_count incremented to 2 in camel_object_trigger_event(), called from groupwise_transfer_messages_to() here: 2365 camel_object_trigger_event (source, "folder_changed", changes); 3. ref_count decremented back to 1 in the same camel_object_trigger_event() 4. ref_count decremented to 0 in groupwise_store_set_current_folder(): 269 camel_object_unref (groupwise_store->current_folder); 5. ref_count incremented back to 1 on the (now invalid) folder in groupwise_store_set_current_folder(): 274 camel_object_ref (folder); Note that I used a hardware watchpoint on the refcount, so I'm quite certain that there were no other changes to the ref_count. Maybe, groupwise_store_set_current_folder() cannot correctly handle the case where folder == groupwise_store->current_folder ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 User ptesarik@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=505153#c14 --- Comment #14 from Petr Tesařík 2009-06-01 06:02:54 MDT --- Ah, ok, I misunderstood you. Hm, can't it be that the reference from groupwise_store_set_current_folder() is still there, but it happens to be the last one? Or do you mean that the caller of groupwise_sync() should take an extra reference on the folder it passes as argument? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 Akhil Laddha changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |groupwise, mailer Priority|P5 - None |P3 - Medium Component|Evolution |Evolution Version|Final |Milestone 2 AssignedTo|pchenthill@novell.com |bnc-team-evolution@forge.pr | |ovo.novell.com Product|openSUSE 11.1 |openSUSE 11.2 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=505153 http://bugzilla.novell.com/show_bug.cgi?id=505153#c17 --- Comment #17 from Stefan Behlert 2010-07-21 13:49:08 UTC --- Ping? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=505153 https://bugzilla.novell.com/show_bug.cgi?id=505153#c19 Akhil Laddha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED URL| |https://bugzilla.gnome.org/ | |show_bug.cgi?id=545505 Resolution| |FIXED Target Milestone|--- |unspecified --- Comment #19 from Akhil Laddha 2011-02-02 08:13:07 UTC --- Closing the bug as Fixed against openSUSE 11.4 which will have Evolution 2.32.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.