https://bugzilla.novell.com/show_bug.cgi?id=217388 Summary: A small fix for FT_GlyphSlot_Embolden() in order to handle advance correctly. Product: openSUSE 10.2 Version: Beta 1 plus Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: mfabian@novell.com ReportedBy: zsu@novell.com QAContact: qa@suse.de CC: wl@gnu.org, david@freetype.org In freetype 2.2.x's FT_GlyphSlot_Embolden(), there is a piece of code: FT_EXPORT_DEF( void ) FT_GlyphSlot_Embolden( FT_GlyphSlot slot ) { .. /* assume the layout is horizontal */ slot->advance.x += xstr; .. } Obviously, this piece of code can't handle vertical layout correctly. Below is a patch to fix this issue: --- src/base/ftsynth.c.old 2006-11-02 19:30:10.000000000 +0800 +++ src/base/ftsynth.c 2006-11-02 19:31:07.000000000 +0800 @@ -137,8 +137,11 @@ return; } - /* assume the layout is horizontal */ - slot->advance.x += xstr; + if (slot->advance.x) + slot->advance.x += xstr; + + if (slot->advance.y) + slot->advance.y += ystr; slot->metrics.width += xstr; slot->metrics.height += ystr; Because for horizontal layout, advance.y is always zero, vice versa. Please check whether it's correct or not. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.