https://bugzilla.novell.com/show_bug.cgi?id=329992 Cyril Hrubis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |schwab@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c1 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com --- Comment #1 from Andreas Schwab 2007-10-25 06:51:53 MST --- Bug in glibc. ^[A-Z] is supposed to match "p", but doesn't. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c3 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com --- Comment #3 from Andreas Schwab 2007-10-25 14:41:45 MST --- We are not talking about the POSIX locale, we are talking about the default locale. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c5 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com --- Comment #5 from Andreas Schwab 2007-10-25 15:20:46 MST --- I don't assume anything. I use facts. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c7 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com --- Comment #7 from Andreas Schwab 2007-10-25 15:45:00 MST --- See comment #1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c16 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com --- Comment #16 from Andreas Schwab 2007-11-27 08:13:53 MST --- glibc defines it as such. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c19 --- Comment #19 from Petr Baudis 2007-11-27 09:45:52 MST --- Hmm, as far as I can see GNU grep in non-POSIX locales leaves it up to glibc to decided which characters belong to a character range. So glibc is behaving correctly or grep wouldn't match the line at all. But maybe I'm overlooking something in the grep code? Anyway, can anyone reproduce this on 10.3? It looks like it is working properly to me - the first character is always colored... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c21 --- Comment #21 from Petr Baudis 2007-11-27 10:27:49 MST --- I see this in grep code: if (!hard_LC_COLLATE) { for (; c <= c2; c++) setbit_case_fold (c, ccl); } else { /* POSIX locales are painful - leave the decision to libc */ char expr[6] = { '[', c, '-', c2, ']', '\0' }; regex_t re; if (regcomp (&re, expr, case_fold ? REG_ICASE : 0) == REG_NOERROR) { for (c = 0; c < NOTCHAR; ++c) { char buf[2] = { c, '\0' }; regmatch_t mat; if (regexec (&re, buf, 1, &mat, 0) == REG_NOERROR && mat.rm_so == 0 && mat.rm_eo == 1) setbit_case_fold (c, ccl); } regfree (&re); } } hard_LC_COLLATE is set if the locale is not C or POSIX (the comment is confusing). But yes, now I see that these calls in fact probably don't go to libc but to lib/regex.c. But it seems to be used only conditionally? ltracing shows a lot of libc calls. It seems that grep prefers to use a separate mechanism for "rough matching" of lines and then uses regexp matching only on the line candidates, though I'm not sure if I understand the code correctly. Anyway, my Gentoo used to exhibit this bug but now it doesn't anymore (or maybe it's overriden by another bug because coloring works real strange here now), so I don't have any system where I could reproduce it. Did anyone else manage to reproduce this in-house? On what machine? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992#c23 --- Comment #23 from Michael Matz 2007-11-27 13:11:21 MST --- The code from comment #21 isn't reached in multibyte locales. When parsing the initial '[' it relatively early does this: #ifdef MBS_SUPPORT if (MB_CUR_MAX > 1) { /* In multibyte environment a bracket expression may contain multibyte characters, which must be treated as characters (not bytes). So we parse it by parse_bracket_exp_mb(). */ parse_bracket_exp_mb(); return lasttok = MBCSET; } #endif which will then set dfa->mbcsets[dfa->nmbcsets++] to the range in question. The actual matching in done in dfaexec, which for this regexp calls eventually match_mb_charset(), which uses wcscoll(3) to determine if the character is in the requested ranges. For 'p' this will return true, as expected from the collating sequence. So, that's why 'pippo' is matched at all, which is correct. When actually going to print this line then, it will use print_line_middle(). That in turn will, for every line it's supposed to print, run a regexp search for matches, in order to colorize them. _That_ matching is done with the normal libc regexp machinery. Like so: print_line_middle: while ( lim > cur && ((match_offset = execute(beg, lim - beg, &match_size, beg + (cur - beg))) != (size_t) -1)) { .... do something from match_offset ... execute is EGexecute for us, hence: EGexecute: for (beg = end = buf; end < buflim; beg = end) { if (!start_ptr) // it's non-zero for us else for (i = 0; i < pcount; i++) { patterns[i].regexbuf.not_eol = 0; if (0 <= (start = re_search (&(patterns[i].regexbuf), buf, end - buf - 1, beg - buf, end - beg - 1, &(patterns[i].regs)))) { So, this goes through all defined patterns (in our case only one), and uses re_search on the line with the pattern. The regexbuf member is filled by calls to re_compile_pattern in GEAcompile. re_search and re_compile_pattern come from libc, grep is not using the versions from lib/regex.c . I've verified that re_search does match the capital 'P' but not the small 'p'. So this definitely disagrees with what wcscoll() returns for the range endpoints and 'p'. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=329992 Andreas Schwab changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|schwab@novell.com |pbaudis@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.