https://bugzilla.novell.com/show_bug.cgi?id=457098 User suse-beta@cboltz.de added comment https://bugzilla.novell.com/show_bug.cgi?id=457098#c7 Christian Boltz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #7 from Christian Boltz 2009-02-26 14:17:51 MST --- Just some comments on this (and sorry for the late reaction): Preamble: I'm reopening this bug to make sure everybody involved (Jeff and Werner or Henne [whoever is the current vim maintainer]) reads this. You can close it again after both of you have added a "seen" sign ;-) a) most important: bug handling in apparmor.vim Jeff, please assign all bugs related to apparmor.vim directly to me instead of patching it. See b) for the reason ;-) b) technical stuff: - apparmor.vim is generated from a apparmor.vim.in and a script that replaces about 10 placeholders (like @@FILE@@) with the actual rule. The reason for this: Maintaining the final apparmor.vim directly would cause lots of headache - currently it uses about 60 placeholders, which are often used multiple times (for example, @@FILE@@ appears 14 times). Besides the headache, it would also be error prone - I can tell you a thing or two (or "sing some songs" as we german say) about code duplication (with different bugs in each copy!) since I started to cleanup the postfixadmin code... BTW: The only thing that is worse than code duplication is code multiplication ;-) - the .in and the script only exist on my machine (in a local CVS). - if you want to have these files in a public CVS or SVN somewhere, just send me the location and give me write permissions ;-) c) audit_control capability Should the audit_control capability be in the sdKapDanger color (darkred) like sys_admin instead of being highlighted as "normal" capability? (The reason for asking: controlling auditing means someone is probably able to bypass apparmor logging etc.) d) filetype.vim patch / packaging adding au BufNewFile,BufRead */etc/apparmor.d/* setf apparmor au BufNewFile,BufRead */etc/apparmor/profiles/* setf apparmor to filetype.vim is a really good idea. It would even be a better idea to make this section a separate patch - I usually provide a new apparmor.vim after apparmor changes (or after fixing bugs ;-) , and this happens more often than the changes needed for filetype.vim. You should also consider to add apparmor.vim as %sourceX and installing it via %{__INSTALL} instead of "converting" it to a patch. e) finally: the strange characters The strange characters reported in this bug were probably caused by copy&paste when I edited the script that generates apparmor.vim - it's the same character I use as "line continues" character in vim ("»" in iso-8859-15). Looks like I should use "yy" instead of the mouse when copying text in vim... ;-) I fixed my local files, so this bug shouldn't re-appear. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.